From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Drew Adams" Newsgroups: gmane.emacs.bugs Subject: bug#12507: Option `(bookmark-)version-control': Use :tag so docstring matches menu Date: Sun, 30 Sep 2012 21:06:00 -0700 Message-ID: <63E9C48B6DE546C0A47EA79246A64BD1@us.oracle.com> References: <87y5jqhnff.fsf@floss.red-bean.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1349064404 17439 80.91.229.3 (1 Oct 2012 04:06:44 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 1 Oct 2012 04:06:44 +0000 (UTC) To: "'Karl Fogel'" , <12309@debbugs.gnu.org>, <12507@debbugs.gnu.org> Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Oct 01 06:06:48 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TIXHM-00046m-CX for geb-bug-gnu-emacs@m.gmane.org; Mon, 01 Oct 2012 06:06:48 +0200 Original-Received: from localhost ([::1]:36346 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TIXHG-0000uh-SM for geb-bug-gnu-emacs@m.gmane.org; Mon, 01 Oct 2012 00:06:42 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:51649) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TIXHD-0000tk-Fr for bug-gnu-emacs@gnu.org; Mon, 01 Oct 2012 00:06:40 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TIXHC-0000UU-Bm for bug-gnu-emacs@gnu.org; Mon, 01 Oct 2012 00:06:39 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:54045) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TIXHC-0000UQ-8R for bug-gnu-emacs@gnu.org; Mon, 01 Oct 2012 00:06:38 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1TIXHa-0001UI-F0 for bug-gnu-emacs@gnu.org; Mon, 01 Oct 2012 00:07:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Drew Adams" Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 01 Oct 2012 04:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12507 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 12507-submit@debbugs.gnu.org id=B12507.13490644025680 (code B ref 12507); Mon, 01 Oct 2012 04:07:02 +0000 Original-Received: (at 12507) by debbugs.gnu.org; 1 Oct 2012 04:06:42 +0000 Original-Received: from localhost ([127.0.0.1]:35355 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TIXHG-0001TX-9I for submit@debbugs.gnu.org; Mon, 01 Oct 2012 00:06:42 -0400 Original-Received: from rcsinet15.oracle.com ([148.87.113.117]:22463) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TIXHE-0001TN-5f; Mon, 01 Oct 2012 00:06:41 -0400 Original-Received: from ucsinet22.oracle.com (ucsinet22.oracle.com [156.151.31.94]) by rcsinet15.oracle.com (Sentrion-MTA-4.2.2/Sentrion-MTA-4.2.2) with ESMTP id q9146EHC009589 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 1 Oct 2012 04:06:14 GMT Original-Received: from acsmt357.oracle.com (acsmt357.oracle.com [141.146.40.157]) by ucsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id q9146D3H021387 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 1 Oct 2012 04:06:13 GMT Original-Received: from abhmt108.oracle.com (abhmt108.oracle.com [141.146.116.60]) by acsmt357.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id q9146DHx003441; Sun, 30 Sep 2012 23:06:13 -0500 Original-Received: from dradamslap1 (/10.159.219.231) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Sun, 30 Sep 2012 21:06:12 -0700 X-Mailer: Microsoft Office Outlook 11 In-Reply-To: <87y5jqhnff.fsf@floss.red-bean.com> Thread-Index: Ac2fhkQQN3azpVovR7u3RU/ags41RwAAPhXw X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 X-Source-IP: ucsinet22.oracle.com [156.151.31.94] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:65047 Archived-At: Ouch! You fixed bug #12309, Karl (thanks; looks good). But you closed bug #12507 instead. Please reopen #12507 and correct the subject lines etc. of the mails if needed, so that things are put right again. It is #12309 that should be closed, not @12507. To answer your questions: `other' in a `choice' just means any value other than the other choices listed. If the user picks the `other' choice interactively then the value given (`t' here) is used. E.g., if you set the variable to 99999 (outside of Customize) then it will act just like a value of `t'. The last sentence of the original report just meant to please at least use a :tag for the `other' choice. It is the one where a :tag is most important for clarity. But you've added :tag for each of them, which is even better. Thx - Drew P.S. FWIW, here is what I've been using for this defcustom. It's almost the same as what you have. "Whether to make numbered backups of your bookmarking files. The option can have value `nospecial', `t', `nil', or `never' . Value `nospecial' means to use the `version-control' value. The others have the same meanings as for option `version-control'. Use value `t' if your bookmarks are important to you. Consider also using numeric backups. See also nodes `Backup Names' and `Backup Deletion' in the Emacs manual." :type '(choice :tag "When to make numbered backups" (const :tag "Use value of option `version-control'" nospecial) (const :tag "Never" never) (const :tag "If existing already" nil) (other :tag "Always" t)) > From: Karl Fogel Sent: Sunday, September 30, 2012 8:38 PM > To: 12507-done@debbugs.gnu.org > Subject: bug#12507: Option `(bookmark-)version-control': Use > :tag so docstring matches menu > > Fixed (see below), but please review. > > I don't fully understand the whole customization system > because I never > use it myself (I just read doc strings and set variables directly in > Elisp), so I don't quite get what `other' mean if used instead of > `const', and I didn't fully understand the last paragraph of the > original bug report. I looked in the Info pages, but they didn't > clarify much about this. > > -Karl > > Revision info: > > revno: 110305 > revision-id: kfogel@red-bean.com-20121001033206-5eja4ztyhs1sjm7q > parent: cyd@gnu.org-20121001031702-2mei04wuzv2pk1e7 > committer: Karl Fogel > branch nick: trunk > timestamp: Sun 2012-09-30 22:32:06 -0500 > message: > * lisp/bookmark.el (bookmark-version-control): Give tags in the > :type choices (Bug#12309), and improve doc string. > > Diff: > > === modified file 'lisp/ChangeLog' > --- lisp/ChangeLog 2012-10-01 02:07:14 +0000 > +++ lisp/ChangeLog 2012-10-01 03:31:41 +0000 > @@ -1,3 +1,8 @@ > +2012-10-01 Karl Fogel > + > + * bookmark.el (bookmark-version-control): Give tags in the > + :type choices (Bug#12309), and improve doc string. > + > 2012-10-01 Paul Eggert > > Revert the FOLLOW-SYMLINKS change for file-attributes. > > === modified file 'lisp/bookmark.el' > --- lisp/bookmark.el 2012-09-25 04:13:02 +0000 > +++ lisp/bookmark.el 2012-10-01 03:32:18 +0000 > @@ -99,12 +99,14 @@ > > (defcustom bookmark-version-control 'nospecial > "Whether or not to make numbered backups of the bookmark file. > -It can have four values: t, nil, `never', and `nospecial'. > +It can have four values: t, nil, `never', or `nospecial'. > The first three have the same meaning that they do for the > -variable `version-control', and the final value > `nospecial' means just > -use the value of `version-control'." > - :type '(choice (const nil) (const never) (const nospecial) > - (other t)) > +variable `version-control'; the value `nospecial' (the > default) means > +just use the value of `version-control'." > + :type '(choice (const :tag "If existing" nil) > + (const :tag "Never" never) > + (const :tag "Use the value of > `version-control'" nospecial) > + (const :tag "Always" t)) > :group 'bookmark)