From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#29201: 26.0.90; Flymake skips indicator when a backend reports a diagnostic at EOB Date: Fri, 10 Nov 2017 02:02:04 +0200 Message-ID: <638b80d6-2772-7650-b4ac-f43c3146bfaf@yandex.ru> References: <38b19877-7ddf-673f-f9e0-de422e5251e6@yandex.ru> <87vaiji21a.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1510272194 3276 195.159.176.226 (10 Nov 2017 00:03:14 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 10 Nov 2017 00:03:14 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:56.0) Gecko/20100101 Thunderbird/56.0 Cc: 29201@debbugs.gnu.org To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Nov 10 01:03:10 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eCwmo-0000WH-J4 for geb-bug-gnu-emacs@m.gmane.org; Fri, 10 Nov 2017 01:03:06 +0100 Original-Received: from localhost ([::1]:39547 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eCwmv-0007Yq-Uo for geb-bug-gnu-emacs@m.gmane.org; Thu, 09 Nov 2017 19:03:13 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34318) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eCwmq-0007Yk-6w for bug-gnu-emacs@gnu.org; Thu, 09 Nov 2017 19:03:09 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eCwml-0002hz-6W for bug-gnu-emacs@gnu.org; Thu, 09 Nov 2017 19:03:08 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:52416) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eCwml-0002hf-2V for bug-gnu-emacs@gnu.org; Thu, 09 Nov 2017 19:03:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eCwmk-00026v-Gk for bug-gnu-emacs@gnu.org; Thu, 09 Nov 2017 19:03:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 10 Nov 2017 00:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29201 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 29201-submit@debbugs.gnu.org id=B29201.15102721378052 (code B ref 29201); Fri, 10 Nov 2017 00:03:02 +0000 Original-Received: (at 29201) by debbugs.gnu.org; 10 Nov 2017 00:02:17 +0000 Original-Received: from localhost ([127.0.0.1]:32864 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eCwm0-00025o-MI for submit@debbugs.gnu.org; Thu, 09 Nov 2017 19:02:16 -0500 Original-Received: from mail-wm0-f52.google.com ([74.125.82.52]:50208) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eCwlx-00025Z-9b for 29201@debbugs.gnu.org; Thu, 09 Nov 2017 19:02:13 -0500 Original-Received: by mail-wm0-f52.google.com with SMTP id b9so222191wmh.5 for <29201@debbugs.gnu.org>; Thu, 09 Nov 2017 16:02:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=yH02GVgmRZS3aMF9yzzBgQ4BTnEyWAWB68ZI5u+yT8Q=; b=M2f1g2kVPrCKM8qED9xAJzNQvh8II8XGpqmDfzLbyv/ZntU+7rnQJy/Fd9CWHTGROl ez8OEA47G6QFOvBXimd4wVOE5hBX9RPK0VifpKvb845g59W1ta26DtEdtT+iGu+S574x 9ybse/V/GCnDR1YvRJmKrFXLrphHAVmTADgBQ4QJVoNPOOmmzM/BW/mZEtIlpFkC/bWX p9CaDP10KQXwV/j6+Y7TIPUlnH5CoRJMPa6JDOcrFIbsun2Ksu0a6Ue4Bto4TUgmjGZ4 LFCaoplNmdpmhHJPeqRZhWHcZPQkQ/OK74K9FHPyp6mXDI3kqDAolXvbmB6e/pPvlyyQ SZcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=yH02GVgmRZS3aMF9yzzBgQ4BTnEyWAWB68ZI5u+yT8Q=; b=kv7g7lao5r7Df+ViFFJNSQJdj6YIIz9IDb0ZIqP++Jj/ditXrrQRLrVGgp5y74/RU/ rC3n+vPkjXfwJ2JyCdFRY08TR9+ZOltrTU3S6NWB+el5aE6XfSvrHB/zvL6i1yS411MZ 44N3Jqr4zCaxZZOuxI/5KYmRdzNyjplKqTZ9GGcRWc8fmuZuy9DIgB7ZGk8VCX03KMQb suoVCVuWCAZUYnRV3IgtljlkQxi9FbIAHDR8cZkvfzl9dbNtdmG1PnbURMMBolcSA2Xb VXtWDEQEeFqTNdLZuSv3LBu41VxdiNPtZgIRVVVCXtx4BOK3ktwmd8IslV9p/J1samzB OWOQ== X-Gm-Message-State: AJaThX4ljrqr1MwQNaJrmiOc6aaAn77nlqjU062G1FMjjC5+w78DP1yz hcrn02/7pegZqVxLI8NU9ZyNn6Wk X-Google-Smtp-Source: AGs4zMaxJu6yezsgOr/wmMK9Td0GS2kglEjIvlcioTfl6wPWmtPy9jTuHtjvUjhFYxing08UvbBo2Q== X-Received: by 10.28.87.206 with SMTP id l197mr1130556wmb.45.1510272127389; Thu, 09 Nov 2017 16:02:07 -0800 (PST) Original-Received: from [192.168.1.3] ([185.105.174.193]) by smtp.googlemail.com with ESMTPSA id d4sm171672wmh.35.2017.11.09.16.02.05 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 09 Nov 2017 16:02:06 -0800 (PST) In-Reply-To: <87vaiji21a.fsf@gmail.com> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:139700 Archived-At: On 11/9/17 11:18 PM, João Távora wrote: > "Backtracking a little" sounds OK but highlighting the last symbol is a > little more contentious and harder to do (though I'm open to that > argument). That's okay. > Anyway, this is a simple bug because my original idea was to make this > case behave like the case where the last line is referenced but without > a column indication. Inside flymake-diag-region, this should funnel into > fallback-eol but in this particular case it wasn't doind that because I > forgot that (goto-char one-trillion) doesn't error. > > Fixed in 535688a4181ae4052db354ce2b877507f11c9e66. The idea sounds fine, but it doesn't work when the last line of the buffer is empty (e.g. when the file ends with a newline, like with require-final-newline set to t): highlighting the last line still ends up creating a zero-size overlay. So I think the important point is to skip the trailing whitespace first. Maybe this calls for a test case or two.