From: Dmitry Gutov <dgutov@yandex.ru>
To: "João Távora" <joaotavora@gmail.com>
Cc: 29201@debbugs.gnu.org
Subject: bug#29201: 26.0.90; Flymake skips indicator when a backend reports a diagnostic at EOB
Date: Fri, 10 Nov 2017 02:02:04 +0200 [thread overview]
Message-ID: <638b80d6-2772-7650-b4ac-f43c3146bfaf@yandex.ru> (raw)
In-Reply-To: <87vaiji21a.fsf@gmail.com>
On 11/9/17 11:18 PM, João Távora wrote:
> "Backtracking a little" sounds OK but highlighting the last symbol is a
> little more contentious and harder to do (though I'm open to that
> argument).
That's okay.
> Anyway, this is a simple bug because my original idea was to make this
> case behave like the case where the last line is referenced but without
> a column indication. Inside flymake-diag-region, this should funnel into
> fallback-eol but in this particular case it wasn't doind that because I
> forgot that (goto-char one-trillion) doesn't error.
>
> Fixed in 535688a4181ae4052db354ce2b877507f11c9e66.
The idea sounds fine, but it doesn't work when the last line of the
buffer is empty (e.g. when the file ends with a newline, like with
require-final-newline set to t): highlighting the last line still ends
up creating a zero-size overlay.
So I think the important point is to skip the trailing whitespace first.
Maybe this calls for a test case or two.
next prev parent reply other threads:[~2017-11-10 0:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-07 23:26 bug#29201: 26.0.90; Flymake skips indicator when a backend reports a diagnostic at EOB Dmitry Gutov
2017-11-09 21:18 ` João Távora
2017-11-10 0:02 ` Dmitry Gutov [this message]
2017-11-10 5:32 ` João Távora
2017-11-10 11:19 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=638b80d6-2772-7650-b4ac-f43c3146bfaf@yandex.ru \
--to=dgutov@yandex.ru \
--cc=29201@debbugs.gnu.org \
--cc=joaotavora@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).