From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#44210: 28.0.50; project.el failed to work after customizing find-program to fd Date: Sun, 10 Jan 2021 19:48:32 +0200 Message-ID: <636aabc5-b636-bc17-9d76-4aff28f4f60a@yandex.ru> References: <5FB48AB0-62C1-48BB-A196-A72DFACE2CA0@kuaishou.com> <7AE961A3-205F-4CC4-9634-2D981FF470CC@kuaishou.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17845"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 Cc: "condy0919@gmail.com" To: Zhiwei Chen , "44210@debbugs.gnu.org" <44210@debbugs.gnu.org> Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jan 10 18:49:09 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kyepx-0004X3-Pp for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 10 Jan 2021 18:49:09 +0100 Original-Received: from localhost ([::1]:58420 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kyepw-0008UR-Br for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 10 Jan 2021 12:49:08 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43080) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kyepp-0008U8-Vc for bug-gnu-emacs@gnu.org; Sun, 10 Jan 2021 12:49:01 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:43303) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kyepp-0007uc-Ma for bug-gnu-emacs@gnu.org; Sun, 10 Jan 2021 12:49:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kyepp-0007oi-K5 for bug-gnu-emacs@gnu.org; Sun, 10 Jan 2021 12:49:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 10 Jan 2021 17:49:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44210 X-GNU-PR-Package: emacs Original-Received: via spool by 44210-submit@debbugs.gnu.org id=B44210.161030092530023 (code B ref 44210); Sun, 10 Jan 2021 17:49:01 +0000 Original-Received: (at 44210) by debbugs.gnu.org; 10 Jan 2021 17:48:45 +0000 Original-Received: from localhost ([127.0.0.1]:54849 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kyepY-0007oB-SQ for submit@debbugs.gnu.org; Sun, 10 Jan 2021 12:48:45 -0500 Original-Received: from mail-wm1-f50.google.com ([209.85.128.50]:33363) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kyepW-0007nx-JF for 44210@debbugs.gnu.org; Sun, 10 Jan 2021 12:48:43 -0500 Original-Received: by mail-wm1-f50.google.com with SMTP id n16so9690115wmc.0 for <44210@debbugs.gnu.org>; Sun, 10 Jan 2021 09:48:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=aQx7nn16rD+3//C7LYagHErM52Rxjaxc3Fi6eGa+2aI=; b=PAvNB3JK+aWGISnRRAdBLHC0WCXjOt37fLJDBQNL5ppJ+1GaBulH+u0IwqN1dYxOcq NOz0wXEmX+g3hd/InlDZk5IIdeowaagBtfZ2X8NWcMaDAVcADVe1mGd4GVcsMZgo1MXD jvkk/fOZvP41aTn+r78mnoCoFJ7dLEgf+gUNZR8zs1GW4s+VQR3bHeDbphM1W4vCSeqp 2VWh9VdgDPRm4RCodwsI7qsV4ceSHR2Bbgj6sbmCfsDSM2/D2tzYBAhoTcJU64rNl7s5 tZx7XZ2rQ1nSm/auSMHNroCO+A+Ql3qs5ZtejLRAuuo5k8yzywuyptkEn1M98vf34ykK JtQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=aQx7nn16rD+3//C7LYagHErM52Rxjaxc3Fi6eGa+2aI=; b=JU9FC7NT0lraJrY0108BRqhSto2Fxc3XrV6c0E1rlpOQrDvN+RzXn9gX0nu2dEd9Jz +6HtuOkQdd7wxsIYoZLuq8agfNUIsX7UhGai+/rFg+dqywzlUC5NEf72PmgZmdnUrFk+ NkXp2aBS0pACnyFmC1bzESf9SGwRlVmYstBDD0dcq2pQ2gpbSo8Yavov2kYeF5v+svQi +krABZbDtf+xTtryEqweYUBZU9o0oglvb57Xeeq3K+OR1LIb07AQFc0L7E4vgeXlhdA4 al0Wtzosa7EmXCSowK9/YScX7yUH1DGm00RvUealBTbYk/Ou8UClIe05vDhk0nQmRtp7 o/Jw== X-Gm-Message-State: AOAM532hYldNwdfjs87z6BEmGbCrsz/ujqNKImHnBKBSQns51Mv/mkSy lJ2OLpq+XlXcTziwvaijQuY= X-Google-Smtp-Source: ABdhPJy5L2TY2L5G9BccuyO5KQCqVKorqPEVGriXafIH4W/fpeLlaeXauvySyhg9gCoZxn5FNKTgkw== X-Received: by 2002:a1c:2c4:: with SMTP id 187mr11809958wmc.187.1610300916755; Sun, 10 Jan 2021 09:48:36 -0800 (PST) Original-Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id u26sm19064981wmm.24.2021.01.10.09.48.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 10 Jan 2021 09:48:35 -0800 (PST) In-Reply-To: <7AE961A3-205F-4CC4-9634-2D981FF470CC@kuaishou.com> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:197651 Archived-At: Hi! On 10.01.2021 05:37, Zhiwei Chen wrote: > (defun project--files-in-directory-fd (dir ignores &optional files) >   (require 'find-dired) >   (require 'xref) >   (defvar find-name-arg) >   (let* ((default-directory dir) >          ;; Make sure ~/ etc. in local directory name is >          ;; expanded and not left for the shell command >          ;; to interpret. >          (localdir (file-local-name (expand-file-name dir))) >          (command (format "%s . %s %s --type f %s --print0" >                           "fd" >                           ;; In case DIR is a symlink. >                           (file-name-as-directory localdir) >                           "" >                           (if files >                               (concat (shell-quote-argument "(") >                                       " " find-name-arg " " >                                       (mapconcat >                                        #'shell-quote-argument >                                        (split-string files) >                                        (concat " -o " find-name-arg " ")) >                                       " " >                                       (shell-quote-argument ")")) >                             "")))) >     (message command) >     (project--remote-file-names >      (sort (split-string (shell-command-to-string command) "\0" t) >            #'string<)))) That code doesn't seem to handle the IGNORES argument at all. Which could lead to an imbalanced comparison, though I don't know if it does, in this example (with just one ignored dir). But you could try passing no ignores to both of them. It's weird, though. I have just tried both functions, and there was no perceptible performance difference (in a different project, though; in gecko-dev). What are the versions of said programs on your machine? Mine: $ find --version find (GNU findutils) 4.7.0 $ fdfind --version fd 7.4.0