From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.bugs Subject: bug#71107: 29.3; eshell-hist/Incorrect history handling with eshell-hist-ignoredups 'erase Date: Thu, 23 May 2024 16:33:51 -0700 Message-ID: <634c838e-9a20-816f-d786-d01ccf75b5e1@gmail.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4051"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 71107@debbugs.gnu.org, eli@gnu.org To: Robin Campbell Joy Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri May 24 01:36:28 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sAHz2-0000ui-9r for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 24 May 2024 01:36:28 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sAHyY-0006FG-J3; Thu, 23 May 2024 19:35:58 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sAHyW-0006Er-5D for bug-gnu-emacs@gnu.org; Thu, 23 May 2024 19:35:56 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sAHyV-0003Kl-Qo for bug-gnu-emacs@gnu.org; Thu, 23 May 2024 19:35:55 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sAHyc-0000OY-42 for bug-gnu-emacs@gnu.org; Thu, 23 May 2024 19:36:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 23 May 2024 23:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71107 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 71107-submit@debbugs.gnu.org id=B71107.17165073121511 (code B ref 71107); Thu, 23 May 2024 23:36:02 +0000 Original-Received: (at 71107) by debbugs.gnu.org; 23 May 2024 23:35:12 +0000 Original-Received: from localhost ([127.0.0.1]:33359 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sAHxn-0000OJ-T6 for submit@debbugs.gnu.org; Thu, 23 May 2024 19:35:12 -0400 Original-Received: from mail-pl1-f170.google.com ([209.85.214.170]:50672) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sAHxh-0000Nj-Oz for 71107@debbugs.gnu.org; Thu, 23 May 2024 19:35:09 -0400 Original-Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-1f44b513017so1904145ad.1 for <71107@debbugs.gnu.org>; Thu, 23 May 2024 16:34:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1716507233; x=1717112033; darn=debbugs.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=yCsyrSHNQWsFr3n5s2v8vS0ID77/pnICv3PV3gtIj6E=; b=TNJeCAO4HEK9Bs/9LJ10pV9rWwNaG/TTGdy1/n7UCrKFWrkR4oX7ux4FBVOluGIkst DNecUXhJCGUe29WPrPluVG03h/IksUFWOuXCV8l5gpT3Te7DwRNAe8r9bh3Rsmjgu8fF aUJiMKxxAqR3U+VnpmgEsHQZAsAFQvcdna32IRL8vUdlWrBdfMVUKl16i8z15x6JI/wz 9Lji0ZW3PmaFh8jquvNoUnFVqLndt3tELjRXPntERozqOOBSWqAfTfZYTFjYM2ScE2D8 tvEyW96CkMxCVn20tX1TwoK+nGdKQ8OqAu5ZxYcacpLu4qWJHEM6SpyYbTEyDVMsb5Cr K3BQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716507233; x=1717112033; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=yCsyrSHNQWsFr3n5s2v8vS0ID77/pnICv3PV3gtIj6E=; b=erQXWQCryIQsF+nuIG5DFhGZTpbi8/VNSuf6w3bFAM0mvK9bhEm6LQfpUkHWvKOwdW qWL/jfwEr7Akdg1MIi5RvD/fjKG8wK0Vo+XyHdw5oFTRt9MUakyxa6noWEs7SIc4IlnW F4BJ9H90ZqqZ2Fu/mb1H3VZFzDhy8xD+O3qNmmqIUSnDTNssNOP/eLDz+TVyB2GJKKL+ GZyEFp42bKnilFo3+xHB/PiFUUy84+hywr2tEMMkE71MoprUwtTT+zyinmiLjbQIXEtB 8d2UTq72zN6KC8DJxcezmigjXg/UMniNhUMKEG0kKb076/lsNh7Obs4JA+z8i3N3TAYg ELNg== X-Gm-Message-State: AOJu0YwLOkvHpbTYbqMHl61+jqE+yrcdNF42kITa6ErIrB49wiyie7iH FLUifQ6jTQWcwc2iz7QQWZjvf+52QkaiIdrcwePlLcqIifwVuZe6 X-Google-Smtp-Source: AGHT+IFAk363lkzqmmR+kizSq07CtA1XTu4BJdhUgCmRlSpA67o29Non1R8InKjV6IB8ANqpkbD+pA== X-Received: by 2002:a17:903:18a:b0:1e4:3df0:38a5 with SMTP id d9443c01a7336-1f4498e13f2mr8115265ad.65.1716507233126; Thu, 23 May 2024 16:33:53 -0700 (PDT) Original-Received: from [192.168.1.2] (syn-023-240-098-037.res.spectrum.com. [23.240.98.37]) by smtp.googlemail.com with ESMTPSA id d9443c01a7336-1f44c7bb389sm1357035ad.92.2024.05.23.16.33.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 May 2024 16:33:52 -0700 (PDT) Content-Language: en-US In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:285731 Archived-At: On 5/22/2024 11:22 PM, Robin Campbell Joy wrote: > Thanks, not sure why I didn't find this when looking for an existing > bug, should have checked master first though. > > Attached the rebased patch. Thanks for fixing this. Thanks for the updated patch. From a visual inspection, this all looks good to me. Just two small things and then I think this is good to merge: 1) Could you add a commit message in the usual style (you can look at the other Emacs commits to get an idea of what these look like), and then generate the patch file with `git format-patch master`? This'll make it easier for me to apply the patch without having to write up a commit message myself. 2) Have you filled out copyright assignment paperwork with the FSF? While the code changes are below the maximum (15 lines) for no paperwork, the tests push it over. (I'm not 100% sure if we count test code for the copyright stuff.) I don't think I can check the paperwork status for people myself, but hopefully Eli (CCed) can help if needed.