From: Drew Adams <drew.adams@oracle.com>
To: npostavs@users.sourceforge.net
Cc: Lars Ingebrigtsen <larsi@gnus.org>, 19362@debbugs.gnu.org
Subject: bug#19362: 25.0.50; Fix `pp.el' in line with new `elisp-mode.el'
Date: Thu, 7 Jul 2016 02:34:48 +0000 (UTC) [thread overview]
Message-ID: <62e491fa-9863-47d6-8954-26b6368185f9@default> (raw)
In-Reply-To: <87bn2acmye.fsf@users.sourceforge.net>
> Well, we could have all saved some time if you had taken your own advice
> to diff the code; not pp.el vs elisp-mode.el, but emacs-24.5's
> lisp-mode.el vs the new elisp-mode.el. You can see in the attached diff
> (exerpted to leave only the relevant functions) that the only changes
> are renaming of functions, and some minor refactoring in
> elisp--preceding-sexp (it now handles ‘foo’ as well as `foo').
I never suggested diffing pp.el against either lisp-mode.el or
elisp-mode.el. And actually I did compare lisp-mode.el with
elisp-mode.el and different versions of lisp-mode.el. I said
this, which I maintain:
> Yes, well, it's quite difficult. Some of the code from lisp-mode.el
> was moved to elisp-mode.el. And then it was modified, in some cases
> radically. Dunno why, except that some of the changes seem to have
> involved integrating eldoc. But most of the changes presumably do not
> concern this bug, which is only about the part of lisp-mode.el that
> had functions that correspond to pp.el functions.)
It should be clear that wrt what I was following (and comparing)
of the evolution, what I saw was not just renaming of functions
and minor refactoring. But of course I was also trying to see
how the changes compared to the pp.el code - what corresponding
changes might be in order for pp.el. That was, uh, the point of
the report. Whatever. Thanks for taking a look anyway. Sorry
that you apparently wasted your time.
prev parent reply other threads:[~2016-07-07 2:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-13 2:46 bug#19362: 25.0.50; Fix `pp.el' in line with new `elisp-mode.el' Drew Adams
2016-04-30 16:26 ` Lars Ingebrigtsen
2016-04-30 17:36 ` Drew Adams
2016-04-30 17:43 ` Lars Ingebrigtsen
2016-04-30 18:16 ` Drew Adams
2016-04-30 18:33 ` Lars Ingebrigtsen
2016-07-01 2:04 ` npostavs
2016-07-01 3:07 ` Drew Adams
2016-07-06 20:39 ` Noam Postavsky
2016-07-06 22:35 ` Drew Adams
2016-07-06 23:36 ` Noam Postavsky
2016-07-06 23:51 ` Drew Adams
2016-07-07 0:26 ` npostavs
2016-07-07 2:34 ` Drew Adams [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=62e491fa-9863-47d6-8954-26b6368185f9@default \
--to=drew.adams@oracle.com \
--cc=19362@debbugs.gnu.org \
--cc=larsi@gnus.org \
--cc=npostavs@users.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).