From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.bugs Subject: bug#72013: The eshell/kill command doesn't work with eshell/sudo correctly Date: Sun, 14 Jul 2024 15:17:27 -0700 Message-ID: <62c37559-646f-19cb-c6c8-f012caf79651@gmail.com> References: <3f7aae11-2569-3cba-e937-2511a3c00504@gmail.com> <87frsh8zw4.fsf@gmx.de> <7d55215c-bd61-3cb4-aab2-177a74fc1d08@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------I5g5KyN78d9rTb5z20Igpxlv" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21302"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 72013@debbugs.gnu.org, the_wurfkreuz To: Michael Albinus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jul 15 00:19:18 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sT7Ys-0005RZ-CX for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 15 Jul 2024 00:19:18 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sT7Yc-0005mv-EE; Sun, 14 Jul 2024 18:19:02 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sT7Ya-0005mU-F5 for bug-gnu-emacs@gnu.org; Sun, 14 Jul 2024 18:19:00 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sT7Ya-0000w0-3A for bug-gnu-emacs@gnu.org; Sun, 14 Jul 2024 18:19:00 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sT7Yb-0003HJ-LW for bug-gnu-emacs@gnu.org; Sun, 14 Jul 2024 18:19:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 14 Jul 2024 22:19:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72013 X-GNU-PR-Package: emacs Original-Received: via spool by 72013-submit@debbugs.gnu.org id=B72013.172099551812564 (code B ref 72013); Sun, 14 Jul 2024 22:19:01 +0000 Original-Received: (at 72013) by debbugs.gnu.org; 14 Jul 2024 22:18:38 +0000 Original-Received: from localhost ([127.0.0.1]:58717 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sT7YD-0003Ga-SQ for submit@debbugs.gnu.org; Sun, 14 Jul 2024 18:18:38 -0400 Original-Received: from mail-oi1-f177.google.com ([209.85.167.177]:52470) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sT7YB-0003GM-P1 for 72013@debbugs.gnu.org; Sun, 14 Jul 2024 18:18:36 -0400 Original-Received: by mail-oi1-f177.google.com with SMTP id 5614622812f47-3da5eab691bso1630377b6e.0 for <72013@debbugs.gnu.org>; Sun, 14 Jul 2024 15:18:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1720995448; x=1721600248; darn=debbugs.gnu.org; h=in-reply-to:references:cc:to:from:content-language:subject :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=G/rVnytJe6GrhcFs/UZOzrpPQiEQfdT4SAkxs8oh9Qg=; b=AS1ChemwdXxhoaGXC2jGHtmEy5JgNhnowPjXoGGgimDdAllhyYE2D02EkJZatKX1ZJ MAXu0P+Tl8hKELyKpQeygAYy37bG1t54Zhy2NtfocwTIlsF4C6rsi/9SUzLOiLgSurAB l8gFTOaoR+0gaU5GkPQb0qrc1otZtPuon1ALRj3X05W9CrSzUSlpnD8l5JA1rCkk5LJh t7KKlIAyGmdWwXyDTSrzMKS/BUzjQylejCSnmX3Wv101CdoknmM1rF911Rhor4r9JCS6 d2CfieCHVsLRUiLkzjNofsTKmc3hkInCcUIt2JV2q9Z5RwMxBmoNkE39mCTPBBgFavYy XTfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720995448; x=1721600248; h=in-reply-to:references:cc:to:from:content-language:subject :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=G/rVnytJe6GrhcFs/UZOzrpPQiEQfdT4SAkxs8oh9Qg=; b=iG668JVwHhv39uzQwgf+Vtij4RjX3athJCNHUOqVj63BAIZX3rAra7kKfKMLHsn6WE SqOF/data/Skq6n3wexrK2wjWjy/OGGbUr/QYllvKFvnylHPSVLPYAy8fRFf2u97JjCz 2Evub/J5gT7RWm9LyPtfxL9TkBoxxlZNHgqAkl+9Um2wb2x0yEs0UrR1Lf8mFQksWkKJ 7TK/bYsHtgCDqzDw9Ry8fWtN506+2wyBMizOj2UH3e/XQznj4hn33obhXgaQ4OXDtxWy BmrrBvgNULOf5yf0cuzXWvpQVn9RuBcF3c7K110tAb2ENIhNj74KMkYozoEOvzleSC5A t9MA== X-Forwarded-Encrypted: i=1; AJvYcCWb+i2fO76luiJzXt9eVHYv8EPSE3uTf2g+kKBkKG3+7d/e2lxWnLJS2Zd9vpe9nbY8CrkWWxM9edPIewUHiG9Gv2Hv7hU= X-Gm-Message-State: AOJu0YxI1QEfzzzygvayx6k/k28ySsgesus2Bs7gpwtrO1pF8RQRIWQs 1q8a/rNclRom9IfT7yqKrTAqmZJJ0ne9Tyay3MgFl4wStK/raZT0 X-Google-Smtp-Source: AGHT+IE4fxHVfNmurxyvaGhCJ7o0HGMZqFkdnjFseY6ai7MFQ/ZuXHCQFmcerIRi/Jvs4aL1zkfFFQ== X-Received: by 2002:a54:4195:0:b0:3da:409f:46d7 with SMTP id 5614622812f47-3da409f4e62mr12340748b6e.30.1720995448432; Sun, 14 Jul 2024 15:17:28 -0700 (PDT) Original-Received: from [192.168.1.2] (syn-023-240-098-037.res.spectrum.com. [23.240.98.37]) by smtp.googlemail.com with ESMTPSA id 41be03b00d2f7-79262e95edbsm497999a12.21.2024.07.14.15.17.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 14 Jul 2024 15:17:27 -0700 (PDT) Content-Language: en-US In-Reply-To: <7d55215c-bd61-3cb4-aab2-177a74fc1d08@gmail.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:288851 Archived-At: This is a multi-part message in MIME format. --------------I5g5KyN78d9rTb5z20Igpxlv Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 7/14/2024 3:14 PM, Jim Porter wrote: > On 7/10/2024 12:33 AM, Michael Albinus via Bug reports for GNU Emacs, > the Swiss army knife of text editors wrote: >> Tramp ought to support signal-process (and interrupt-process). See >> optional argument REMOTE of signal-process. >> >> Best regards, Michael. > > Ok, I figured out why I thought Tramp didn't support 'signal-process'. > Elsewhere in Emacs, you can provide the signal to use like so: > 'SIGKILL'. However, Tramp's 'tramp-signal-process' passes the name > directly to the POSIX "kill" command, which expects the "SIG" to be > removed. Here's a patch which does this. Whoops, we should be case-insensitive about things here. Fixed in the attached patch. --------------I5g5KyN78d9rTb5z20Igpxlv Content-Type: text/plain; charset=UTF-8; name="0001-Support-passing-signals-like-SIGCODE-to-tramp-signal.patch" Content-Disposition: attachment; filename*0="0001-Support-passing-signals-like-SIGCODE-to-tramp-signal.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSBhZTY1ZDFhNWJkMjk2YzE2YWFkZTQyZGVhZTg1ZThhZjI4MDg5ZDMwIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j b20+CkRhdGU6IFN1biwgMTQgSnVsIDIwMjQgMTU6MDc6MjggLTA3MDAKU3ViamVjdDogW1BB VENIXSBTdXBwb3J0IHBhc3Npbmcgc2lnbmFscyBsaWtlICdTSUdDT0RFJyB0bwogJ3RyYW1w LXNpZ25hbC1wcm9jZXNzJwoKUE9TSVggc3BlY2lmaWVzIHRoYXQgImtpbGwiIHNob3VsZCB0 YWtlIHNpZ25hbCBuYW1lcyB3aXRob3V0IHRoZSAiU0lHIgpwcmVmaXguCgoqIGxpc3AvbmV0 L3RyYW1wLmVsICh0cmFtcC1zaWduYWwtcHJvY2Vzcyk6IFN0cmlwIHRoZSAiU0lHIiBwcmVm aXggd2hlbgpwcmVzZW50LgotLS0KIGxpc3AvbmV0L3RyYW1wLmVsIHwgOSArKysrKysrLS0K IDEgZmlsZSBjaGFuZ2VkLCA3IGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCgpkaWZm IC0tZ2l0IGEvbGlzcC9uZXQvdHJhbXAuZWwgYi9saXNwL25ldC90cmFtcC5lbAppbmRleCBl ODMyOWM4Mjc0My4uNWM3MjM2MDExYjggMTAwNjQ0Ci0tLSBhL2xpc3AvbmV0L3RyYW1wLmVs CisrKyBiL2xpc3AvbmV0L3RyYW1wLmVsCkBAIC02OTg2LDggKzY5ODYsMTMgQEAgdHJhbXAt c2lnbmFsLXByb2Nlc3MKICAgICAgIChzZXRxIHBpZCBwcm9jZXNzCiAgICAgICAgICAgICB2 ZWMgKGFuZCAoc3RyaW5ncCByZW1vdGUpICh0cmFtcC1kaXNzZWN0LWZpbGUtbmFtZSByZW1v dGUpKSkpCiAgICAgICh0IChzaWduYWwgJ3dyb25nLXR5cGUtYXJndW1lbnQgKGxpc3QgIydw cm9jZXNzcCBwcm9jZXNzKSkpKQotICAgICh1bmxlc3MgKG9yIChudW1iZXJwIHNpZ2NvZGUp IChzeW1ib2xwIHNpZ2NvZGUpKQotICAgICAgKHNpZ25hbCAnd3JvbmctdHlwZS1hcmd1bWVu dCAobGlzdCAjJ251bWJlcnAgc2lnY29kZSkpKQorICAgIChjb25kCisgICAgICgoc3ltYm9s cCBzaWdjb2RlKQorICAgICAgKHNldHEgc2lnY29kZSAodXBjYXNlIChzeW1ib2wtbmFtZSBz aWdjb2RlKSkpCisgICAgICAod2hlbiAoc3RyaW5nLXByZWZpeC1wICJTSUciIHNpZ2NvZGUp CisgICAgICAgIChzZXRxIHNpZ2NvZGUgKHN1YnN0cmluZyBzaWdjb2RlIDMpKSkpCisgICAg ICgobm90IChudW1iZXJwIHNpZ2NvZGUpKQorICAgICAgKHNpZ25hbCAnd3JvbmctdHlwZS1h cmd1bWVudCAobGlzdCAjJ251bWJlcnAgc2lnY29kZSkpKSkKICAgICA7OyBJZiBpdCdzIGEg VHJhbXAgcHJvY2Vzcywgc2VuZCBTSUdDT0RFIHJlbW90ZWx5LgogICAgICh3aGVuIChhbmQg cGlkIHZlYykKICAgICAgICh0cmFtcC1tZXNzYWdlCi0tIAoyLjI1LjEKCg== --------------I5g5KyN78d9rTb5z20Igpxlv--