From: Drew Adams <drew.adams@oracle.com>
To: Tino Calancha <tino.calancha@gmail.com>
Cc: Juri Linkov <juri@linkov.net>,
30285@debbugs.gnu.org, jidanni@jidanni.org
Subject: bug#30285: dired-do-chmod vs. top line of dired
Date: Mon, 5 Feb 2018 08:45:21 -0800 (PST) [thread overview]
Message-ID: <62b07a53-d019-4909-9d67-b8ce211b2150@default> (raw)
In-Reply-To: <alpine.DEB.2.20.1802050808350.18633@calancha-pc>
> >> I would like all `dired-do...' commands behave the same under the
> >> 'X condition': * called from the top line ** no marked files.
> >
> > I've already said that it's not only about the top line.
> > It's about the ordinary Dired situation of not being on a
> > file line. Plenty of Dired code already deals (simply)
> > with this "X condition".
>
> Sorry for the confussion: I thought it was prety obvious
> that 'X condition' was akind of summary of what the patch
> was doing.
I don't think there was any confusion there. It was clear
what you meant by "X condition". You said it meant:
"* called from the top line [and] ** no marked files"
My point was that Dired code already deals, in various
places, with the condition of not being on a file line
and no files being marked. That condition is easy to
deal with.
And I think that's the only problem that this bug
report needs to fix - in the case of the commands,
like `dired-do-chmod', that don't yet deal with it.
> It would be as easy as to read my commit message to realize that; or
> take
> a quick look in the diff I provided (dont need even to test it). Then,
> you would be talking about my work, not about what you guess it
> is my work. For the future, please try to at least read my commit
> messages before make lot of observations about one patch that you didn't
> even read at all. Thanks! :-)
I guess you are angry or frustrated. Sorry if I caused that.
I had already said, a day or two earlier in reply to your
request that I provide an alternative patch, that I'm OK
with whatever you decide. I offered suggestions about this
bug, and I made clear that it's up to you and I wouldn't be
getting into the implementation details:
> May I ask you to provide an alternative patch to compare
> with mine? Then, people here might do further feedback
> based on those 2 alternatives.
Sorry; I don't have time to work on this. I've already
provided my suggestions - hope they help. Whatever you
decide is fine by me. Thx.
I consider this bug to be trivial, and I hope for a simple
fix that doesn't complicate Dired generally. But whatever
fix you provide is OK by me.
Sorry if my suggestions made you feel like I was discounting
your efforts. I too have already spent more time on this
bug than I can afford to. Please fix this bug as you see
best. And thanks for your work on Dired and other Emacs
features.
next prev parent reply other threads:[~2018-02-05 16:45 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-29 12:32 bug#30285: dired-do-chmod vs. top line of dired 積丹尼 Dan Jacobson
2018-01-29 15:14 ` Tino Calancha
2018-01-29 16:05 ` Eli Zaretskii
2018-01-29 23:21 ` Tino Calancha
2018-01-29 23:42 ` Drew Adams
2018-01-30 3:53 ` Tino Calancha
2018-01-30 4:43 ` Drew Adams
2018-01-30 15:15 ` Drew Adams
2018-01-31 9:49 ` Tino Calancha
2018-01-31 19:04 ` Drew Adams
2018-01-31 21:35 ` Juri Linkov
2018-01-31 23:20 ` Drew Adams
2018-02-01 8:16 ` Tino Calancha
2018-02-01 9:17 ` Tino Calancha
2018-02-01 16:10 ` Drew Adams
2018-02-04 23:12 ` Tino Calancha
2018-02-05 16:45 ` Drew Adams [this message]
2018-02-01 20:07 ` Juri Linkov
2018-02-01 20:50 ` Drew Adams
2018-02-01 21:35 ` Juri Linkov
2018-02-01 22:23 ` Drew Adams
2018-02-03 22:23 ` Juri Linkov
2018-02-04 10:02 ` martin rudalics
2018-02-04 21:44 ` Juri Linkov
2018-02-06 21:32 ` Juri Linkov
2018-02-04 23:08 ` Tino Calancha
2018-02-05 21:01 ` Juri Linkov
2018-02-05 21:52 ` Drew Adams
2018-01-29 15:24 ` 積丹尼 Dan Jacobson
2018-01-29 23:14 ` Tino Calancha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=62b07a53-d019-4909-9d67-b8ce211b2150@default \
--to=drew.adams@oracle.com \
--cc=30285@debbugs.gnu.org \
--cc=jidanni@jidanni.org \
--cc=juri@linkov.net \
--cc=tino.calancha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).