From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#36644: Git log search Date: Wed, 24 Jul 2019 18:10:35 +0300 Message-ID: <62a4fa22-d4f5-5cd4-69b7-7ae1c70e68bc@yandex.ru> References: <874l3p4lks.fsf@mail.linkov.net> <87blxvj5lv.fsf@mail.linkov.net> <23ad9090-ebfc-4307-b41f-30f7c310d978@yandex.ru> <87tvbliw37.fsf@mail.linkov.net> <1251461563472968@myt6-1dca55ddeee8.qloud-c.yandex.net> <87lfwvrpur.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="22243"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 Cc: Robert Pluim , "36644@debbugs.gnu.org" <36644@debbugs.gnu.org> To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jul 24 17:11:17 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hqIvD-0005cz-BW for geb-bug-gnu-emacs@m.gmane.org; Wed, 24 Jul 2019 17:11:15 +0200 Original-Received: from localhost ([::1]:52486 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hqIvC-0002mG-7s for geb-bug-gnu-emacs@m.gmane.org; Wed, 24 Jul 2019 11:11:14 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41772) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hqIv8-0002lv-NE for bug-gnu-emacs@gnu.org; Wed, 24 Jul 2019 11:11:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hqIv2-0004YZ-Vq for bug-gnu-emacs@gnu.org; Wed, 24 Jul 2019 11:11:10 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:57291) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hqIv0-0004WF-6j for bug-gnu-emacs@gnu.org; Wed, 24 Jul 2019 11:11:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hqIv0-0008OH-06 for bug-gnu-emacs@gnu.org; Wed, 24 Jul 2019 11:11:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 24 Jul 2019 15:11:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36644 X-GNU-PR-Package: emacs Original-Received: via spool by 36644-submit@debbugs.gnu.org id=B36644.156398104632224 (code B ref 36644); Wed, 24 Jul 2019 15:11:01 +0000 Original-Received: (at 36644) by debbugs.gnu.org; 24 Jul 2019 15:10:46 +0000 Original-Received: from localhost ([127.0.0.1]:37878 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hqIuk-0008Ne-G4 for submit@debbugs.gnu.org; Wed, 24 Jul 2019 11:10:46 -0400 Original-Received: from mail-wr1-f44.google.com ([209.85.221.44]:41017) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hqIuh-0008NL-VV for 36644@debbugs.gnu.org; Wed, 24 Jul 2019 11:10:44 -0400 Original-Received: by mail-wr1-f44.google.com with SMTP id c2so44183955wrm.8 for <36644@debbugs.gnu.org>; Wed, 24 Jul 2019 08:10:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=VelJaHnyixbKQvwid4JMU+IyQJbbhTUtYAg70qDF3pI=; b=NspPGfw/9HPQ2OMZTLSpjK24c5gObiYn1U6SXi4VSHMnuVMF+02fqyrmYdKWLX/2xy 9fzfPc3a1CCiyxEHzYHVwHwT7JCq6jpAPtvaPn2C0dXsxpFx0T7DqQCoCE9eTXmnaC/M uUOKe06ugj9idfT4V2WnYW/RG94FzwV6zqIyp6WMMfg2G4CzWJrxcUf2KI+gAMovuNcz pZ2zTONHedO59HQ6CakEqJqonoHutfbEWKISsW4e7HHVrYUuB2/Y23Bs5X7ig9HoAfbt fQ4XKtZZ8QP7fftzsBPG4+tY/lTXl+IRsCCjEGgP+vvVbvxng2xYgPrpUSw7Y0fVMScM GwnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=VelJaHnyixbKQvwid4JMU+IyQJbbhTUtYAg70qDF3pI=; b=eG6jjZbBCiYwrXEiqLvSlrf7Fy+kblJRSUrf+MORk6+f4cWhphZ3H8iz5kgv/WGhoX v5cJC8GvG7ohEPO7Q6CMoFU8nrRkNNKzn2FhIfa+57LKjoLDz7nQespVE45rxTeXQw7b IgwYqTMDy/h0Cv2iW4Msg6goLQBC0C+cMS1iMkIzpKzck3kyafzDk6tsoOEv9p7nhzgh CrUsG+4d8xaAeuGzmsQ2RQFC4XXSAgp5LtEv/JH4SEu2QC50oX498EH52ybBE90VS5Mf jCwPhSY0LRinAMpoi1GD5sdRXvyEAszhRnFmp8hHUH1NAEwN9kMOcm7+uIkgBs9olpqN fYlg== X-Gm-Message-State: APjAAAWUJhaQVryke6cb6Ay2ZhF5n7Ecs0hj1Qq1RmauEHODADHzn+X3 BpEbrTRZWtqAwSjkvf1D5T9CeVV8h8t6cA== X-Google-Smtp-Source: APXvYqyFbYdW3T8ga95ps1vTNko8bhQl/djA8Crw+ve4MpbyzGZSc7iAJWj8gAYuhZowZtJTyJm8Xg== X-Received: by 2002:a5d:6389:: with SMTP id p9mr61314947wru.297.1563981037917; Wed, 24 Jul 2019 08:10:37 -0700 (PDT) Original-Received: from [192.168.0.195] ([109.110.245.170]) by smtp.googlemail.com with ESMTPSA id r15sm48822325wrj.68.2019.07.24.08.10.36 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 24 Jul 2019 08:10:36 -0700 (PDT) In-Reply-To: <87lfwvrpur.fsf@mail.linkov.net> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:163668 Archived-At: On 19.07.2019 1:32, Juri Linkov wrote: >> We can't really use this approach. VC is a high level abstraction, >> so we try to define the semantics well. > > I tend to agree with Robert. A string have to be passed to the backend as is. > It seems such situations when these strings should be compatible between > different backends (such as running the same command on one backend, > and then repeating the same search on another backend by retrieving > a previous argument from the history via M-p) are very rare. I might agree with you from the practical standpoint, but vc-log-search needs a docstring that actually describes what the function is going to do. Including info on how PATTERN is going to be interpreted. E.g. whether "foo.txt" will only match literally, or whether "." can be substituted by any character. And if PATTERN is a regexp, what kind of regexp it's going to be interepreted as: basic RE, extended RE, Emacs RE, or Perl RE (probably not the last one anyway). I suppose we can choose one of these and say e.g. that pattern is interpreted as an extended regular expression, except for some backends that don't support that. I wonder how we're going to convey the latter to the user.