From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#18090: 24.4.50; `delete-selection-helper' logic changed for non-mouse region? Date: Sun, 23 Sep 2018 18:35:03 -0700 (PDT) Message-ID: <626fca93-0fba-4dd7-b119-7187b818dccb@default> References: <95e066b9-792c-4b38-8f4b-fd225578ed45@default> <9859e098-daf7-4b67-a8a6-c53d01a18f93@default> <83fty4elsx.fsf@gnu.org> <87pnx8xckg.fsf@mail.linkov.net> <874leju83n.fsf@mail.linkov.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1537752846 29024 195.159.176.226 (24 Sep 2018 01:34:06 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 24 Sep 2018 01:34:06 +0000 (UTC) Cc: 18090@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Sep 24 03:34:02 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g4FlB-0007QD-Bl for geb-bug-gnu-emacs@m.gmane.org; Mon, 24 Sep 2018 03:34:01 +0200 Original-Received: from localhost ([::1]:43160 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g4FnI-00070X-1I for geb-bug-gnu-emacs@m.gmane.org; Sun, 23 Sep 2018 21:36:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:32917) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g4FnB-00070F-Ly for bug-gnu-emacs@gnu.org; Sun, 23 Sep 2018 21:36:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g4Fn8-0008TH-Em for bug-gnu-emacs@gnu.org; Sun, 23 Sep 2018 21:36:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:46961) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1g4Fn8-0008Sq-AQ for bug-gnu-emacs@gnu.org; Sun, 23 Sep 2018 21:36:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1g4Fn8-0008FA-4L for bug-gnu-emacs@gnu.org; Sun, 23 Sep 2018 21:36:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 24 Sep 2018 01:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18090 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 18090-submit@debbugs.gnu.org id=B18090.153775291331630 (code B ref 18090); Mon, 24 Sep 2018 01:36:02 +0000 Original-Received: (at 18090) by debbugs.gnu.org; 24 Sep 2018 01:35:13 +0000 Original-Received: from localhost ([127.0.0.1]:51219 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g4FmL-0008E6-Gr for submit@debbugs.gnu.org; Sun, 23 Sep 2018 21:35:13 -0400 Original-Received: from userp2120.oracle.com ([156.151.31.85]:60700) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g4FmJ-0008Dq-Oh for 18090@debbugs.gnu.org; Sun, 23 Sep 2018 21:35:12 -0400 Original-Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w8O1Z6iQ075590; Mon, 24 Sep 2018 01:35:06 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2018-07-02; bh=kuL9qj9VZv0x4DklRSRqeWIaEI8uQ8LgSG5eMKpSimk=; b=IgsgCx/aY90jUl/5laJg0rWk0T8S3gyPFawnJAZQ/r02FVLGyaHlh8i6raUJZfFQRUWB zk3w9qCU60TBZkiSbdjThdgJmqgHd6lA0eaGYK/itbamhE2fWTNl1pqN34HhkK1ljLPE B7Kf2C6ynfQmgXFr+z4dixDgXmaN/onXnzX32B9TT70oGqFDVY0PMX6MsX4JfjaiVCl/ UGj3cKOd7b3dDS8ICmAHpMICOD08fso4T0NMbhBkemHiyq0zRtN5Sije2CKUNoQQp9eD Pq5dcki+APuiR89XEGpw12YsznduRPk5r48n92hWejLp13Oldx37DL8MQ4WZIpMIMhda ng== Original-Received: from aserv0021.oracle.com (aserv0021.oracle.com [141.146.126.233]) by userp2120.oracle.com with ESMTP id 2mnvtu9vym-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 24 Sep 2018 01:35:05 +0000 Original-Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by aserv0021.oracle.com (8.14.4/8.14.4) with ESMTP id w8O1Z4MN005490 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 24 Sep 2018 01:35:04 GMT Original-Received: from abhmp0003.oracle.com (abhmp0003.oracle.com [141.146.116.9]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id w8O1Z3vH009349; Mon, 24 Sep 2018 01:35:04 GMT In-Reply-To: <874leju83n.fsf@mail.linkov.net> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4735.0 (x86)] X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9025 signatures=668707 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1807170000 definitions=main-1809240015 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:150582 Archived-At: > You are missing the part above. I wasn't missing it. I was trying to point out that that code has nothing to do with mouse yanking. As you say, mouse-yank commands are not supported by `delete-selection-mode' - they do not have a `yank' `delete-selection-mode' property value. That code, which you say could be deleted altogether, is essential for `delete-selection-mode' to handle `yank'. Don't you agree? That was my point. The code in question is about commands whose property value is `yank'. Do you agree? If not, why do you think all of that code could be deleted? --- Anyway, I think I understand why you added the `mouse-region-match' condition now. But it seems to me that that condition should be used, as Eli hinted, only when `mouse-drag-copy-region' is non-nil. (It is nil by default now.) Do you agree? Isn't that the (only) case where you are bothered by the mouse selection being replaced by the previous kill-ring entry (instead of the implicit one from the mouse selection)? IOW, do you think this addition makes sense? (when (and (string=3D (buffer-substring-no-properties (point) (mark)) (car kill-ring)) =09 mouse-drag-copy-region ; <=3D=3D=3D=3D=3D=3D (fboundp 'mouse-region-match) (mouse-region-match)) (current-kill 1))