From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#14797: 24.3.50; new, undocumented menu structure using VECTORS? Date: Sat, 6 Aug 2016 09:15:07 -0700 (PDT) Message-ID: <626ccb70-e9fa-4954-a6e0-7d8be3d51ca3@default> References: <<6b4ca396-4d2b-4719-8b1e-1ef9eb6f5610@default> > <<87d1lm6o2p.fsf@users.sourceforge.net>> <<83k2fuj6vp.fsf@gnu.org>> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1470500187 26061 195.159.176.226 (6 Aug 2016 16:16:27 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 6 Aug 2016 16:16:27 +0000 (UTC) Cc: monnier@iro.umontreal.ca, 14797@debbugs.gnu.org To: Eli Zaretskii , npostavs@users.sourceforge.net Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Aug 06 18:16:23 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bW4Gn-000511-7a for geb-bug-gnu-emacs@m.gmane.org; Sat, 06 Aug 2016 18:16:17 +0200 Original-Received: from localhost ([::1]:49950 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bW4Gj-000155-VN for geb-bug-gnu-emacs@m.gmane.org; Sat, 06 Aug 2016 12:16:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34725) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bW4Gd-00014W-Dw for bug-gnu-emacs@gnu.org; Sat, 06 Aug 2016 12:16:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bW4GY-0000Pv-BH for bug-gnu-emacs@gnu.org; Sat, 06 Aug 2016 12:16:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:60797) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bW4GY-0000Pr-7y for bug-gnu-emacs@gnu.org; Sat, 06 Aug 2016 12:16:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bW4GX-000263-V1 for bug-gnu-emacs@gnu.org; Sat, 06 Aug 2016 12:16:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 06 Aug 2016 16:16:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14797 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 14797-submit@debbugs.gnu.org id=B14797.14705001198000 (code B ref 14797); Sat, 06 Aug 2016 16:16:01 +0000 Original-Received: (at 14797) by debbugs.gnu.org; 6 Aug 2016 16:15:19 +0000 Original-Received: from localhost ([127.0.0.1]:58094 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bW4Fr-00024x-2E for submit@debbugs.gnu.org; Sat, 06 Aug 2016 12:15:19 -0400 Original-Received: from aserp1040.oracle.com ([141.146.126.69]:26381) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bW4Fp-00024k-0K for 14797@debbugs.gnu.org; Sat, 06 Aug 2016 12:15:17 -0400 Original-Received: from userv0021.oracle.com (userv0021.oracle.com [156.151.31.71]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id u76GF9NO020862 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sat, 6 Aug 2016 16:15:10 GMT Original-Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by userv0021.oracle.com (8.13.8/8.13.8) with ESMTP id u76GF95J011728 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sat, 6 Aug 2016 16:15:09 GMT Original-Received: from abhmp0014.oracle.com (abhmp0014.oracle.com [141.146.116.20]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id u76GF7S2024567; Sat, 6 Aug 2016 16:15:07 GMT In-Reply-To: <<83k2fuj6vp.fsf@gnu.org>> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9 (901082) [OL 12.0.6744.5000 (x86)] X-Source-IP: userv0021.oracle.com [156.151.31.71] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:121906 Archived-At: > > +@item @var{vector} > > +This kind of element is similar to a char-table: element @var{n} is > > +the binding for the character with code @var{n}. Since the range of > > +characters that can be bound this way is limited by the vector size, > > +and vector creation allocates space for all character codes from 0 up, > > +this format should not be used except for creating menu keymaps > > +(@pxref{Menu Keymaps}), where the bindings themselves don't matter. > > + > > @item @var{string} > > @cindex keymap prompt string > > @cindex overall prompt string >=20 > LGTM, except that "the character with code N" could use some better > wording. How about > ... element whose index is @var{c} is the binding for the character > @var{c}. > instead? Both look OK to me. And adding such doc is a definite improvement. It's not very clear to me from this doc what the relation is between a key binding and a "binding for the character". Keys and characters are different animals. Clearly there is a relation between them here, but it doesn't seem to be made explicit. But again, unless you want to try to clarify that, the proposed doc is OK, and adding it improves things.