unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Drew Adams <drew.adams@oracle.com>
To: Eli Zaretskii <eliz@gnu.org>, npostavs@users.sourceforge.net
Cc: monnier@iro.umontreal.ca, 14797@debbugs.gnu.org
Subject: bug#14797: 24.3.50; new, undocumented menu structure using VECTORS?
Date: Sat, 6 Aug 2016 09:15:07 -0700 (PDT)	[thread overview]
Message-ID: <626ccb70-e9fa-4954-a6e0-7d8be3d51ca3@default> (raw)
In-Reply-To: <<83k2fuj6vp.fsf@gnu.org>>

> > +@item @var{vector}
> > +This kind of element is similar to a char-table: element @var{n} is
> > +the binding for the character with code @var{n}.  Since the range of
> > +characters that can be bound this way is limited by the vector size,
> > +and vector creation allocates space for all character codes from 0 up,
> > +this format should not be used except for creating menu keymaps
> > +(@pxref{Menu Keymaps}), where the bindings themselves don't matter.
> > +
> >  @item @var{string}
> >  @cindex keymap prompt string
> >  @cindex overall prompt string
> 
> LGTM, except that "the character with code N" could use some better
> wording.  How about
>   ... element whose index is @var{c} is the binding for the character
>   @var{c}.
> instead?

Both look OK to me.  And adding such doc is a definite
improvement.

It's not very clear to me from this doc what the relation
is between a key binding and a "binding for the character".
Keys and characters are different animals.  Clearly there
is a relation between them here, but it doesn't seem to
be made explicit.

But again, unless you want to try to clarify that, the
proposed doc is OK, and adding it improves things.





  parent reply	other threads:[~2016-08-06 16:15 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-04 23:54 bug#14797: 24.3.50; new, undocumented menu structure using VECTORS? Drew Adams
2013-07-05 10:42 ` Stefan Monnier
2013-07-05 15:17   ` Drew Adams
2013-07-05 22:45     ` Stefan Monnier
2013-07-06  1:40       ` Drew Adams
2013-10-19 17:48     ` Drew Adams
2016-08-06 13:09     ` npostavs
2016-08-06 14:42       ` Eli Zaretskii
2016-08-06 15:42         ` Noam Postavsky
2016-08-06 17:36           ` Eli Zaretskii
2016-08-06 19:53             ` npostavs
     [not found]     ` <<87d1lm6o2p.fsf@users.sourceforge.net>
     [not found]       ` <<83k2fuj6vp.fsf@gnu.org>
2016-08-06 16:15         ` Drew Adams [this message]
2016-08-06 16:35           ` npostavs
2016-08-06 16:52             ` Drew Adams
2016-08-06 17:40             ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=626ccb70-e9fa-4954-a6e0-7d8be3d51ca3@default \
    --to=drew.adams@oracle.com \
    --cc=14797@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    --cc=npostavs@users.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).