From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.bugs Subject: bug#75192: [PATCH] Update fontification for attribute values in heex-ts-mode Date: Thu, 2 Jan 2025 21:49:32 -0800 Message-ID: <62396379-9915-49AD-8C2D-0CAF8ED4F063@gmail.com> References: <86zfk9k3xr.fsf@gnu.org> <86ttahk2j2.fsf@gnu.org> <86o70pjl16.fsf@gnu.org> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3776.700.51\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31329"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Wilhelm Kirschbaum , 75192@debbugs.gnu.org, stefankangas@gmail.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jan 03 06:50:39 2025 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tTaZy-0007zW-D5 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 03 Jan 2025 06:50:38 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tTaZV-0002nS-PT; Fri, 03 Jan 2025 00:50:09 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tTaZQ-0002n5-LY for bug-gnu-emacs@gnu.org; Fri, 03 Jan 2025 00:50:04 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tTaZQ-0006bY-D7 for bug-gnu-emacs@gnu.org; Fri, 03 Jan 2025 00:50:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=References:Date:In-Reply-To:From:Mime-Version:To:Subject; bh=A9Db1+KYqBS2V+XHIK6l+8Dtlw5XN/VFqvOTtVUCtjw=; b=URcmqJVEYalk9AF/qnewxwzkfBo8osuJrtB3y3vC2s/tE8H/SDRLaxz0SMNzE/SFYRD7BaeQNU9ROXKdyiS7nuGQXQWTA5zRvEHUdcz9k9rdwuR7JXTFjZc+EvJvMJS7z683clGkaYxmUz4Vqv1jOo00pXuf84DqRe6LOFlYEHgwwf7zAGpiFLWTh/7Y3ehUOUuAmo7JQBRRE0sb9MEnhV9aOVZ+IH1MJxNPgzzzVRYjI6HVjq/gMR3j3bgmKYl79YbiJJ0cM84Y7XvwZ6u4s+2JgU79u2OH9SthPwTmEeANxU0K6H4HgFPotI1A5xJc4KusRQTN+xIYaXcRSO2e/A==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tTaZO-0001Q6-Cj for bug-gnu-emacs@gnu.org; Fri, 03 Jan 2025 00:50:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Yuan Fu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 03 Jan 2025 05:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 75192 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 75192-submit@debbugs.gnu.org id=B75192.17358833975440 (code B ref 75192); Fri, 03 Jan 2025 05:50:02 +0000 Original-Received: (at 75192) by debbugs.gnu.org; 3 Jan 2025 05:49:57 +0000 Original-Received: from localhost ([127.0.0.1]:49182 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tTaZI-0001Pg-UV for submit@debbugs.gnu.org; Fri, 03 Jan 2025 00:49:57 -0500 Original-Received: from mail-pj1-x102c.google.com ([2607:f8b0:4864:20::102c]:58617) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tTaZC-0001PM-JZ for 75192@debbugs.gnu.org; Fri, 03 Jan 2025 00:49:55 -0500 Original-Received: by mail-pj1-x102c.google.com with SMTP id 98e67ed59e1d1-2ee67e9287fso16788212a91.0 for <75192@debbugs.gnu.org>; Thu, 02 Jan 2025 21:49:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1735883384; x=1736488184; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=A9Db1+KYqBS2V+XHIK6l+8Dtlw5XN/VFqvOTtVUCtjw=; b=V8Asd22ywc2yOZvfy1REr2EuSDGA5JYwsaoTb7LisvYAv9vxXdaI9vWpuCW9Stkkfe e3FjfP9Dkb7t5Rb/BUws/QQqJa/kI1DXtfrl/YshbXkz4aF8jEbj14yngGXn/UBGrsfL M6H2acfsIyVF+Sl58pdUIHs0tba0s4T/ZVs88dDY49L05AHYjiP3dImMUsycuUhacqO6 UuNIbkiaBRbB435nFqy5MUjrD9l31zgwJG+JIC3egCaDMXZgvFsJ8b0npuzTXypyeV9N nGtLonZJmmpCiAmFgmeFuRvFFzB7YI35Qo992zEU7V89uXqbW1WozsuIKd1KSw/q3NYX mUfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735883384; x=1736488184; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=A9Db1+KYqBS2V+XHIK6l+8Dtlw5XN/VFqvOTtVUCtjw=; b=D38xM/GnCOHdBYicbd8sEZFVzgpU8/IDi6+9l4KIMBALzxpARNuK+1GO0i7w+W1601 zImlAe5/XgLyQWM6YlSiJJssCpJb3QVrPTYgTgBU/EjSbvgRkuLzWvryt+HykZccgKqe 2o0AhSvNAJOsXej3oSRcjoCMtwLVaDxSTnf1RMaL2hkjvQ96Ps9C2t+6uQHrCPp/UuDT DLEQPpQy7NTRNMtHsDiCWCG//3CgJPUDCZyDmYptJCoKLKjD2NxIfUdj6AEEJ4GUbQ0h 0V8p93B0JJeqV4trGjaB9zefbHgc2Uzbq15oiGWCzZLaeG+0G/9faXkwxHskHc7mm8pP Ut/A== X-Forwarded-Encrypted: i=1; AJvYcCXHL5hymKBwcDWXwUESw9Yp0jG2xz+MYKeVmLRwjcs3M1FB1fsVKiPBIG0Oa0dyJetLQs38Tw==@debbugs.gnu.org X-Gm-Message-State: AOJu0YzhWfwlaiZa5rggeGSj9SP5XEunTXNFntAdKlkO6VfwpUDO0kJc Md4N+etS5I1ypTGpYxu+Z5XrNKzGFmDB1o+V7hRCnm0LH1e3EajL X-Gm-Gg: ASbGnctnyfo3WwtEAwTNrJxIB0EHpY5TU9nJJVcGGqVfAGjczEgiLN1KPwIyYQ4QbXi KHO+ahkERYybPsmWClac8ECVqK5chRM/9QdIXzz3cxV/Q6pmb+QIHIbZy8DZTDnnOYGB2qzTyZh vW7O9Z9MGuxlZVKt34mCU0L2RDtp52DPsXF6F7Ro+ak10gGHN9QzSYS7HM/u0zyV9ZZN/SFl01W E38ZDQyAe9rYF+xaQ6L0cZ8ExHx/MHFCP7mepQV0J5H6TxW92c8o/4ORVWP/RBFhbcjShiTEhTt ftvb X-Google-Smtp-Source: AGHT+IHo7JqEabARAFIgq7PQj2CepqSe8JlmQrWZRIiwedmthQhIrau7CaRPJ8HWIc7vGw4CWl8DHg== X-Received: by 2002:a05:6a00:f96:b0:724:ed8f:4d35 with SMTP id d2e1a72fcca58-72abdedda5fmr71315009b3a.26.1735883384283; Thu, 02 Jan 2025 21:49:44 -0800 (PST) Original-Received: from smtpclient.apple ([2601:646:8f81:6120:85eb:71bd:58ac:56a8]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-72aad815796sm26213005b3a.28.2025.01.02.21.49.43 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 02 Jan 2025 21:49:43 -0800 (PST) In-Reply-To: <86o70pjl16.fsf@gnu.org> X-Mailer: Apple Mail (2.3776.700.51) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:298250 Archived-At: > On Jan 2, 2025, at 7:24=E2=80=AFAM, Eli Zaretskii = wrote: >=20 >> From: Wilhelm Kirschbaum >> Date: Thu, 2 Jan 2025 12:13:27 +0200 >> Cc: Stefan Kangas , 75192@debbugs.gnu.org, = casouri@gmail.com >>=20 >>>> attribute be highlighted as a string? >>>=20 >>> I'm not familiar with HEEx and can't share a useful opinion, but = FWIW, I >>> simply noted that the code directly above the change said >>>=20 >>> :feature 'heex-string >>>=20 >>> which is why I assumed that using a string face should make sense. >>=20 >> So we think that the current face is just a typo? >>=20 >> Originally I was not sure what would be more appropriate, but got a = comment from a user and saw >> html-ts-mode uses string so thought it would be good to change before = it gets released. >=20 > OK, then I think installing this on emacs-30 is TRT. Agree.