From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.bugs Subject: bug#45502: [PATCH] Prettier key bindings in NS menu entries Date: Wed, 30 Dec 2020 14:12:32 +0100 Message-ID: <62263FDE-74E8-4531-9F30-940F60EB1477@acm.org> References: <02937096-EAF5-4B74-A1C7-CCE6E64C67E3@acm.org> <99CD03DA-DF1F-4C2C-A2FA-DFD7DF3B2750@acm.org> <0F1B9914-2668-4775-822A-49A36D4A9F3F@acm.org> Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.17\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40644"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 45502@debbugs.gnu.org, Daniel =?UTF-8?Q?Mart=C3=ADn?= To: Alan Third Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Dec 30 14:13:12 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kubHr-000ATW-Pi for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 30 Dec 2020 14:13:11 +0100 Original-Received: from localhost ([::1]:47034 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kubHq-00080r-7C for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 30 Dec 2020 08:13:10 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37748) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kubHi-00080W-Qi for bug-gnu-emacs@gnu.org; Wed, 30 Dec 2020 08:13:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58821) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kubHi-00082x-JZ for bug-gnu-emacs@gnu.org; Wed, 30 Dec 2020 08:13:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kubHi-0004Lx-FE for bug-gnu-emacs@gnu.org; Wed, 30 Dec 2020 08:13:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 30 Dec 2020 13:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45502 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 45502-submit@debbugs.gnu.org id=B45502.160933396616711 (code B ref 45502); Wed, 30 Dec 2020 13:13:02 +0000 Original-Received: (at 45502) by debbugs.gnu.org; 30 Dec 2020 13:12:46 +0000 Original-Received: from localhost ([127.0.0.1]:42134 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kubHP-0004LR-39 for submit@debbugs.gnu.org; Wed, 30 Dec 2020 08:12:46 -0500 Original-Received: from mail18c50.megamailservers.eu ([91.136.10.28]:52768) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kubHJ-0004LD-Sa for 45502@debbugs.gnu.org; Wed, 30 Dec 2020 08:12:41 -0500 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1609333955; bh=98/MGcEbraso0ZC8zpzB6SCKJV+Fx4jy1mK1di/q0RM=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=kuBcLDb3T7admQFnMWwGwnvHewKeSb+vpRAMrZZ/PDAC8d52KNHFWGF5Y5sIx+YMZ yxqFJgzx9834DRdqlVJYx1RwmrPZUsAP5BIxwuyriFXrZbh+YOjxddsV1RnEN6+CsS 6xA3KtbuXkKMOfJXEgJyeMklJYy9ZDZWqd+16ky8= Feedback-ID: mattiase@acm.or Original-Received: from [192.168.0.4] (c188-150-171-71.bredband.comhem.se [188.150.171.71]) (authenticated bits=0) by mail18c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 0BUDCXbm031698; Wed, 30 Dec 2020 13:12:35 +0000 In-Reply-To: X-Mailer: Apple Mail (2.3445.104.17) X-CTCH-RefID: str=0001.0A742F1A.5FEC7CC3.0058, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=e5N4tph/ c=1 sm=1 tr=0 a=SF+I6pRkHZhrawxbOkkvaA==:117 a=SF+I6pRkHZhrawxbOkkvaA==:17 a=kj9zAlcOel0A:10 a=M51BFTxLslgA:10 a=hIj89exaAAAA:8 a=GaEmlizfvmKoY74UCY4A:9 a=CjuIK1q_8ugA:10 a=lS9wXHQM5UdnNJ4u63Ry:22 X-Origin-Country: SE X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:197027 Archived-At: 30 dec. 2020 kl. 13.46 skrev Alan Third : > It looks good to me, so I see no reason not to apply it and see if > anyone complains. Good, will do. > Oh, I noticed that the Mark menu in dired has the Help menu search > entry. I guess I've missed something somewhere. I wondered if that was > set somewhere but couldn't see any reference to it so assumed macOS > was doing something clever when it saw a "Help" top level submenu... It's on the menu with the same index as Help normally has (because Dired = adds multiple menus to the bar); the same effect can be seen in M-x = shell. Perhaps we manage to confuse the Cocoa automatics somehow? > BTW, this isn't a comment on your code, I'm just curious. I notice you > use C functions within Obj C classes where I would probably have just > created another method. Is that just because they're dealing with C > code exclusively or something else? It's mostly accidental, but it is true that there is a tension between = different styles here -- I find plain functions to be fine for doing the = job of a function (being a functional programmer at heart helps, of = course...) and Objective-C allows it seamlessly. Methods don't bring = much when they don't somehow operate on the object state, and they = require declaration in the .h file even if only used locally (I might be = mistaken here). Thus no religion here; I can do it either way.