From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mauro Aranda Newsgroups: gmane.emacs.bugs Subject: bug#13476: 24.3.50; Reverting scroll-bar face customization has no effect Date: Mon, 28 Feb 2022 08:43:44 -0300 Message-ID: <621cb573.1c69fb81.4f5fd.e05b@mx.google.com> References: <87d2x4oyfv.fsf@rosalinde.fritz.box> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2178"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 13476@debbugs.gnu.org, stephen.berman@gmx.net To: Po Lu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Feb 28 12:53:14 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nOeaX-0000OV-Fv for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 28 Feb 2022 12:53:13 +0100 Original-Received: from localhost ([::1]:58554 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nOeaW-00049Z-IZ for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 28 Feb 2022 06:53:12 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:59954) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nOeRe-0008DE-TI for bug-gnu-emacs@gnu.org; Mon, 28 Feb 2022 06:44:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38171) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nOeRe-0003MA-Kh for bug-gnu-emacs@gnu.org; Mon, 28 Feb 2022 06:44:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nOeRe-0000jA-EJ for bug-gnu-emacs@gnu.org; Mon, 28 Feb 2022 06:44:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Mauro Aranda Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 28 Feb 2022 11:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13476 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 13476-submit@debbugs.gnu.org id=B13476.16460486362777 (code B ref 13476); Mon, 28 Feb 2022 11:44:02 +0000 Original-Received: (at 13476) by debbugs.gnu.org; 28 Feb 2022 11:43:56 +0000 Original-Received: from localhost ([127.0.0.1]:60301 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nOeRX-0000ij-LY for submit@debbugs.gnu.org; Mon, 28 Feb 2022 06:43:55 -0500 Original-Received: from mail-oo1-f44.google.com ([209.85.161.44]:41904) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nOeRW-0000iW-3I for 13476@debbugs.gnu.org; Mon, 28 Feb 2022 06:43:54 -0500 Original-Received: by mail-oo1-f44.google.com with SMTP id d134-20020a4a528c000000b00319244f4b04so18453419oob.8 for <13476@debbugs.gnu.org>; Mon, 28 Feb 2022 03:43:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:from:to:cc:subject:in-reply-to:date:mime-version; bh=QpxFdcGKBw6OFKqjJZjpaNb7ur3Jz/vAcV1dDR3lYUA=; b=HxT858iasgkGDWz61VUzG4jkmw1cr53yWh+uhwBcsZS/FdVfbfR8vnmW9sYkrU99GI n2d+l5AxYJXEkvu2C/pDoyfbqjSFi7rxu/cXCo4f7seSK52evEfB9LGG0S6pRftSB4YK xlXO6DHYEkt0/8SxamZsyEjoAFfhuSEXEGQ80YOZT1TzP+cuml1F+yOicohj0Sib1PNu WqKZnno3ks4zrAqYO17J8QkyxClEWP575KFkD1B6/fiCoPwu1cj/RXp3NDrJGhnABmAm Rz1ZbEDmo4yZ+oIktnZ1O4sRRXoyVgElkS/mRmmniCMGL4bGNtB6poAK4458ViMIeCaD ayHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:from:to:cc:subject:in-reply-to:date :mime-version; bh=QpxFdcGKBw6OFKqjJZjpaNb7ur3Jz/vAcV1dDR3lYUA=; b=fJ4smWUwomHFi2JHiaqOLYWJVVZ6IJsPJJB87ZPDiEFKaRRJk7g/t0XOn5fTDcICoc RIFFl6+8GkGfIkRfika6SZPeabC3p1P9LAFwld4nR/Tb3sBMEivjAqFQBSqovd0NRLY6 jXtWfCRnLwr4NvrxIC97DjZ4NL9NDjBci0M2G9+5gMdlAyS21iS7GebSJAHJmXYeZpNY PogXhH4PUmLUK1lKWzXUvEtAkf1aiNxFdfU0lhXM7DLmghb12GoK743vbRzAIWLevdui optdIN6FeDysi9/IhecovRh7rZx/U3IEQsITlBsVHtAu6wEXK/c3GDczJD/1hJBsI1e1 dmzw== X-Gm-Message-State: AOAM532dMpmPru8Sh831kiDIUJX53X0X3AWkKN2xQeWAp2pUBPfatv6m U5MiTXToFnp201Cw/2EbddQ= X-Google-Smtp-Source: ABdhPJyms/xndKg1I5iAnUBgZ2P3L7XQBEieSYoRwgnDr7Y+KgNZG+YLnoqzm107PXQIAj54rVpelg== X-Received: by 2002:a05:6870:9545:b0:d7:3be1:b83d with SMTP id v5-20020a056870954500b000d73be1b83dmr849344oal.28.1646048628113; Mon, 28 Feb 2022 03:43:48 -0800 (PST) Original-Received: from tbb-desktop ([181.29.189.16]) by smtp.gmail.com with ESMTPSA id j1-20020a4aea41000000b002e140d2d96esm4883630ooe.13.2022.02.28.03.43.46 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 28 Feb 2022 03:43:47 -0800 (PST) X-Google-Original-Message-ID: <874k4jqkr3.fsf@maurooaranda@gmail.com> In-Reply-To: <87bkyr68bf.fsf@yahoo.com> (message from Po Lu on Mon, 28 Feb 2022 10:20:20 +0800) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:227786 Archived-At: [Unarchive the bug before sending a message, so that the message reaches the bug tracker] Po Lu writes: > Mauro Aranda writes: > >> I've tried the attached patch. Now reverting the foreground color >> works, and I haven't seen unintended effects so far. > > I'm afraid that patch doesn't make sense, and causes bad side-effects > with Athena and Motif scroll bars. > > With toolkit scroll bars, the foreground and background colors must be > unspecified by default, so that the toolkit default is used instead. Ok, sorry about that. > So I think the bug lies in Custom (it should reset the value to > "unspecified") and not the declaration of the scroll-bar face. Why do you think it is a bug in Custom? Custom relies on faces.el to update a customized face and to revert to the default/standard. So, with the old spec for scroll-bar: (defface scroll-bar '((t nil)) "Basic face for the scroll bar colors under X.") ;; Make sure the spec is set. (face-spec-set 'scroll-bar '((t (:foreground "green"))) nil) ;; Reset to the standard. (face-spec-set 'scroll-bar nil 'reset) The scroll-bar foreground color stays green in the selected frame. There's no Custom code involved there. And face-spec-reset-face is setting all attributes to unspecified, I thought that was clear from https://debbugs.gnu.org/cgi/bugreport.cgi?bug=13476#8