From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mauro Aranda Newsgroups: gmane.emacs.bugs Subject: bug#54048: 29.0.50; Wrong declaration for some align.el defcustom Date: Thu, 17 Feb 2022 19:43:08 -0300 Message-ID: <620ecf7e.1c69fb81.e7dbe.57f7@mx.google.com> References: <620ece26.1c69fb81.981be.4780@mx.google.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16814"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) To: 54048@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Feb 17 23:44:10 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nKpVR-0004AX-N5 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 17 Feb 2022 23:44:09 +0100 Original-Received: from localhost ([::1]:41886 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nKpVQ-0004Nw-5k for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 17 Feb 2022 17:44:08 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:40560) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nKpVK-0004Nn-2A for bug-gnu-emacs@gnu.org; Thu, 17 Feb 2022 17:44:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:59023) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nKpVJ-0002PW-PH for bug-gnu-emacs@gnu.org; Thu, 17 Feb 2022 17:44:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nKpVJ-00007t-IY for bug-gnu-emacs@gnu.org; Thu, 17 Feb 2022 17:44:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Mauro Aranda Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 17 Feb 2022 22:44:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54048 X-GNU-PR-Package: emacs Original-Received: via spool by 54048-submit@debbugs.gnu.org id=B54048.1645137799428 (code B ref 54048); Thu, 17 Feb 2022 22:44:01 +0000 Original-Received: (at 54048) by debbugs.gnu.org; 17 Feb 2022 22:43:19 +0000 Original-Received: from localhost ([127.0.0.1]:52920 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nKpUd-00006p-2P for submit@debbugs.gnu.org; Thu, 17 Feb 2022 17:43:19 -0500 Original-Received: from mail-oi1-f172.google.com ([209.85.167.172]:36418) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nKpUb-00006c-0f for 54048@debbugs.gnu.org; Thu, 17 Feb 2022 17:43:17 -0500 Original-Received: by mail-oi1-f172.google.com with SMTP id p15so1194366oip.3 for <54048@debbugs.gnu.org>; Thu, 17 Feb 2022 14:43:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:from:to:subject:references:date:in-reply-to:user-agent :mime-version; bh=Gkh72i3Wcvrhwh2hmlSCsphFXYrgSwa9Rapl8f2K/r8=; b=nINxLvjBTPFA7AjaCsAwl8/g8k6xbzWnHvp4B4ds3QIpYaPHwV6goF8iABTp89bsW+ ziPmC169OaOzdHT4S1uXCPey7vRHHhf1KzG/v5FHucnCJxt4n795mablddN4BmeQNfuf DfIrtFBR4mGB5c02mSfIwI2WEewkuHbW0PY56Hm8gf7MUwmx5qj4rk1Bk87UCDapxdR6 9PCz8KSImod/jdMNJeaTay3NWxCKjzc4rRH4q6KMj51Hab2M6S7fxvxIJRTkvu1TjOUm P/9a9BBHvtTPfhk9AEHOKqApYrAFDpx+u6IWY/sVysMDMC4Qolz5nDlk+2uW0zV1CVQV lpKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:from:to:subject:references:date :in-reply-to:user-agent:mime-version; bh=Gkh72i3Wcvrhwh2hmlSCsphFXYrgSwa9Rapl8f2K/r8=; b=iNP31SQC3SO+Aj+hpQIIV6QPS3q4f4NBQUNCrOOvqO1khUuEu6zyiJ7cyEO2tGenpA rqk7ACehPSj6LoM2WAyvHLF1HDW6Py4RN/nvrlelGOtpjkNO9T10d56vmCz9nql+vYxW LkX9EmQCvw8d0v2wcYJN+Zhrt3XrkiUcLKconNea2E+o9PnaB+EdR560VT7MU2x9YZMX tZG3ezgRWe3NjQIQ9Cmz86dSPMnZyU0hwBWNEoB2dyW0NqR9sIlqaqE7I8zZiUG+Q9IL e2BnVNQ31Va7NuPh/LWziHxziuBECJMxXeUZr4TkCtpBdoDAiVfBgIIw6k+3ulSIDTEb adgw== X-Gm-Message-State: AOAM530+5gDy1m8EGDr0mZAiNL8PTgYfoAZauYONDcpn9Q0u+WFeHBxO TYVgqw/TyY3JI+AMYIv5lSYZgI+8Zb1D5A== X-Google-Smtp-Source: ABdhPJwkFML+PLDt4HBWazsrNhDKIJ8xwgBzwgng+jI6Ece9xfvJoWNzU/ilgtqJbMitjUTDGHK1TQ== X-Received: by 2002:a05:6808:1449:b0:2ca:6675:db7 with SMTP id x9-20020a056808144900b002ca66750db7mr3777918oiv.13.1645137791167; Thu, 17 Feb 2022 14:43:11 -0800 (PST) Original-Received: from tbb-desktop ([181.29.189.16]) by smtp.gmail.com with ESMTPSA id a4sm18992886oaa.42.2022.02.17.14.43.10 for <54048@debbugs.gnu.org> (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 17 Feb 2022 14:43:10 -0800 (PST) X-Google-Original-Message-ID: <87ley9xgg3.fsf@maurooaranda@gmail.com> In-Reply-To: <620ece26.1c69fb81.981be.4780@mx.google.com> (Mauro Aranda's message of "Thu, 17 Feb 2022 19:37:23 -0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:227122 Archived-At: --=-=-= Content-Type: text/plain tags 54048 patch quit Here's a patch: --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-Fix-types-of-some-align.el-defcustoms-Bug-54048.patch Content-Description: patch >From 381ad6c4cf55c9e74c07cf2c2d361d0fbeee7efc Mon Sep 17 00:00:00 2001 From: Mauro Aranda Date: Wed, 16 Feb 2022 20:29:12 -0300 Subject: [PATCH] Fix types of some align.el defcustoms (Bug#54048) * lisp/align.el (align-region-heuristic) (align-large-region): Both options can be nil, but the defcustom type didn't allow nil values. (align-rules-list-type): The "Run If" and "Valid" attributes should be functions, but the default value was t. Change it to #'always. --- lisp/align.el | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/lisp/align.el b/lisp/align.el index 2279c659b4..b054b1bac4 100644 --- a/lisp/align.el +++ b/lisp/align.el @@ -160,7 +160,8 @@ align-region-heuristic point we should search in looking for a region separator. Larger values can mean slower performance in large files, although smaller values may cause unexpected behavior at times." - :type 'integer + :type '(choice (const :tag "Don't use heuristic when aligning a region" nil) + integer) :group 'align) (defcustom align-highlight-change-face 'highlight @@ -176,7 +177,7 @@ align-highlight-nochange-face (defcustom align-large-region 10000 "If an integer, defines what constitutes a \"large\" region. If nil, then no messages will ever be printed to the minibuffer." - :type 'integer + :type '(choice (const :tag "Align a large region silently" nil) integer) :group 'align) (defcustom align-c++-modes '(c++-mode c-mode java-mode) @@ -356,11 +357,11 @@ align-rules-list-type (cons :tag "Valid" (const :tag "(Return non-nil if rule is valid)" valid) - (function :value t)) + (function :value always)) (cons :tag "Run If" (const :tag "(Return non-nil if rule should run)" run-if) - (function :value t)) + (function :value always)) (cons :tag "Column" (const :tag "(Column to fix alignment at)" column) (choice :value comment-column -- 2.17.1 --=-=-=--