unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Dmitry Gutov <dmitry@gutov.dev>
To: Chu Maeda <maedaqu@gmail.com>, 74614@debbugs.gnu.org
Subject: bug#74614: Fwd: bug#74614: Problem of finding the project root when working on submodules of a submodule
Date: Tue, 3 Dec 2024 04:14:58 +0200	[thread overview]
Message-ID: <61ff7773-b4f6-4e22-9f36-10adcc13fc29@gutov.dev> (raw)
In-Reply-To: <CAEhDdq-XaMSPPT7i1YgrGR_KUCj+U4faDk4FN7wtFFiBb9ShHg@mail.gmail.com>

On 02/12/2024 07:15, Chu Maeda wrote:
> 
> Of course, I created such a project on github, you could clone it by 
> command:
> 
> git clone --recurse-submodules https://github.com/chu-mirror/A.git 
> <https://github.com/chu-mirror/A.git>
> 
> The problem is clear when you open the file A/B/C/README.md, and run 
> command project-find-file(C-x p f by default)

Thanks!

It seems we should switch from checking for modules once to doing it in 
a loop. Try this out:

diff --git a/lisp/progmodes/project.el b/lisp/progmodes/project.el
index cf1c94a6d20..3cc063a5d99 100644
--- a/lisp/progmodes/project.el
+++ b/lisp/progmodes/project.el
@@ -591,7 +591,7 @@ project-try-vc--search
                       last-matches))
             vc-handled-backends))
           project)
-    (when (and
+    (while (and
             (eq backend 'Git)
             (project--vc-merge-submodules-p root)
             (project--submodule-p root))

Note you might need to restart Emacs after applying the patch, because 
the directory->project relation is currently cached until restart.





  reply	other threads:[~2024-12-03  2:14 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-30  2:35 bug#74614: Problem of finding the project root when working on submodules of a submodule Chu Maeda
2024-12-02  2:14 ` Dmitry Gutov
     [not found]   ` <CAEhDdq9pdB9HP9M61_Hs7Dh0ea3=oLBjwxwDnh1KGHHO=z1WcQ@mail.gmail.com>
2024-12-02  5:15     ` bug#74614: Fwd: " Chu Maeda
2024-12-03  2:14       ` Dmitry Gutov [this message]
2024-12-03  2:25         ` Chu Maeda
2024-12-03  2:39           ` Dmitry Gutov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=61ff7773-b4f6-4e22-9f36-10adcc13fc29@gutov.dev \
    --to=dmitry@gutov.dev \
    --cc=74614@debbugs.gnu.org \
    --cc=maedaqu@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).