From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#62029: 29.0.60; Allow users to customize eldoc buffer separator Date: Wed, 12 Apr 2023 04:38:28 +0300 Message-ID: <61fd5d66-ca0b-f67d-df70-7906c32596de@gutov.dev> References: <0C40D168-54D5-47E9-8BD8-77CFCD70B895@gmail.com> <87355vdufe.fsf@gmail.com> <87h6uacadx.fsf@gmail.com> <87h6u2y7uj.fsf@gmail.com> <871qkqmzit.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26450"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Cc: 62029@debbugs.gnu.org, Yuan Fu To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Apr 12 03:39:26 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pmPSG-0006h5-1l for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 12 Apr 2023 03:39:24 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pmPRx-0006hC-07; Tue, 11 Apr 2023 21:39:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pmPRv-0006gz-6q for bug-gnu-emacs@gnu.org; Tue, 11 Apr 2023 21:39:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pmPRu-0005Zu-V0 for bug-gnu-emacs@gnu.org; Tue, 11 Apr 2023 21:39:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pmPRu-0000KB-Dx for bug-gnu-emacs@gnu.org; Tue, 11 Apr 2023 21:39:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 12 Apr 2023 01:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62029 X-GNU-PR-Package: emacs Original-Received: via spool by 62029-submit@debbugs.gnu.org id=B62029.16812635231221 (code B ref 62029); Wed, 12 Apr 2023 01:39:02 +0000 Original-Received: (at 62029) by debbugs.gnu.org; 12 Apr 2023 01:38:43 +0000 Original-Received: from localhost ([127.0.0.1]:38561 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pmPRa-0000Jd-In for submit@debbugs.gnu.org; Tue, 11 Apr 2023 21:38:42 -0400 Original-Received: from wnew1-smtp.messagingengine.com ([64.147.123.26]:50457) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pmPRW-0000JO-Eh for 62029@debbugs.gnu.org; Tue, 11 Apr 2023 21:38:40 -0400 Original-Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailnew.west.internal (Postfix) with ESMTP id 3C5F12B06A40; Tue, 11 Apr 2023 21:38:32 -0400 (EDT) Original-Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Tue, 11 Apr 2023 21:38:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm1; t= 1681263511; x=1681267111; bh=WlzqLaRw4BQXHunxegSjWwwGn93ZZ2ZfzZE Nph5ifwQ=; b=YdWbsHUFEKKXubIOEscwMSX+DjsYgT0MFariFThre5vRvreh0/7 4VkjC7Eay8XcNgznsFAsYFqvwoEpdE2btzbdCQpxaFmPX6ARLtg1PHSwc5fP2yrj EPobHzJdZtu2F1yWDSS4sJMHgHGIvNLkS71Jfj3bsmM7hOq8GaWYwyCOykZqa0HX yxJAxdIOD7MhbUELIsDav3a7h+LXBftF2PYWZmn7UjCO+OgYls++7vrhb5w6Zg50 4b4LeA54wCkxUsI4QauOhbd+x3zqYf0sZMqI/jxa3S2VsNH7BQSll2N2fZx826BD G7+YuRXMtSY3O43E/g5xDRSMA1JXEaKrirQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1681263511; x=1681267111; bh=WlzqLaRw4BQXHunxegSjWwwGn93ZZ2ZfzZE Nph5ifwQ=; b=CHkJGak4j6t5P8Wfi9biL9oXRf50MCXjIEynniUpT0/NVR3Sytz tGfk4FgbCRUz+RpAzlmNH6qP/us5pQET9rvWfIj5AYIqMZ9o6XPijxQ1Uvp8Z5vX B+EVQK99GGSsMkN9m5y4LNVABULqXoDJcwNcUKr5iQSMVawBGJQc9h33YMSFaB+H QDpt/PyMrpyOchzxaHNpRkDSpp7Su0ULS4ZkdH7lIhaXHMUaLVnca4bM2iH1TmK6 wtSl9XoTd3G6N2SuPoPT8HS4/ihGxtsDHt/rxUtbQaFmaMXufom147oMajc416Ef ITALSMwQWTNGa/DdoBJYZy/z8GvkW8ezs2Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdekhedggeelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtkeertddtfeejnecuhfhrohhmpeffmhhi thhrhicuifhuthhovhcuoegumhhithhrhiesghhuthhovhdruggvvheqnecuggftrfgrth htvghrnhephfeiueegvdevieeujeelgfdvgefhiedvudegkeelgfelieefkeeiteefveej jedunecuffhomhgrihhnpegvlhdrughonecuvehluhhsthgvrhfuihiivgeptdenucfrrg hrrghmpehmrghilhhfrhhomhepughmihhtrhihsehguhhtohhvrdguvghv X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 11 Apr 2023 21:38:30 -0400 (EDT) Content-Language: en-US In-Reply-To: <871qkqmzit.fsf@gmail.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:259689 Archived-At: On 11/04/2023 14:25, João Távora wrote: > Dmitry Gutov writes: > >> On 30/03/2023 11:13, João Távora wrote: >> >>>>> You do need to set eldoc-documentation-strategy to >>>>> eldoc-documentation-compose though (this should really >>>>> be the default). >>>> >>>> Huh, I wonder why I can see both flymake + eglot in the eldoc doc >>>> buffer when my eldoc-documentation-strategy is the default value? >>> Because Eglot changes eldoc-documentation-strategy automatically. >>> It >>> shouldn't but the default value is really bad. >>> The reason the default value is historic. Previously, there was a >>> single producer of ElDoc, and only in Emacs Lisp. It would decide >>> whether to show variable _or_ function doc, even if a given symbol had >>> more than one meaning. So what's the problem with setting >>> eldoc-documentation-strategy something like e-d-compose, you ask. >>> Well, because of the default value of >>> eldoc-echo-area-use-multiline-p, >>> people would be seeing "bouncing" in the echo area while editing Elisp, >>> which is something they are not used to. >>> I think a very good solution is to set e-d-strategy to e-d-compose >>> globally and e-e-a-use-multiline-p to 1 in emacs-lisp-mode. >>> I once proposed this in this bug tracker, but the message was >>> garbled by >>> some side discussion, and I gave up. And ElDoc wasn't so powerful then. >> >> Last time I tested Eglot's behavior (recently), > > How "recently"? Does it have this commit? > > commit d00e05daa96700860dbb9dc6527105e464ffb960 > Author: João Távora > Date: Sat Mar 25 19:53:14 2023 +0000 > > Eglot: take advantage of new Eldoc options for signature doc > > Only echo the "active signature", send all the other signatures for > the *eldoc* buffer. > > * lisp/progmodes/eglot.el (eglot--sig-info): Rework protocol. > (eglot-signature-eldoc-function): Rework. > > This is also in the latest released Eglot 1.14, btw. I retested it just yesterday (and now as well), to take that screenshot. But that was Emacs 29. With current master, it is indeed better. >> Eldoc took away half the window to display the overloads of a >> function's signature. Screenshot attached. > > This is exactly what I've been working on and discussing with Yuan and > others, so I'm pretty familiar with the situation. >> That doesn't look like good behavior to me, no matter the language or >> IDE package used. > > I agree, and this is why I changed it. Let's hope noone complains > (unlikely, but possible, as this changed longstanding behaviour). > > But here I was describing something not related to Eglot at all, rather > elisp-mode.el. Do you have something to say about that? Did you try > the patch I showed Yuan? I have applied it. What should I be looking at?