From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mauro Aranda Newsgroups: gmane.emacs.bugs Subject: bug#66391: 30.0.50; Error when saving a face with :underline attribute in Customize Date: Sat, 7 Oct 2023 12:02:48 -0300 Message-ID: <61d61043-a49b-4a73-bc62-fe786467d7a3@gmail.com> References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------Qb3FOYxBKVi60NGghOu1WUE1" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14525"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla Thunderbird To: 66391@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Oct 07 17:04:04 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qp8qZ-0003UK-Mp for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 07 Oct 2023 17:04:03 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qp8qI-0006Ut-HP; Sat, 07 Oct 2023 11:03:47 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qp8qF-0006UD-3t for bug-gnu-emacs@gnu.org; Sat, 07 Oct 2023 11:03:43 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qp8qE-0007z9-RQ for bug-gnu-emacs@gnu.org; Sat, 07 Oct 2023 11:03:42 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qp8qY-0006OI-8G for bug-gnu-emacs@gnu.org; Sat, 07 Oct 2023 11:04:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Mauro Aranda Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 07 Oct 2023 15:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66391 X-GNU-PR-Package: emacs Original-Received: via spool by 66391-submit@debbugs.gnu.org id=B66391.169669099924478 (code B ref 66391); Sat, 07 Oct 2023 15:04:02 +0000 Original-Received: (at 66391) by debbugs.gnu.org; 7 Oct 2023 15:03:19 +0000 Original-Received: from localhost ([127.0.0.1]:55637 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qp8pr-0006Mh-8b for submit@debbugs.gnu.org; Sat, 07 Oct 2023 11:03:19 -0400 Original-Received: from mail-pl1-x62b.google.com ([2607:f8b0:4864:20::62b]:60725) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qp8pp-0006MP-Ei; Sat, 07 Oct 2023 11:03:18 -0400 Original-Received: by mail-pl1-x62b.google.com with SMTP id d9443c01a7336-1c6219307b2so22054585ad.1; Sat, 07 Oct 2023 08:02:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696690971; x=1697295771; darn=debbugs.gnu.org; h=in-reply-to:references:to:from:content-language:subject:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=5ikuktPbP7WbTyvLWjZr8J2ga96RVtCHhXm6fTx6Mdk=; b=D8wuvu/ypdly1Wpu+tfBIDJHsPXE6tgbwRm3Zpg5A5luMvyALS8BIwRE94Zh8VqnCe KN9AXldqlM/AcBpGiTASGoOOCa5Jgv/N0+tPPbE4LRehTZSdWsMxmuPmMlqXAVmImiSA xpCDl0W08d2rZW10cSzbubwLy9UHWFvhy066g+HRtcNjSbeuTDu2bJ7M8L8vig9wArUx aqfNrbOUGra/uW8/RxuNVV0jrJClkVwfq58T5rH74qpQbFkkZ+2KWTSgeoKTe9/OmH+2 r2uLEN5DgLCyNeXV6LkUMVo8lHreOipR7tKYPn8xKlJOgHqo8DVyy+W6ksUZ4V3IcBhc yKdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696690971; x=1697295771; h=in-reply-to:references:to:from:content-language:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=5ikuktPbP7WbTyvLWjZr8J2ga96RVtCHhXm6fTx6Mdk=; b=ht0zOXonupvdP3h1e5upqtEzqRNhT85bmN9ZA+P3RKM1BjdJQ6WzAgfvGu2zgJse3r ahg2hpe/aNi0H9lmBfjSn1jqmwMwg+lh6ZwcIVVDN3ODeD5ixDEBOS3AnWeB7KeSPTas CA170CtFQeu6p0HnZnA6k1IVtYDYm2tDg4oc3f5Y2/y2FOowzQuGj9qHZFLUc0z8/agG DFlqQ/3p01iyYmmRIX3qmPNRbHT6gFkzvR+QjcMqU/llz0FxT7yGleIH9n52UajuuVx+ ZyOjpxpH84+HRRSMK5hdCRvIEQZUPYz0P4ElBty59Us/O2moz6VKwGmNYGpsHrIVwq6d 6/Aw== X-Gm-Message-State: AOJu0YxrYq8EBMbt7Tk0HfBDrBuUSz5KclydxvMC1OWPiamsKa2I+qaw TLJVtKntZMDsDllOajKBus+2dDrGws8= X-Google-Smtp-Source: AGHT+IH9kG5dWEIQcAiuTyg/CavmNsrIO4DP5kQZS7lR85nu8LRthNpewqoQuoAEv0gDAPU2ckF/8A== X-Received: by 2002:a17:903:452:b0:1c5:cebd:ee83 with SMTP id iw18-20020a170903045200b001c5cebdee83mr9578751plb.54.1696690971300; Sat, 07 Oct 2023 08:02:51 -0700 (PDT) Original-Received: from [192.168.0.234] ([152.168.142.156]) by smtp.gmail.com with ESMTPSA id v10-20020a1709028d8a00b001c5f0fe64c2sm5958668plo.56.2023.10.07.08.02.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 07 Oct 2023 08:02:50 -0700 (PDT) Content-Language: en-US In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:272009 Archived-At: This is a multi-part message in MIME format. --------------Qb3FOYxBKVi60NGghOu1WUE1 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit tags 66391 patch quit Hmm, actually, it was I that made a thinko when trying to fix Bug#44331 that the previously cited commit introduced. commit ecec9a259b13d88fa23dde078fba99ae78ef79c7 Author: Mauro Aranda Date: Sun Nov 1 10:10:08 2020 -0300 Fix saving a face setting with Customize * lisp/cus-edit.el (custom-face-save): Make sure we back up into the :shown-value property what the user has edited so far, if we are going to recreate the custom-face widget. (Bug#44331) --- The :shown-value should be just the value as the widget holds it, not a post-filtered one. --------------Qb3FOYxBKVi60NGghOu1WUE1 Content-Type: text/x-patch; charset=UTF-8; name="0001-Fix-saving-faces-with-attributes-that-need-filtering.patch" Content-Disposition: attachment; filename*0="0001-Fix-saving-faces-with-attributes-that-need-filtering.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSBlMDAzYjI0YWQ2OWQwZGNlNDkxNmIzMmU2YzVjMzZjMjc0NWIyNGFlIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBNYXVybyBBcmFuZGEgPG1hdXJvb2FyYW5kYUBnbWFp bC5jb20+CkRhdGU6IFNhdCwgNyBPY3QgMjAyMyAxMTo1NzoxOCAtMDMwMApTdWJqZWN0OiBb UEFUQ0hdIEZpeCBzYXZpbmcgZmFjZXMgd2l0aCBhdHRyaWJ1dGVzIHRoYXQgbmVlZCBmaWx0 ZXJpbmcKCiogbGlzcC9jdXMtZWRpdC5lbCAoY3VzdG9tLWZhY2Utc2F2ZSk6IFRoZSA6c2hv d24tdmFsdWUgcHJvcGVydHkgZm9yCnRoZSBjdXN0b20tZmFjZSB3aWRnZXQgaXMgc3VwcG9z ZWQgdG8gYmUgYSB2YWx1ZSBzdWl0YWJsZSBmb3IgdGhlCmN1c3RvbWl6YXRpb24gd2lkZ2V0 LiAgKEJ1ZyM2NjM5MSkKLS0tCiBsaXNwL2N1cy1lZGl0LmVsIHwgNSArKysrLQogMSBmaWxl IGNoYW5nZWQsIDQgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQoKZGlmZiAtLWdpdCBh L2xpc3AvY3VzLWVkaXQuZWwgYi9saXNwL2N1cy1lZGl0LmVsCmluZGV4IDEwMjE3MDc5MDdk Li43MDZlMDhkNTY1NyAxMDA2NDQKLS0tIGEvbGlzcC9jdXMtZWRpdC5lbAorKysgYi9saXNw L2N1cy1lZGl0LmVsCkBAIC00MTQ4LDcgKzQxNDgsMTAgQEAgY3VzdG9tLWZhY2Utc2F2ZQog ICAgICAgOzsgSWYgcmVjcmVhdGluZyBhIHdpZGdldCB0aGF0IG1heSBoYXZlIGJlZW4gZWRp dGVkIGJ5IHRoZSB1c2VyLCByZW1lbWJlcgogICAgICAgOzsgdG8gYWx3YXlzIHNhdmUgdGhl IGVkaXRlZCB2YWx1ZSBpbnRvIHRoZSA6c2hvd24tdmFsdWUgcHJvcGVydHksIHNvCiAgICAg ICA7OyB3ZSB1c2UgdGhhdCB2YWx1ZSBmb3IgdGhlIHJlY3JlYXRlZCB3aWRnZXQuICAoQnVn IzQ0MzMxKQotICAgICAgKHdpZGdldC1wdXQgd2lkZ2V0IDpzaG93bi12YWx1ZSAoY3VzdG9t LWZhY2Utd2lkZ2V0LXRvLXNwZWMgd2lkZ2V0KSkKKyAgICAgIChsZXQgKChjaGlsZCAoY2Fy ICh3aWRnZXQtZ2V0IHdpZGdldCA6Y2hpbGRyZW4pKSkpCisgICAgICAgIChpZiAoZXEgKHdp ZGdldC10eXBlIGNoaWxkKSAnY3VzdG9tLWZhY2UtZWRpdCkKKyAgICAgICAgICAgICh3aWRn ZXQtcHV0IHdpZGdldCA6c2hvd24tdmFsdWUgYCgodCAsKHdpZGdldC12YWx1ZSBjaGlsZCkp KSkKKyAgICAgICAgICAod2lkZ2V0LXB1dCB3aWRnZXQgOnNob3duLXZhbHVlICh3aWRnZXQt dmFsdWUgY2hpbGQpKSkpCiAgICAgICAoY3VzdG9tLWZhY2UtZWRpdC1hbGwgd2lkZ2V0KQog ICAgICAgKHdpZGdldC1wdXQgd2lkZ2V0IDpzaG93bi12YWx1ZSBuaWwpIDsgUmVzZXQgaXQg YWZ0ZXIgd2UgdXNlZCBpdC4KICAgICAgIChjdXN0b20tZmFjZS1tYXJrLXRvLXNhdmUgd2lk Z2V0KQotLSAKMi4zNC4xCgo= --------------Qb3FOYxBKVi60NGghOu1WUE1--