From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#61302: 29.0.60; rust-ts-mode does not show function-invocation on field-properties Date: Mon, 13 Feb 2023 05:37:26 +0200 Message-ID: <61cb2b34-0be2-1f69-e72d-5351fbe9e48f@yandex.ru> References: <6209c097-0369-828a-7513-d8afb73fd7f0@secure.kjonigsen.net> <56a0b3d9-4a8f-0f81-83cb-6b78271dd782@yandex.ru> <3dc0ab0a-b0b1-91b8-f393-8db3899cf956@yandex.ru> <05ee38a5-f783-5b2c-add6-ee2ea27ba297@yandex.ru> <8a58c831-d8e6-c5b8-67b0-c606b2b3f189@yandex.ru> <33cec9a6-7e69-2eb3-a8a6-58ce23a5c185@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20540"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Cc: eliz@gnu.org, Jostein =?UTF-8?Q?Kj=C3=B8nigsen?= , 61302@debbugs.gnu.org To: Randy Taylor Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Feb 13 04:38:28 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pRPff-0005Bd-Ta for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 13 Feb 2023 04:38:28 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pRPfI-0003Bk-UD; Sun, 12 Feb 2023 22:38:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pRPfG-0003As-VE for bug-gnu-emacs@gnu.org; Sun, 12 Feb 2023 22:38:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pRPfG-00067A-MS for bug-gnu-emacs@gnu.org; Sun, 12 Feb 2023 22:38:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pRPfG-0007Y4-BV for bug-gnu-emacs@gnu.org; Sun, 12 Feb 2023 22:38:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 13 Feb 2023 03:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61302 X-GNU-PR-Package: emacs Original-Received: via spool by 61302-submit@debbugs.gnu.org id=B61302.167625945728980 (code B ref 61302); Mon, 13 Feb 2023 03:38:02 +0000 Original-Received: (at 61302) by debbugs.gnu.org; 13 Feb 2023 03:37:37 +0000 Original-Received: from localhost ([127.0.0.1]:47301 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pRPer-0007XM-CA for submit@debbugs.gnu.org; Sun, 12 Feb 2023 22:37:37 -0500 Original-Received: from mail-ej1-f45.google.com ([209.85.218.45]:36393) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pRPep-0007X5-A3 for 61302@debbugs.gnu.org; Sun, 12 Feb 2023 22:37:35 -0500 Original-Received: by mail-ej1-f45.google.com with SMTP id lu11so28723633ejb.3 for <61302@debbugs.gnu.org>; Sun, 12 Feb 2023 19:37:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=11P+k3iGRL1V/35co9JQBKc4h9vU/M718TIo1x17F2M=; b=T4wkfLrRDlY1daP5RjVSWSVRC3G/N87Chi6ZkrUG7CFdfmANlW2czO8PvnMWcBZ/wQ JMe5kq2T7Kbg9OcQuYA50AWops9ejt51L2900gtRV+sqE3Era+/bTdKzmqSrGakhfs2S ji0aAL7RAIpaH7mgPjZcERBwAdIM2qs9aBSLXnz6wg2ax4FpZ3zTSgSwHxQT0/h00RzU u/lCg+kEGXW8ywRWrzujiCY9JDyFGOlJITjHwZPq0RdmNJo5i1sAyK0/+DCH5w2rdD3/ 0ArC7N5BPGcZ4lC1VYhLkWaS878Tl7PCY+ibdbUUArN4CE3GZB2W56Qp/Sc+kejU63hV l1VA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=11P+k3iGRL1V/35co9JQBKc4h9vU/M718TIo1x17F2M=; b=4tvOkHwiNhsLjg8OCVWPK2iKKJUDlJ2Lgc3pEzQ0vHy5O34wGXhCDh9Mzy+RN4EuSK jTM5dlkfKWDK9dU+p6tGsXlVP8KaJxHUR5GK7Ulpo0ZeugrybU7+xijUwfC0q0QVbI5R 6BqWzrGK8nQ1LdyamDtPOttCOC2uSphO9q8lbxFvxApwQmilGLmUNvj8EXLBTHF8qFYz 0UADCj8kWdAy1Yjp/3dkcfRnaao2dYA4OY3TCurdsZEIJv604k2+nr0+OB86S7FT06Vd BxzplupxaMNosTx1BZzFs8HbArpd625uQL0gu2exf5R9Ap9w5Qf/Y+HFYQeiB6/atRnI daLA== X-Gm-Message-State: AO0yUKX4G5ZjnUHHfNkbG65V+PTzJPkq1vOKzLxlsdgSJ6NC6a+IZTOI TLGedlG7kI3RXtbUsRNacZE= X-Google-Smtp-Source: AK7set83S4x835xJCWiGi1UgqHjlmyzojpbT/i9n/XZWQmEiweR81M2d1CJKk0J9UZ95sRnoJ97OUg== X-Received: by 2002:a17:907:969e:b0:8b0:fbd0:f7d2 with SMTP id hd30-20020a170907969e00b008b0fbd0f7d2mr4850251ejc.30.1676259449152; Sun, 12 Feb 2023 19:37:29 -0800 (PST) Original-Received: from [192.168.0.2] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id c15-20020a17090603cf00b0088bd62b1cbbsm6149746eja.192.2023.02.12.19.37.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 12 Feb 2023 19:37:28 -0800 (PST) Content-Language: en-US In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:255459 Archived-At: On 12/02/2023 04:48, Randy Taylor wrote: >> I'm not quite sure what's the best choice here (keeping in mind the >> problem with overreaching variable highlights on level 4), but >> logically, I think 'module' belongs with 'function' and 'property' >> because all three denote some basic syntactic elements which are easy to >> understand even without colors, and are harder to make a mistake in. > > I am proposing to get rid of the module feature entirely and bring those queries into the type feature because: > - Of how much overlap there is between them > - It will make maintaining the queries much easier > - It's already a headache dealing with them separately, and I'm not sure the best way to deal with the issues of them being separate (and the different levels of highlighting to worry about). It will probably be quite the hack to deal with it, and no matter what I tried stuff was always sneaking through. > - It also won't introduce that much more highlighting Okay, let's try that. >>>> Also here's a pre-existing problem mentioned above: >>>> >>>> use std::{fmt, fs, usize}; >>>> >>>> 'fmt' and 'fs' are not types. But they are highlighted with >>>> font-lock-type-face. >>> >>> This is really weird, I can reproduce it with emacs -Q but not with my normal config... >>> Also with emacs -Q this: >>> let date = DateTime::::from_utc(date, chrono::cool::this::Utc); >>> >>> highlights incorrectly, where "there" is font-lock-variable-name-face. But with my normal config everything is fine. >>> >>> I'll look into it tomorrow. Not really sure what in my config could cause this... >> >> Thank you. > > I did a clean build and wasn't able to reproduce it anymore. Guess it was stale bytecode or something? > At level 4 everything highlights correctly I believe, and with level 3 the only issues are the module highlighting ones, and to deal with that I think the module feature should be merged into the type one as I mentioned above. Then we can call it a day :). I'll post a new patch with those changes if you agree. Please go ahead, and thanks. :-)