From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#29381: show-paren-mode should not be globalized Date: Fri, 10 Sep 2021 02:57:43 +0300 Message-ID: <619d681e-d286-25ab-4ee3-913c473339da@yandex.ru> References: <1511260134.1854673.1179585816.34ED67B1@webmail.messagingengine.com> <1511261140.1859967.1179600504.3FD241DA@webmail.messagingengine.com> <878s0e402x.fsf@gnus.org> <87fsum2j4j.fsf@gnus.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------72CB6F49B0F07A9B88556BDB" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16431"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 Cc: Phil Sainty , 29381@debbugs.gnu.org, Stefan Kangas , Andreas Schwab To: Lars Ingebrigtsen , "Paul W. Rankin" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Sep 10 01:58:46 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mOTwM-00047i-Gc for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 10 Sep 2021 01:58:46 +0200 Original-Received: from localhost ([::1]:60178 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mOTwL-0000IY-30 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 09 Sep 2021 19:58:45 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52642) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mOTvg-0000DH-AA for bug-gnu-emacs@gnu.org; Thu, 09 Sep 2021 19:58:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53133) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mOTve-0004Qc-EL for bug-gnu-emacs@gnu.org; Thu, 09 Sep 2021 19:58:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mOTve-00044C-BL for bug-gnu-emacs@gnu.org; Thu, 09 Sep 2021 19:58:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 09 Sep 2021 23:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29381 X-GNU-PR-Package: emacs Original-Received: via spool by 29381-submit@debbugs.gnu.org id=B29381.163123187415618 (code B ref 29381); Thu, 09 Sep 2021 23:58:02 +0000 Original-Received: (at 29381) by debbugs.gnu.org; 9 Sep 2021 23:57:54 +0000 Original-Received: from localhost ([127.0.0.1]:36446 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mOTvV-00043q-VT for submit@debbugs.gnu.org; Thu, 09 Sep 2021 19:57:54 -0400 Original-Received: from mail-wm1-f46.google.com ([209.85.128.46]:44906) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mOTvU-00043a-6n for 29381@debbugs.gnu.org; Thu, 09 Sep 2021 19:57:52 -0400 Original-Received: by mail-wm1-f46.google.com with SMTP id l7-20020a1c2507000000b002e6be5d86b3so139651wml.3 for <29381@debbugs.gnu.org>; Thu, 09 Sep 2021 16:57:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language; bh=HbYQb8AMmIAq8CZSksN7XAPbDzVvst2/7MTjb2Pv8Xw=; b=l/xqyucMQaRI8XL8+TWsRr6VlHdslTd+SreU44/mC2ZzUTfZ3qU01hULGlJKpe23k/ GD546h9Vl4wdjfGZ5RgiDaUIO8MQSCkqSzmYMRmkNM4d0WBSa+/maNxOxQ94C09L1j4l tnN/NjscCgG9MnuZBEeUwhPZgsexvLpyiG2S3MPG5oBMLl/7V1Z98dm3GJHYbDuWsek/ WtFaM/nnQs+WS5axUHpQ3K5N+1EoWFDguuGplK/jokRd3/sgGtQkn+EaiUIrQRVZh+dx go8ltis5Xy9melUWVmzgLa4MBcv3CpEeMcvOWVuqFVeZnjd7ZqUp6S290dMYdZ6mjxih Kmdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language; bh=HbYQb8AMmIAq8CZSksN7XAPbDzVvst2/7MTjb2Pv8Xw=; b=CWUfLQWU+smqQpsmVNdyzs/rMZLTsATr3mFee9Q9Zh/hjkxTDsJw2k17g1IzIOfg0z v35xf3fw+etpH7AYT6L7+SVi2REPvGngjumvgv3eCv2gLxexEHIW4xbCgs6IxKBqOJ4+ c0aA1bV2gWJDrR6t4TuVcZWQQMkPrrf5VHTxak9L5SfgR7wzGdpTW7luqYhQE/+Tq3xn xMuPayTjc2k9CtLIJ+zP1Of/fkMrqrPjR+/xZO0OJ/dqVBaqXAEjAAejQY8zHdDe/RZ+ +Gteu5FvXjniJ4UbSdOUEGmZN6Z4ncb5sNEqmUrD6mt0zk/3FSREA/Cnb8z3bRP1NK6b NGhg== X-Gm-Message-State: AOAM533bvNljbj+qDPYkpFIbB69e81g2H/s7I45Hg8jn6URiqhjT9eQx cbjvPKx9BCvb3OXPDddgikM= X-Google-Smtp-Source: ABdhPJxJDwEfpegJvUVNF4Fu2cvr3gVHsFg0DVzXWTDI496nap9TO4tIt13NAM2eN38QDTyY+O3fDQ== X-Received: by 2002:a7b:c246:: with SMTP id b6mr5523958wmj.37.1631231866286; Thu, 09 Sep 2021 16:57:46 -0700 (PDT) Original-Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id h11sm3653643wrx.9.2021.09.09.16.57.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 09 Sep 2021 16:57:45 -0700 (PDT) In-Reply-To: <87fsum2j4j.fsf@gnus.org> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:213953 Archived-At: This is a multi-part message in MIME format. --------------72CB6F49B0F07A9B88556BDB Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 03.09.2021 10:50, Lars Ingebrigtsen wrote: > "Paul W. Rankin" writes: > >> There are plenty of minor modes that use FOO-mode (global) and >> FOO-local-mode > That's a good point; didn't know that. Perhaps we should flip this > around as suggested, then, and I'm reopening this bug report. Here's a patch, modeled after electric-indent-local-mode. --------------72CB6F49B0F07A9B88556BDB Content-Type: text/x-patch; charset=UTF-8; name="show-paren-local-mode.diff" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="show-paren-local-mode.diff" diff --git a/lisp/paren.el b/lisp/paren.el index a45a08abd3..5c3c85828b 100644 --- a/lisp/paren.el +++ b/lisp/paren.el @@ -114,8 +114,28 @@ show-paren-mode show-paren-delay t #'show-paren-function)) (unless show-paren-mode - (delete-overlay show-paren--overlay) - (delete-overlay show-paren--overlay-1))) + (show-paren--delete-overlays))) + +(defun show-paren--delete-overlays () + (delete-overlay show-paren--overlay) + (delete-overlay show-paren--overlay-1)) + +;;;###autoload +(define-minor-mode show-paren-local-mode + "Toggle `show-paren-mode' only in this buffer." + :variable (buffer-local-value 'show-paren-mode (current-buffer)) + (cond + ((eq show-paren-mode (default-value 'show-paren-mode)) + (unless show-paren-mode + (show-paren--delete-overlays)) + (kill-local-variable 'show-paren-mode)) + ((not (default-value 'show-paren-mode)) + ;; Locally enabled, but globally disabled. + (show-paren-mode 1) ; Setup the timer. + (setq-default show-paren-mode nil) ; But keep it globally disabled. + ) + (t ;; Locally disabled only. + (show-paren--delete-overlays)))) (defun show-paren--unescaped-p (pos) "Determine whether the paren after POS is unescaped." --------------72CB6F49B0F07A9B88556BDB--