From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Andreas Hilboll Newsgroups: gmane.emacs.bugs Subject: bug#37637: 27.0.50; Segmentation fault when setting font face for new frames Date: Tue, 08 Oct 2019 14:56:58 +0200 Message-ID: <616d6cd243f3c04026b32ac27b677425@posteo.de> References: <878spxyjms.fsf@posteo.de> <83pnj92189.fsf@gnu.org> <877e5gxocp.fsf@posteo.de> <83pnj7y5hb.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="123867"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Posteo Webmail To: 37637@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Oct 08 14:58:12 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iHp48-000Vub-0G for geb-bug-gnu-emacs@m.gmane.org; Tue, 08 Oct 2019 14:58:12 +0200 Original-Received: from localhost ([::1]:55346 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iHp46-0007Zr-Bt for geb-bug-gnu-emacs@m.gmane.org; Tue, 08 Oct 2019 08:58:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36174) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iHp3z-0007Zg-Ay for bug-gnu-emacs@gnu.org; Tue, 08 Oct 2019 08:58:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iHp3y-000805-9u for bug-gnu-emacs@gnu.org; Tue, 08 Oct 2019 08:58:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40892) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iHp3x-0007yq-Nk for bug-gnu-emacs@gnu.org; Tue, 08 Oct 2019 08:58:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iHp3x-0003Uf-Ll for bug-gnu-emacs@gnu.org; Tue, 08 Oct 2019 08:58:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Andreas Hilboll Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 08 Oct 2019 12:58:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37637 X-GNU-PR-Package: emacs Original-Received: via spool by 37637-submit@debbugs.gnu.org id=B37637.157053943413373 (code B ref 37637); Tue, 08 Oct 2019 12:58:01 +0000 Original-Received: (at 37637) by debbugs.gnu.org; 8 Oct 2019 12:57:14 +0000 Original-Received: from localhost ([127.0.0.1]:49713 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iHp3C-0003Td-27 for submit@debbugs.gnu.org; Tue, 08 Oct 2019 08:57:14 -0400 Original-Received: from mout02.posteo.de ([185.67.36.66]:52995) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iHp39-0003TP-9W for 37637@debbugs.gnu.org; Tue, 08 Oct 2019 08:57:12 -0400 Original-Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id 9A7E72400FD for <37637@debbugs.gnu.org>; Tue, 8 Oct 2019 14:57:04 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.de; s=2017; t=1570539424; bh=QwAeZX75R89k3EDlZD8G4VSQCdtUIqUS8Z9yBD0PluQ=; h=Date:From:To:Subject:From; b=MN6Ycg7QK+zSI/roMfVcYGxkIQ3nW2AowZnA9Kvxd17QRY5JaLtdhbWnqosIA3IqV BanIvV2qiFfVxJNj5CX4+/X9y0magW0+EQvbuT2pSr3ewqqbXpXfhxReMUhnSij7d5 5o7efxhjVR7zAS5EI13UBaBiq0nz1owApIqqPjoEgbGJQq86uaMLlwpuipH9Zwwu65 r6RsKVnFaTojFbZbdMYa+rAXm4/sMFlXSfgVwhvBesXsCijYlcPXjR1wnAuzKRZOPv kIAYr9N7khPSDOFq0A/w3T5LyekYNelxRYGJpz3tzlX9UWpKWvtMd+xdZxzIMC+6uP ChWIN5UYc7D8g== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 46ncnB2XbBz9rxb for <37637@debbugs.gnu.org>; Tue, 8 Oct 2019 14:57:02 +0200 (CEST) In-Reply-To: <83pnj7y5hb.fsf@gnu.org> X-Sender: andreas.hilboll@posteo.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:168643 Archived-At: > Thanks, please see if the patch below gives good results. > > diff --git a/src/font.c b/src/font.c > index 935dd64..044c437 100644 > --- a/src/font.c > +++ b/src/font.c > @@ -3314,6 +3314,9 @@ font_open_for_lface (struct frame *f, > Lisp_Object entity, Lisp_Object *attrs, Li > pt = XFIXNUM (attrs[LFACE_HEIGHT_INDEX]); > else > { > + /* We need the default face to be valid below. */ > + if (FRAME_FACE_CACHE (f)->used == 0) > + recompute_basic_faces (f); > struct face *def = FACE_FROM_ID (f, DEFAULT_FACE_ID); > Lisp_Object height = def->lface[LFACE_HEIGHT_INDEX]; > eassert (FIXNUMP (height)); Great, this seems to fix it. Works without problems now (after opening ~10 new frames without any crash I stopped ...). Thanks for the quick help!