From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gregory Heytings Newsgroups: gmane.emacs.bugs Subject: bug#52053: 29.0.50; Nonsensical button "C-x C-f" in scratch buffer Date: Thu, 25 Nov 2021 13:41:50 +0000 Message-ID: <612d659daad03d6bc73d@heytings.org> References: <87czmr5gr7.fsf.ref@yahoo.com> <87czmr5gr7.fsf@yahoo.com> <612d659daa29af13c2e5@heytings.org> <83y25c5wn0.fsf@gnu.org> <612d659daabc268505c4@heytings.org> <83pmqo5vmp.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; format=flowed; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9164"; mail-complaints-to="usenet@ciao.gmane.io" Cc: luangruo@yahoo.com, larsi@gnus.org, 52053@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Nov 25 14:42:19 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mqF11-0002Eu-Bg for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 25 Nov 2021 14:42:19 +0100 Original-Received: from localhost ([::1]:43780 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mqF10-0001Hu-79 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 25 Nov 2021 08:42:18 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:42910) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mqF0l-0001FW-1V for bug-gnu-emacs@gnu.org; Thu, 25 Nov 2021 08:42:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44637) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mqF0k-0003vT-0w for bug-gnu-emacs@gnu.org; Thu, 25 Nov 2021 08:42:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mqF0j-0003Ns-SQ for bug-gnu-emacs@gnu.org; Thu, 25 Nov 2021 08:42:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Gregory Heytings Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 25 Nov 2021 13:42:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52053 X-GNU-PR-Package: emacs Original-Received: via spool by 52053-submit@debbugs.gnu.org id=B52053.163784771712995 (code B ref 52053); Thu, 25 Nov 2021 13:42:01 +0000 Original-Received: (at 52053) by debbugs.gnu.org; 25 Nov 2021 13:41:57 +0000 Original-Received: from localhost ([127.0.0.1]:56183 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mqF0f-0003NW-Dp for submit@debbugs.gnu.org; Thu, 25 Nov 2021 08:41:57 -0500 Original-Received: from heytings.org ([95.142.160.155]:48782) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mqF0a-0003NL-Py for 52053@debbugs.gnu.org; Thu, 25 Nov 2021 08:41:55 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20210101; t=1637847711; bh=Wvb177Z4GxPpCsWueolmCNXnGX2WnbfRZRdJywCDA/s=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=QBTo6Ew11n2oiumbga7YR/tOV59jeJ3Z7mDsBahG5ydrDD1PArrweB9t+T7/jSrWv GqHpc3v/MW7duU11qijCh6BEoO+ZquIYA5RRVhkhQjK3DxUPVuWVAaTFGMiQ4z7yp7 OcSVn9H+Cc+yz3LAFGDAJMdbqghpn2a5+s9Nj9cdlSvDYsCPg0fWq2MIYZjaU+UdX2 05sQGY5lrPBj9ZOWyeKwsD3COCSeQGt0vNIrZcaONLO/J7xSwQR2FwUbKJIWKOt3pD vtSTbdc+Dzzoqt2S8TxyKEfpf9g4kf/dg/etOb+qJ5jereLqKM+UCeVNo+ijgAtqrS axwuyYRj/P0ZQ== In-Reply-To: <83pmqo5vmp.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:220828 Archived-At: > > Yes, but that's somewhat blunt a weapon, I think. My idea was to maybe > let the caller decide whether this is wanted or not, if we are going to > use substitute-command-keys in way more contexts than it was originally > meant to. > AFAICS, the options are: 1. Detect inside substitute-command-keys whether the string is for a *Help* buffer. That's what the patch does, it's the simplest solution from the point of view of those who call s-c-k. 2. Add an optional parameter to s-c-k to indicate whether the string is for a non-*Help* buffer. That's a reasonable alternative, but there are ~450 calls to s-c-k in the trunk, each would have to be checked. 3. Add a variable and let-bind it around the calls to s-c-k to indicate when the string is for a non-*Help* buffer. 4. Let-bind help-link-key-to-documentation to nil around the calls to s-c-k to indicate that the calls to help-mode--add-function-link should be skipped. ISTM that this is not generic enough, if in six months we had another similar feature it would be necessary to let-bind two variables around calls for non-*Help* buffers, and so forth.