From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#6227: Color isearch regexp submatches differently Date: Sun, 20 Sep 2020 13:25:25 -0700 (PDT) Message-ID: <612cdf24-5ffd-4418-909c-59bbbe6664ed@default> References: <87bpca15ja.fsf@mail.jurta.org> <87wruv1ohr.fsf@mail.jurta.org> <877hmvtn9t.fsf@mail.jurta.org> <874ohyppfs.fsf@mail.jurta.org> <8739ww1tjp.fsf@mail.jurta.org> <87d3vyaodq.fsf@mail.jurta.org> <87hbla4nl4.fsf@mail.jurta.org> <87mu1llak3.fsf@gnus.org> <83lfh50zxa.fsf@gnu.org> <87eemwss3t.fsf@gnus.org> <834kns22q2.fsf@gnu.org> <87sgbcrcgd.fsf@gnus.org> <874knso90e.fsf@gnus.org> <83pn6gzg3j.fsf@gnu.org> <87363ckza5.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2677"; mail-complaints-to="usenet@ciao.gmane.io" Cc: lennart.borgman@gmail.com, 6227@debbugs.gnu.org To: Lars Ingebrigtsen , Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Sep 20 22:26:37 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kK5uu-0000bI-6k for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 20 Sep 2020 22:26:36 +0200 Original-Received: from localhost ([::1]:47790 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kK5ut-0004oT-7s for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 20 Sep 2020 16:26:35 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48246) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kK5uM-0004nh-5n for bug-gnu-emacs@gnu.org; Sun, 20 Sep 2020 16:26:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:41223) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kK5uL-00042g-Rg for bug-gnu-emacs@gnu.org; Sun, 20 Sep 2020 16:26:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kK5uL-0002wO-N2 for bug-gnu-emacs@gnu.org; Sun, 20 Sep 2020 16:26:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 20 Sep 2020 20:26:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6227 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed patch Original-Received: via spool by 6227-submit@debbugs.gnu.org id=B6227.160063353811274 (code B ref 6227); Sun, 20 Sep 2020 20:26:01 +0000 Original-Received: (at 6227) by debbugs.gnu.org; 20 Sep 2020 20:25:38 +0000 Original-Received: from localhost ([127.0.0.1]:52769 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kK5ty-0002vl-Ff for submit@debbugs.gnu.org; Sun, 20 Sep 2020 16:25:38 -0400 Original-Received: from userp2120.oracle.com ([156.151.31.85]:59790) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kK5tv-0002vX-TN for 6227@debbugs.gnu.org; Sun, 20 Sep 2020 16:25:37 -0400 Original-Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 08KKPSFj183026; Sun, 20 Sep 2020 20:25:28 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2020-01-29; bh=bsQL5/Q5MgfMDuJV46KDREifEoaScqGqa8zvMO43df4=; b=z49VYL9YVzRJdzEnVO3lA6vff8hVwo5KKjKDrzDnQgL0GdQjbRTJZGbbVgj7FTSA+BM0 c54GArxwr8U6z4U7GR7SddC5+hhMrTcPDPcWywRRfPgTKvSCY700npefSsADx8ODorMf s4Q26ozr5RSmMBnsvip5S8SMs30H4wbVAyu5zVBEyJw2FM12CwUnn5bld6rWeFuYtnqd uYRwn3SKoKekLrn9st+r7jQHPMYMDsRbeofly2jibU/ix9CY+xJlFpNxtl8LjTU4zISj 5FE7Eb12GFcYpYRZE8g5oYcYe2meXNxeO0HnehLEsGsUKNPZ+xtmimAZBTBuxucf4oea Gg== Original-Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by userp2120.oracle.com with ESMTP id 33ndnu2kds-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Sun, 20 Sep 2020 20:25:28 +0000 Original-Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 08KKKDWq052156; Sun, 20 Sep 2020 20:25:27 GMT Original-Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by aserp3030.oracle.com with ESMTP id 33nujjt1ww-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 20 Sep 2020 20:25:27 +0000 Original-Received: from abhmp0006.oracle.com (abhmp0006.oracle.com [141.146.116.12]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 08KKPPSR013791; Sun, 20 Sep 2020 20:25:26 GMT In-Reply-To: <87363ckza5.fsf@gnus.org> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.5056.0 (x86)] X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9750 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 malwarescore=0 mlxlogscore=963 phishscore=0 adultscore=0 spamscore=0 suspectscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2009200181 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9750 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 lowpriorityscore=0 phishscore=0 adultscore=0 suspectscore=0 bulkscore=0 clxscore=1015 impostorscore=0 mlxlogscore=988 mlxscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2009200182 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:188542 Archived-At: > > What bothers me is that faces isearch-group-6 to isearch-group-9 are > > not defined. Should we define them? >=20 > I'd rather go the other way, to be honest -- just leave group-1 to -3, > perhaps. I think it's rather unusual to have a that many sub-groups > interactively... It is unusual, as in not so common. But when you do have a complex regexp with many groups, that's exactly when such highlighting can be most useful. I settled on 8 levels, for Isearch+, but that was without any special research into the question. It doesn't hurt, in any way that I'm aware of, to have more rather than less. In the case where many would actually be used (which, as you say, is not usual), a little more time would be needed, but it's likely that in such a complex case there would not be many matches to highlight. I think any time cost of such highlighting is negligible.