From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#33567: Syntactic fontification of diff hunks Date: Thu, 27 Dec 2018 02:45:55 +0200 Message-ID: <60f119f6-f311-3016-38b0-e3c5b64d03f9@yandex.ru> References: <878t18j4is.fsf@mail.linkov.net> <87va475y1m.fsf@mail.linkov.net> <87mupafi73.fsf@mail.linkov.net> <834lbgh3n7.fsf@gnu.org> <87h8fduis0.fsf@mail.linkov.net> <83d0q0dtc0.fsf@gnu.org> <877eg7sq8a.fsf@mail.linkov.net> <47546098-59ef-ae43-878a-fd225b60ec99@yandex.ru> <874lba1n0n.fsf@mail.linkov.net> <87d0pyxtnc.fsf@mail.linkov.net> <532bc1dc-1b44-dc3a-23f0-f96e6d586123@yandex.ru> <09b2c002-1519-61dd-6e8b-2e87794077e2@yandex.ru> <87zht1jjdf.fsf@mail.linkov.net> <75267609-e167-c26e-82e8-d6c2609dbf30@yandex.ru> <8736qrkgel.fsf@mail.linkov.net> <87bm59tkuk.fsf@mail.linkov.net> <32b6a823-e855-7a47-86f4-d2d33fdb2c2b@yandex.ru> <874lazq5e7.fsf@mail.linkov.net> <87ab3c98-a6d0-f66d-9e20-bb002c1de2a4@yandex.ru> <878t0bhlfd.fsf@mail.linkov.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1545871510 23686 195.159.176.226 (27 Dec 2018 00:45:10 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 27 Dec 2018 00:45:10 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:64.0) Gecko/20100101 Thunderbird/64.0 Cc: 33567@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Dec 27 01:45:06 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gcJnN-00064z-Sy for geb-bug-gnu-emacs@m.gmane.org; Thu, 27 Dec 2018 01:45:06 +0100 Original-Received: from localhost ([127.0.0.1]:48880 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gcJpU-00009P-O5 for geb-bug-gnu-emacs@m.gmane.org; Wed, 26 Dec 2018 19:47:16 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:57476) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gcJpM-00007T-2A for bug-gnu-emacs@gnu.org; Wed, 26 Dec 2018 19:47:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gcJpI-0008Aw-Px for bug-gnu-emacs@gnu.org; Wed, 26 Dec 2018 19:47:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:51723) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gcJpI-00089R-CG for bug-gnu-emacs@gnu.org; Wed, 26 Dec 2018 19:47:04 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gcJpI-0007yZ-1p for bug-gnu-emacs@gnu.org; Wed, 26 Dec 2018 19:47:04 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 27 Dec 2018 00:47:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33567 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 33567-submit@debbugs.gnu.org id=B33567.154587156830588 (code B ref 33567); Thu, 27 Dec 2018 00:47:03 +0000 Original-Received: (at 33567) by debbugs.gnu.org; 27 Dec 2018 00:46:08 +0000 Original-Received: from localhost ([127.0.0.1]:38076 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gcJoN-0007xI-Mb for submit@debbugs.gnu.org; Wed, 26 Dec 2018 19:46:07 -0500 Original-Received: from mail-wm1-f50.google.com ([209.85.128.50]:55795) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gcJoL-0007wW-Py for 33567@debbugs.gnu.org; Wed, 26 Dec 2018 19:46:06 -0500 Original-Received: by mail-wm1-f50.google.com with SMTP id y139so15467904wmc.5 for <33567@debbugs.gnu.org>; Wed, 26 Dec 2018 16:46:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=R/apLDkVcgSRyJrbXQo73c3HO0A0OOin8ELtg2x54WI=; b=DkrPF2mGVb+HQdV9mxfLrQ5+2Bi5ZsUI4XERD8uCaxMw3jKvMm7H5b8SZRF6iHi9s3 RKllCb9Q2jx8TGVfplgJSAuItXmfvLvVIBXCuKX6syMKHRFFvMeqiu1hPED+2hbwzooF NFwp+b1FPjeU+3lcpIUFiyiIKqxDz06Vug0qNZXnA9Ut2vOaa5WXr2IvKEdksOG4yhDC gebGu5gtlZTVt7xf1t+kGPjUYUMKJF7H9YbpAfUON2cmUahPADUOWEfAbxIHoybyaimw qWwiOOsOmvSqc3jeyP2ov3bbZ/1slcRDqy55UkE022svWx5zlH0d8k7opU/FRil0N2nG eEFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=R/apLDkVcgSRyJrbXQo73c3HO0A0OOin8ELtg2x54WI=; b=QsCZQ3tUjTjR9O5hskbRbTFsXrlILvi6sJneOAgvl03OS+TkXdsdJqedn5mF5TtZDI Mb3MZb8h8tok7WAS/fYNWRMTyoQwwDilYcfn/d/km0xWJyvJ9ghJmIVb27h9YdSZ4xbj 4o76K8dvUB4DIhxjCBVfIXhINzHVr1kYfVT6VVJAiGMwaQeDw4LBBk4JtksxFAh1lpLD MuRebVTsdsEoyGVNqIst2yB+Z/qccbGTkBz5flbcOYQrydfUovY9MM5gOQhkQCZEbsay AY7/52lTfwdYlA1RR+7unJVteh82Anho8PsQ6iUMr1yBQQZS8jZSIRYHcjIOvVMuiL8t d8rA== X-Gm-Message-State: AA+aEWZptMlnsNuRNClLKduCzl+dGdpOTPPx7jEnuvMQjVLHMCDcDedM UHOkZ0EMzugC1djgLWkzSQUDHcC5 X-Google-Smtp-Source: AFSGD/UzQDScKgQY/eVz1Qon9kOAIKO6p68yoDLSnmiex9Ji9WLvERDi/rEaHG248ZmoSe2eGsMxyQ== X-Received: by 2002:a1c:1b8d:: with SMTP id b135mr19672483wmb.115.1545871559559; Wed, 26 Dec 2018 16:45:59 -0800 (PST) Original-Received: from [192.168.1.3] ([185.105.174.23]) by smtp.googlemail.com with ESMTPSA id v16sm23135374wrs.75.2018.12.26.16.45.57 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 26 Dec 2018 16:45:58 -0800 (PST) In-Reply-To: <878t0bhlfd.fsf@mail.linkov.net> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:153887 Archived-At: On 27.12.2018 2:18, Juri Linkov wrote: > Actually I meant underlines instead of inverse-video. Underlined refinement > looks much better than in inverse-video. OK. But I went to try it out, and looks like underlines don't work on tty. Or at least not on mine. > Also I propose to not use this feature on tty because there is no good > solution how to combine diff foreground colors with syntax foreground colors: *Shrug*, personally I'd leave the config as it is now. The current behavior might still be more useful than simply green or red lines.