From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mauro Aranda Newsgroups: gmane.emacs.bugs Subject: bug#66071: 30.0.50; term-scroll-to-bottom-on-output missing choices Date: Mon, 18 Sep 2023 12:29:30 -0300 Message-ID: <6098e8a4-71bf-19e3-b274-387cca582ab4@gmail.com> References: <147ab958-899e-07cc-f175-52ad2d25e54b@gmail.com> <871qevk1fh.fsf@gmail.com> <53e55fdd-598d-efd3-e3ac-9cc19334b47c@gmail.com> <87wmwnik0q.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17010"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Cc: 66071@debbugs.gnu.org To: Robert Pluim Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Sep 18 17:30:23 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qiGCd-0004Cd-IZ for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 18 Sep 2023 17:30:23 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qiGCD-0001H3-Tj; Mon, 18 Sep 2023 11:29:58 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qiGCB-0001Eb-7R for bug-gnu-emacs@gnu.org; Mon, 18 Sep 2023 11:29:55 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qiGCA-0004av-Dn for bug-gnu-emacs@gnu.org; Mon, 18 Sep 2023 11:29:54 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qiGCI-0000WY-LB for bug-gnu-emacs@gnu.org; Mon, 18 Sep 2023 11:30:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Mauro Aranda Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 18 Sep 2023 15:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66071 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 66071-submit@debbugs.gnu.org id=B66071.16950509951967 (code B ref 66071); Mon, 18 Sep 2023 15:30:02 +0000 Original-Received: (at 66071) by debbugs.gnu.org; 18 Sep 2023 15:29:55 +0000 Original-Received: from localhost ([127.0.0.1]:54116 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qiGCA-0000Vf-P6 for submit@debbugs.gnu.org; Mon, 18 Sep 2023 11:29:55 -0400 Original-Received: from mail-oa1-x36.google.com ([2001:4860:4864:20::36]:55602) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qiGC6-0000VO-3G for 66071@debbugs.gnu.org; Mon, 18 Sep 2023 11:29:53 -0400 Original-Received: by mail-oa1-x36.google.com with SMTP id 586e51a60fabf-1c8e9d75ce1so2358524fac.3 for <66071@debbugs.gnu.org>; Mon, 18 Sep 2023 08:29:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695050976; x=1695655776; darn=debbugs.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=2wbARctrhZlC/MmqLgjYa4KYV/mAkPxGMJ8cqXhMIRo=; b=NyFyRnYQ1hq7V6fLiZ4xJ6sTYFOQtk0ccO92PuTeLdaqY0QLASeASb+afr2kGfqGm3 POuS8UjMaev/6DvkPvsuBpITn6CvXeYQG/jpsaUiOzE6JyzhSZEKqVLy67NuuLcV39Jh unf5/o65ISV9WV9QQXhBr66oN7wZ6YxlRijNy6IfdzQPRUWlVi+hYcyZ4CM/MutMrFdi wBGdDE1cvEAujHRGaA6aktq0ZFEx6EE8IvuheA6A6vDQEYaG4ASw94gnG1rVKUay+zV1 VUCDtahP/MXay8QfVB+8/1OBR1mtNRPdCS/J6LLMQxx2lUjxgnwGOyjVXe8Y6LtNbrmN V8Zw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695050976; x=1695655776; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=2wbARctrhZlC/MmqLgjYa4KYV/mAkPxGMJ8cqXhMIRo=; b=ev8aFLRJ7RXmAQKXd4FRpoiYHx6ehZK2CJ1zsxbnRaqHwksxQxs5MmkNxfo8aZ4iOh cqlhFlMEEc2Kw77fgK3FYdNimdGEdJPtDj5pWXH0iDFs6AIMVSXyDF5dwzu1b8xzCwQk Dfhtx3ZxyF5LdjSv0bUdnfS9awnSJHWTq9t4z+dVAQDKmfAYex314sOTiTrO5bg0l5T/ zBkLK56l+Jw/3G2PrpyjiOYVrmM+aDVgy/hZoQV+N0YwNdagjBDPW9tNHrXHBMXkSW9D 5Gavx1LiSdN2C9InRwRe3kUG/NAhsJ8nIsTcIQeelH92PSwJXq3HIi6XTOclFUKEUsOE a27w== X-Gm-Message-State: AOJu0Yz9Bs+P28Ud1A0G/y/++W6tM99dfkA1qJ/APaDBkAfdpXQG78mV O8Mmg+4ZSDyWLf/vXiAtIY8= X-Google-Smtp-Source: AGHT+IGh0uhsNTLBfL9mvQgiECzuwL0B98xl8qJota90kmTRFdzUL+5XeAbGal03O07SM7+MDkTWsg== X-Received: by 2002:a05:6870:6192:b0:1c8:39a6:77a9 with SMTP id a18-20020a056870619200b001c839a677a9mr9551892oah.31.1695050975846; Mon, 18 Sep 2023 08:29:35 -0700 (PDT) Original-Received: from [192.168.0.234] ([152.168.142.156]) by smtp.gmail.com with ESMTPSA id r21-20020a056870625500b001d4f1ec39b3sm5026011oak.23.2023.09.18.08.29.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 Sep 2023 08:29:35 -0700 (PDT) Content-Language: en-US In-Reply-To: <87wmwnik0q.fsf@gmail.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:270815 Archived-At: On 18/9/23 12:22, Robert Pluim wrote: >>>>>> On Mon, 18 Sep 2023 12:12:41 -0300, Mauro Aranda said: > >     Mauro> On 18/9/23 11:20, Robert Pluim wrote: >     >> On Mon, 18 Sep 2023 09:20:07 -0300, Mauro Aranda >     Mauro>   said: >     >>      Mauro> Patch attached. >     >> >     >>      Mauro> From d891a9f705b3b4af2aedeed645f4636535ea6c2e Mon Sep 17 >     Mauro>  00:00:00 2001 >     >>      Mauro> From: Mauro Aranda >     >>      Mauro> Date: Mon, 18 Sep 2023 09:19:04 -0300 >     >>      Mauro> Subject: [PATCH] Fix term-scroll-to-bottom-on-output >     Mauro>  :type (Bug#66071) >     >> >     >>      Mauro> * lisp/term.el (term-scroll-to-bottom-on-output): Add >     Mauro>  missing choices. >     >>      Mauro> --- >     >>      Mauro>  lisp/term.el | 5 ++++- >     >>      Mauro>  1 file changed, 4 insertions(+), 1 deletion(-) >     >> >     >>      Mauro> diff --git a/lisp/term.el b/lisp/term.el >     >>      Mauro> index b8466b21332..5dd73447cfb 100644 >     >>      Mauro> --- a/lisp/term.el >     >>      Mauro> +++ b/lisp/term.el >     >>      Mauro> @@ -494,7 +494,10 @@ term-scroll-to-bottom-on-output >     >> >     >>      Mauro>  See variable `term-scroll-show-maximum-output'. >     >>      Mauro>  This variable is buffer-local." >     >>      Mauro> -  :type 'boolean >     >>      Mauro> +  :type '(choice (const :tag "Don't scroll" nil) >     >>      Mauro> +                 (const :tag "Scroll selected window >     Mauro>  only" this) >     >>      Mauro> +                 (const :tag "Scroll unselected windows" >     Mauro>  others) >     >>      Mauro> +                 (other :tag "Scroll all windows" t)) >     >>      Mauro>    :group 'term) >     >> >     >> The code (and the docstring) also mention 'all. > >     Mauro> I know, that's why I put other, to catch either t or 'all, since it >     Mauro> doesn't make sense to have 2 different items for the same option. And >     Mauro> adding something to match only t or 'all didn't seem worth the trouble. > >     Mauro> Am I missing something? > > Both before and after your patch, the defcustom and the docstring > disagree. The docstring says 'all', but thatʼs not a value you can get > via customize. > > Personally Iʼd be inclined to delete 'all' from the docstring. People > already using 'all' wonʼt notice, since the code will still recognize > it. That's fine by me, thanks.