From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#24117: 25.1; url-http-create-request: Multibyte text in HTTP request Date: Mon, 8 May 2017 16:36:36 +0300 Message-ID: <605199d2-551d-07c8-71b4-ca73c008246a@yandex.ru> References: <83popsocg8.fsf@gnu.org> <7fb3540a-7b74-68cf-2c63-66474de26640@yandex.ru> <83mvkvmbv2.fsf@gnu.org> <27168f12-32d2-cb38-45c0-27d3339c75aa@yandex.ru> <83twf0lb5s.fsf@gnu.org> <83lh07i6g3.fsf@gnu.org> <83k2fri5kc.fsf@gnu.org> <87oa53i3si.fsf@linux-m68k.org> <83bn13i2x2.fsf@gnu.org> <87fuqfhy0q.fsf@linux-m68k.org> <837fbqise6.fsf@gnu.org> <834m6uhu87.fsf@gnu.org> <65f6508f-a464-7f66-fd14-1372dce86aa7@yandex.ru> <83bn10hetr.fsf@gnu.org> <50426141-3483-e5e4-a252-20b1198cde30@yandex.ru> <874m6rjwdt.fsf_-_@lifelogs.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1494250639 16867 195.159.176.226 (8 May 2017 13:37:19 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 8 May 2017 13:37:19 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:53.0) Gecko/20100101 Thunderbird/53.0 Cc: stakemorii@gmail.com, Lars Magne Ingebrigtsen , schwab@linux-m68k.org, 24117@debbugs.gnu.org To: Ted Zlatanov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon May 08 15:37:11 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d7iqc-0004CK-RM for geb-bug-gnu-emacs@m.gmane.org; Mon, 08 May 2017 15:37:11 +0200 Original-Received: from localhost ([::1]:59577 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d7iqi-0005jO-6x for geb-bug-gnu-emacs@m.gmane.org; Mon, 08 May 2017 09:37:16 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50788) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d7iqY-0005f9-5W for bug-gnu-emacs@gnu.org; Mon, 08 May 2017 09:37:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d7iqU-0000cB-5m for bug-gnu-emacs@gnu.org; Mon, 08 May 2017 09:37:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:34884) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1d7iqU-0000c6-2O for bug-gnu-emacs@gnu.org; Mon, 08 May 2017 09:37:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1d7iqT-0004e1-Lb for bug-gnu-emacs@gnu.org; Mon, 08 May 2017 09:37:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 08 May 2017 13:37:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24117 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 24117-submit@debbugs.gnu.org id=B24117.149425060617831 (code B ref 24117); Mon, 08 May 2017 13:37:01 +0000 Original-Received: (at 24117) by debbugs.gnu.org; 8 May 2017 13:36:46 +0000 Original-Received: from localhost ([127.0.0.1]:33083 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d7iqE-0004dX-Bc for submit@debbugs.gnu.org; Mon, 08 May 2017 09:36:46 -0400 Original-Received: from mail-wm0-f65.google.com ([74.125.82.65]:33890) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d7iqC-0004dK-9T for 24117@debbugs.gnu.org; Mon, 08 May 2017 09:36:44 -0400 Original-Received: by mail-wm0-f65.google.com with SMTP id d127so7167407wmf.1 for <24117@debbugs.gnu.org>; Mon, 08 May 2017 06:36:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=X+mDAlHWCkUnEpHKdzSXYMpUtfi9NDX3nHVlbfBh3p0=; b=rBwiNF1vZPuILaZH0Ymm5l5NCuzXVcU+2dw2xRDFH0fMVCSzApOPsnm4qBozh4+uqy fT590LsL37p2NqV/xCykCIixJEMaHfuJg5a3vvueqDUZKq4QoLo6CHdEQ+dBrvjOmmXS XRciyxmHl9VYg4eYXvpwBub8kqkl85lrc44gjTSoqXwiXL7hIU5hVUYpcwLiqlcrhaVb 9BnDs45yeUWSqEb9hZ7tG9v06WN2m96mIiKhfhMrc2rNhEHwuyyAeml+Tg6DRlGCQlN2 Z6xSMB5jlw647xQYqntXUjuZ6NLitwEqF2fTPuFlW759rZeR9XPFEBYBeIqaOUunrlut Ngrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=X+mDAlHWCkUnEpHKdzSXYMpUtfi9NDX3nHVlbfBh3p0=; b=izuqLcjNbVk9LCvGtZHIoMFXfRQxoCpIULpPZrSX2U5I5smUNTsZMPQA0cuy67ww05 UqLuxmmoq4v64JzysjNpGY5oGSZ+LNwxuN6sAqBEnrAXhTp2/wrL0tI5JG1bODHIxcDV M+TmGvH+Y+TkNDPCTPKyGIhDrH9v/zjlWKuAIFnw5n2/gwfUU8i1+axDJ8qON1jiFtgV 51Pqbt9gCtSm4+Uqa4KUrqUiIhLCgKRNjwTtHIFv/lJBGZfTuHcx3PtYfcgXBp/ySVte LBcUqHSnQrOIrky1S4H/ihxzjUWW+fFpF3Ey8Lw6zlLbYhOWPFCa8g4jnT/ydhDOPCWb B2dQ== X-Gm-Message-State: AN3rC/4ukFk2iZKfuUWGpkBAWxRNJ247v+3/k+L/fUlfRqPw+N4ww+mo WHvVk9bsvx/Wm89Odcs= X-Received: by 10.28.31.135 with SMTP id f129mr12649806wmf.78.1494250598566; Mon, 08 May 2017 06:36:38 -0700 (PDT) Original-Received: from [192.168.0.133] ([212.50.99.193]) by smtp.googlemail.com with ESMTPSA id q140sm11857660wmb.14.2017.05.08.06.36.36 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 08 May 2017 06:36:37 -0700 (PDT) In-Reply-To: <874m6rjwdt.fsf_-_@lifelogs.com> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:132372 Archived-At: On 11.08.2016 15:57, Ted Zlatanov wrote: > DG> On 08/11/2016 11:53 AM, Ted Zlatanov wrote: >>> Could you add to your patch the cases you've tested? There's a specific >>> place for URL parsing tests in test/lisp/url/url-parse-tests.el that >>> would help everyone. > > DG> Sure, but only one of the patches affects URL parsing (and Lars prefers the > DG> other one). > > Maybe the tests should be in a separate patch then. Neither your Russian > example nor Lars' example have a parallel in the tests AFAICS. I'd also > add the example hostname that Katsumi Yamaoka gave from the w3m source. Just got around to this. The test I came up with looks like this: (ert-deftest url-generic-parse-url/multibyte-host-and-path () (should (equal (url-generic-parse-url "http://банки.рф/фыва/") (url-parse-make-urlobj "http" nil nil "банки.рф" nil "/фыва/" nil nil t)))) But! What behavior would this test? If we're making sure here that url-generic-parse-url can cope with multibyte characters anywhere in the URL, the encode-coding-string/decode-coding-string logic in url-encode-url is extraneous. I'm not sure that it is, or is there are some edge cases (are they fixable? should we add tests for them?). So if this test goes in, it should be accompanied with the simplification of url-encode-url. Lars, what do you think?