From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.bugs Subject: bug#66988: 30.0.50; treesit-forward-sexp not working properly in js-ts-mode and tsx-ts-mode Date: Sat, 18 Nov 2023 10:57:56 -0800 Message-ID: <6042B192-0400-48E4-9290-940E019B01E3@gmail.com> References: <9cf7d7d0-33a3-4c07-bd66-bc4c59bdfefb@gmail.com> <39b0057b-ac0c-8271-0fe2-f4deef7ae8d3@gutov.dev> <83zfzkwxlv.fsf@gnu.org> <1C21FE6B-D54E-4301-AB87-5F15EE06D7D1@gmail.com> <83cywbryxi.fsf@gnu.org> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.700.6\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5474"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Dmitry Gutov , 66988@debbugs.gnu.org, Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= , Theodor Thornhill , =?UTF-8?Q?Lo=C3=AFc_?= =?UTF-8?Q?Lema=C3=AEtre?= To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Nov 18 19:59:32 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r4QXT-0001FY-7l for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 18 Nov 2023 19:59:31 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r4QX2-000697-Kl; Sat, 18 Nov 2023 13:59:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r4QWz-00068l-Pd for bug-gnu-emacs@gnu.org; Sat, 18 Nov 2023 13:59:02 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r4QWy-00076V-UF for bug-gnu-emacs@gnu.org; Sat, 18 Nov 2023 13:59:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1r4QWz-0000xu-SF for bug-gnu-emacs@gnu.org; Sat, 18 Nov 2023 13:59:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Yuan Fu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 18 Nov 2023 18:59:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66988 X-GNU-PR-Package: emacs Original-Received: via spool by 66988-submit@debbugs.gnu.org id=B66988.17003338993653 (code B ref 66988); Sat, 18 Nov 2023 18:59:01 +0000 Original-Received: (at 66988) by debbugs.gnu.org; 18 Nov 2023 18:58:19 +0000 Original-Received: from localhost ([127.0.0.1]:49525 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r4QWI-0000wr-RS for submit@debbugs.gnu.org; Sat, 18 Nov 2023 13:58:19 -0500 Original-Received: from mail-oa1-x31.google.com ([2001:4860:4864:20::31]:51213) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r4QWF-0000wb-JK for 66988@debbugs.gnu.org; Sat, 18 Nov 2023 13:58:17 -0500 Original-Received: by mail-oa1-x31.google.com with SMTP id 586e51a60fabf-1efad296d42so1751586fac.2 for <66988@debbugs.gnu.org>; Sat, 18 Nov 2023 10:58:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700333889; x=1700938689; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=+q+BGbuwY6KgMHxzzy3Nf+XUkcCzl9Fv9tqaB29VeWM=; b=mC3FKX+OLJibEjVYIpn2H3ApQQnNG3OOH2wvtAI8GPDdBzy0OEZDGcUmIM7q5kLW7n DB/x6hWYLKuy/DQqeUpnJUNuvXFkVLXYyiJT6NliEgyqiqT6GPLZuXr9ZZyNApzE8EaU +xUYrS5b13nx9wvGMlq4J2JOuzRAve6tJbN6h/98c63sWCqIrF/bSf3Tv4ChLrR5lKUF GKcTXYnuVVHlw6Mko6JF4kW8nl0UrZpr+7at1XNfqXw4VzN6bicOBL8EHJLrNlzWAzHL Xb8CbmLuRm8hAZ5crGsR4kbPl+adiWsOHMmM7vj3dS5r+gKHwhgxzJyD2PFqz7MUUYdT 9MPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700333889; x=1700938689; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+q+BGbuwY6KgMHxzzy3Nf+XUkcCzl9Fv9tqaB29VeWM=; b=iQnEGbXIHs80huRItTZ25DAJSh2BeYOkX9I4L62NH0qPSen0GaYTLo2BMXatMMOfhg yvSFXKKMGxL7tr/+UtJAOmspQ7tUdKTULoN96qGb5HQ3b+790jRsxRW0RfBZXOE24YB1 ThujvSEJtRRQ96ZaILd3yx8qposBrVMXYlm7u/UHOLuwQOxPAzZ6xDXNAzPCM3nA0ZkN pZtHdgyd8DjqKWelW/mERt4KPeHs4+CePn2CaZiRbvL6FMHJU4MbuPMt8/erbK7jHZkn atq9XkD/Wx9HNBELDuN3+/CS002OhOfsuqUM36XRM5m3oe5SondsmirU0JNh3EI5zmuX sqoQ== X-Gm-Message-State: AOJu0YwgRw7wBOBoReF6OzSlT5ETEboprW2Y9wFoOOuBwETSHWaWv+RT OqW4x6UD0LXH0+6fEQ1E5DE= X-Google-Smtp-Source: AGHT+IH2++Uylmc49fDfWhkd+U6LUxGKos6h17IeKcMeB/+ozVGUV83IFOS2FG3JTC1KCs3WqxGZVA== X-Received: by 2002:a05:6870:aa85:b0:1e9:a713:7ad6 with SMTP id gr5-20020a056870aa8500b001e9a7137ad6mr3459095oab.44.1700333888802; Sat, 18 Nov 2023 10:58:08 -0800 (PST) Original-Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id 7-20020a17090a01c700b0027d0a60b9c9sm5556417pjd.28.2023.11.18.10.58.07 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 18 Nov 2023 10:58:08 -0800 (PST) In-Reply-To: <83cywbryxi.fsf@gnu.org> X-Mailer: Apple Mail (2.3731.700.6) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:274568 Archived-At: > On Nov 15, 2023, at 4:19 AM, Eli Zaretskii wrote: >=20 >> From: Yuan Fu >> Date: Tue, 14 Nov 2023 22:28:34 -0800 >> Cc: Dmitry Gutov , >> Theodor Thornhill , >> 66988@debbugs.gnu.org, >> loic.lemaitre@gmail.com >>=20 >>> Is it feasible to have a variable that controls whether the full >>> matches are implied in these APIs? Then we could start by making it >>> optional, and at some later time make it the default. >>=20 >> It=E2=80=99s feasible, but I don=E2=80=99t think it=E2=80=99s TRT. = The major mode author should have the control over whether the full = match is implied, not the user. It doesn=E2=80=99t make sense to toggle = the variable either. If you change that variable, major mode code must = also change to be correct. >=20 > So what do you suggest that we do about this issue? We change every treesit function that takes a regexp for matching node = type names to imply full match. I think most people wrote code as if = these functions use full match, so the breakage should be small. And I = can forecast this change in as many channels as I can. Yuan=