From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mauro Aranda Newsgroups: gmane.emacs.bugs Subject: bug#45068: [PATCH] 28.0.50; Update Modus themes 1.0.2 (backward-incompatible) Date: Thu, 04 Mar 2021 19:06:57 -0300 Message-ID: <60415a04.1c69fb81.63f7a.3bc2@mx.google.com> References: <87im9fgm27.fsf@protesilaos.com> <87h7m0n0em.fsf@protesilaos.com> <83v9agryuz.fsf@gnu.org> <87tupyw83e.fsf@protesilaos.com> <83zgzqncxx.fsf@gnu.org> <874khwn1qf.fsf@protesilaos.com> <603b8171.1c69fb81.aa664.7f40@mx.google.com> <87mtvoxsvs.fsf@protesilaos.com> <603b9b9d.1c69fb81.f37aa.cb7c@mx.google.com> <83eegz7xcx.fsf@gnu.org> <87o8g3exjv.fsf@protesilaos.com> <603d053a.1c69fb81.f4cb8.fb14@mx.google.com> <87h7luga3p.fsf@protesilaos.com> <87o8g2bg89.fsf@tcd.ie> <87r1kyrtrl.fsf@protesilaos.com> <878s75x2uk.fsf@tcd.ie> <87o8g0ryfz.fsf@tcd.ie> <6040d37e.1c69fb81.63467.ad62@mx.google.com> <87wnun9dgo.fsf_-_@protesilaos.com> <87ft1aoj74.fsf@tcd.ie> <87eeguab7o.fsf@protesilaos.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28632"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1.50 (gnu/linux) Cc: "Basil L. Contovounesios" , 45068@debbugs.gnu.org To: Protesilaos Stavrou Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Mar 04 23:08:14 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lHw8k-0007Mi-0h for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 04 Mar 2021 23:08:14 +0100 Original-Received: from localhost ([::1]:49504 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lHw8j-0002dv-11 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 04 Mar 2021 17:08:13 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52308) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lHw8Z-0002dm-QY for bug-gnu-emacs@gnu.org; Thu, 04 Mar 2021 17:08:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48999) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lHw8Y-0003wG-Ey for bug-gnu-emacs@gnu.org; Thu, 04 Mar 2021 17:08:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lHw8Y-00014o-9q for bug-gnu-emacs@gnu.org; Thu, 04 Mar 2021 17:08:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Mauro Aranda Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 04 Mar 2021 22:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45068 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 45068-submit@debbugs.gnu.org id=B45068.16148956294075 (code B ref 45068); Thu, 04 Mar 2021 22:08:02 +0000 Original-Received: (at 45068) by debbugs.gnu.org; 4 Mar 2021 22:07:09 +0000 Original-Received: from localhost ([127.0.0.1]:60545 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lHw7h-00013f-1g for submit@debbugs.gnu.org; Thu, 04 Mar 2021 17:07:09 -0500 Original-Received: from mail-qk1-f171.google.com ([209.85.222.171]:33575) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lHw7f-00013F-6Q for 45068@debbugs.gnu.org; Thu, 04 Mar 2021 17:07:08 -0500 Original-Received: by mail-qk1-f171.google.com with SMTP id l4so50244qkl.0 for <45068@debbugs.gnu.org>; Thu, 04 Mar 2021 14:07:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=message-id:from:to:cc:subject:references:date:in-reply-to :user-agent:mime-version; bh=rdBeZZdpn8M6/xmlB5rp+r9n2Y0MEwX0nLMAbnKja/A=; b=nd/W60mWl/GCwXS0iTjDGr1gav6gs8TjwutvIUVcP4U++prjW6bZZT+L7KjyXUXqnu 5EllkC+Ta7ausfwskq3S9OApZ3G0yQDv1YMsOfqEbHIObyjFiXpdAqbDq0dMYiMYFKkF 8yKB1+6iJtWdLxCkrAMsovzeYh2yRrDRksxBrBy47/zOcNPfSj97yG0jHUUqAo8KvJpy baz1GW6MlfTZmEoVpRKH2GibJnfXksoh3Ob5M3SGtTqnNFKcwSfq9jBMv8QkNrwmFjRz u9LCi/kqEK2E2YWZp9R5xVnrwgP7uDcqyeMO3kEOX5+nl8lQb6/MQjmthQ+O+hX1mYNO u+zw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:from:to:cc:subject:references:date :in-reply-to:user-agent:mime-version; bh=rdBeZZdpn8M6/xmlB5rp+r9n2Y0MEwX0nLMAbnKja/A=; b=UkM8Re9HgN6HQx4aGWOb5JVp5Qpxe1DzylbJJYcOu1y133Us1smKGugnAEn0U0qbov dmyDFXuVbTpXmsEqlYYwXGA6YknroSjql85L2mAi4XMDccKKwsM27xEF3dJCbcYkfiwL N3KK9Gz2FtMhS1vSHljautBUmuf7qOrmK2G8FtyqbBc8w6jRhqCHToZ1QUCqiZuf1nEo 2tUW1QKkGttgUPeFG19MP0d95Y0mf/Z7fLIgisa+mv/PPXcLmmzzmRZ4pct4wB9qx5B4 t6TB7XLfkmasVEMiIzUpEI1v0fyBgNw3nGhCR9LMkMNzgfv6tHaqZUfHG1AXAKvQSexx Jtmw== X-Gm-Message-State: AOAM530GVrb2YulIsUhsY38R4Pd6F7qaGA0RbFb2jN1QMo1p9wVjmi9s swtxkUvBVy1qz4vxjeiVOZvGc5XkQNCDfZ8K X-Google-Smtp-Source: ABdhPJwcAiru55VYJGj/Gz04H6SpZLhlvtZfTQycIc4VCoTPw8y47M2WqX9JEhzo7xs8YHlF0qV3uA== X-Received: by 2002:a37:6197:: with SMTP id v145mr6383457qkb.227.1614895621466; Thu, 04 Mar 2021 14:07:01 -0800 (PST) Original-Received: from tbb-desktop ([201.213.132.172]) by smtp.gmail.com with ESMTPSA id o7sm481698qkb.104.2021.03.04.14.06.59 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 04 Mar 2021 14:07:00 -0800 (PST) X-Google-Original-Message-ID: <87a6rir2ta.fsf_-_@maurooaranda@gmail.com> In-Reply-To: <87eeguab7o.fsf@protesilaos.com> (Protesilaos Stavrou's message of "Thu, 04 Mar 2021 22:57:31 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:201483 Archived-At: Protesilaos Stavrou writes: > On 2021-03-04, 13:53 -0300, Mauro Aranda wrote: > >>> ;;;###autoload >>> (when (and (boundp 'custom-theme-load-path) load-file-name) >>> (add-to-list 'custom-theme-load-path >>> (file-name-as-directory (file-name-directory load-file-name)))) >> >> A nit: I think this code should avoid adding the value of >> custom-theme-directory or the built-in theme directory name to >> custom-theme-load-path , if `custom-theme-directory' (for the former) or >> t (for the latter) are already present in custom-theme-load-path. In >> particular, a theme distributed with Emacs should at least check for t, >> to avoid a repeated entry. >> >> I've noticed that the leuven theme has a similar code as well: I think >> that is a (really minor) bug. > > I have removed that form altogether. It makes sense for packages but > here they are safe themes. Is that okay, or have I misunderstood > something? Sounds OK to me; for themes that are only distributed with Emacs, it doesn't seem to be needed. But if you plan to keep distributing them as packages via ELPA, then it might make sense to keep it. I don't know what's the plan, so I can't say for sure if the form should stay or not. > Thanks again! Thanks to you!