From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mauro Aranda Newsgroups: gmane.emacs.bugs Subject: bug#45068: [PATCH] 28.0.50; Update Modus themes 1.0.2 (backward-incompatible) Date: Thu, 04 Mar 2021 13:53:04 -0300 Message-ID: <60411073.1c69fb81.81b21.cec2@mx.google.com> References: <87im9fgm27.fsf@protesilaos.com> <87sg6po0yd.fsf_-_@protesilaos.com> <83czxt2fpd.fsf@gnu.org> <87h7m0n0em.fsf@protesilaos.com> <83v9agryuz.fsf@gnu.org> <87tupyw83e.fsf@protesilaos.com> <83zgzqncxx.fsf@gnu.org> <874khwn1qf.fsf@protesilaos.com> <603b8171.1c69fb81.aa664.7f40@mx.google.com> <87mtvoxsvs.fsf@protesilaos.com> <603b9b9d.1c69fb81.f37aa.cb7c@mx.google.com> <83eegz7xcx.fsf@gnu.org> <87o8g3exjv.fsf@protesilaos.com> <603d053a.1c69fb81.f4cb8.fb14@mx.google.com> <87h7luga3p.fsf@protesilaos.com> <87o8g2bg89.fsf@tcd.ie> <87r1kyrtrl.fsf@protesilaos.com> <878s75x2uk.fsf@tcd.ie> <87o8g0ryfz.fsf@tcd.ie> <6040d37e.1c69fb81.63467.ad62@mx.google.com> <87wnun9dgo.fsf_-_@protesilaos.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14711"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: "Basil L. Contovounesios" , 45068@debbugs.gnu.org To: Protesilaos Stavrou Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Mar 04 17:54:34 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lHrFA-0003cj-6j for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 04 Mar 2021 17:54:32 +0100 Original-Received: from localhost ([::1]:54764 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lHrF9-0005re-8C for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 04 Mar 2021 11:54:31 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39430) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lHrEg-0005RQ-Bg for bug-gnu-emacs@gnu.org; Thu, 04 Mar 2021 11:54:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48484) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lHrEg-0007Av-4G for bug-gnu-emacs@gnu.org; Thu, 04 Mar 2021 11:54:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lHrEg-0001ef-3l for bug-gnu-emacs@gnu.org; Thu, 04 Mar 2021 11:54:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Mauro Aranda Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 04 Mar 2021 16:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45068 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 45068-submit@debbugs.gnu.org id=B45068.16148767976285 (code B ref 45068); Thu, 04 Mar 2021 16:54:02 +0000 Original-Received: (at 45068) by debbugs.gnu.org; 4 Mar 2021 16:53:17 +0000 Original-Received: from localhost ([127.0.0.1]:60026 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lHrDw-0001dJ-N0 for submit@debbugs.gnu.org; Thu, 04 Mar 2021 11:53:16 -0500 Original-Received: from mail-qt1-f177.google.com ([209.85.160.177]:45496) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lHrDu-0001d5-K4 for 45068@debbugs.gnu.org; Thu, 04 Mar 2021 11:53:15 -0500 Original-Received: by mail-qt1-f177.google.com with SMTP id j3so5204718qtj.12 for <45068@debbugs.gnu.org>; Thu, 04 Mar 2021 08:53:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=message-id:from:to:cc:subject:references:date:in-reply-to :user-agent:mime-version; bh=vticDxvEwyXtFvyz82C+adOrqcxFSb6UmqrHowr3mdw=; b=oL6+lquPwFynJL+hvrsJUDNLdaGRQh8GR1GUytbqlhD1LVN3w5tlKd6hRt3q+FF9G5 VjZJKBCYLP1h0TmfYjlQnRitl10kPZrkHIK/gzYZMnrJZV9JJ0ySC1QPOB79HmE+OEKB IALGO3n0g2bYe0uwTa9q9kKA2sc3mCSffEcwwZUZrZvIMhw2Vmgdvh+towE7lE9QIzCN BVNKsPdhlGFPAwrb+SoPMd3tamh74UwyDRJh+z/poG5Awm6sJIgrg3wWghLPeLl/pT7f Qiz4k7s77hX9rTQ1glxeJ9B/imJx87EC2sFUqDOTibr6ZBmbCLufB+KU+N5eRiAdjkqS 4Wzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:from:to:cc:subject:references:date :in-reply-to:user-agent:mime-version; bh=vticDxvEwyXtFvyz82C+adOrqcxFSb6UmqrHowr3mdw=; b=ZW3u+ONROMHG5VaH58qZBezHSFGu2llUU7F+Ax7+dc5Vji/hmRcPfVRfHfoa3jhGYN SGpgiktdPeia1pbqg57oiN9mdIftCMz4nKMSyWawFG3Le5EcpUk5+B0pRVEAxhdyCLU9 rDjvzNqViQzKVHvHX3jpXDOR3FyC0osGOs8gNMhNs+9Oarwt4fNMXXn3rMK0QF283gWh astU/k+K9f0igfYojnxfH3YNeRoAR5ZBu/wwRoDcEgZWoWAs3StDygVmEmNZI1IaXGPb MNzugdRL90vW+inLUTu9/Q1izfOj5ythXfJLeQdCGlhWc8Rei235h9lF8xNWJfXKvd62 xP6g== X-Gm-Message-State: AOAM532kI0JCER939lPf9m8fCffmA6lc1qnup6ugRF4KUwIbrdbMDTt/ R/pdOgRVxMQlXE7oAODtMIbxRWeFOfvs7+Ty X-Google-Smtp-Source: ABdhPJzliokd43h65RGpoLMwgrHVsqca9J0eoUUqdo9UqzNuka9Gb6w3swJs38+2KeVewd6tuN8u2w== X-Received: by 2002:ac8:6687:: with SMTP id d7mr5046466qtp.326.1614876788643; Thu, 04 Mar 2021 08:53:08 -0800 (PST) Original-Received: from tbb-desktop ([201.213.132.172]) by smtp.gmail.com with ESMTPSA id n23sm19926708qkg.25.2021.03.04.08.53.06 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 04 Mar 2021 08:53:07 -0800 (PST) X-Google-Original-Message-ID: <87sg5aq2rz.fsf_-_@maurooaranda@gmail.com> In-Reply-To: <87wnun9dgo.fsf_-_@protesilaos.com> (Protesilaos Stavrou's message of "Thu, 04 Mar 2021 16:54:15 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:201411 Archived-At: Hi Protesilaos, Protesilaos Stavrou writes: > Hello again! > > As noted earlier, please find attached the patch that upgrades the > themes to their newest version 1.2.0. I tested it with Basil's latest > patch for 'require-theme', though it still works with the variant of > that function currently in trunk. [...] > ;;;###autoload > (when (and (boundp 'custom-theme-load-path) load-file-name) > (add-to-list 'custom-theme-load-path > (file-name-as-directory (file-name-directory load-file-name)))) A nit: I think this code should avoid adding the value of custom-theme-directory or the built-in theme directory name to custom-theme-load-path , if `custom-theme-directory' (for the former) or t (for the latter) are already present in custom-theme-load-path. In particular, a theme distributed with Emacs should at least check for t, to avoid a repeated entry. I've noticed that the leuven theme has a similar code as well: I think that is a (really minor) bug.