unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#2873: Keybinding info for remapped commands could be more useful
@ 2009-04-03  8:11 Nikolaj Schumacher
  2009-04-03 14:12 ` Drew Adams
  0 siblings, 1 reply; 6+ messages in thread
From: Nikolaj Schumacher @ 2009-04-03  8:11 UTC (permalink / raw)
  To: bug-gnu-emacs

When using a command, Emacs conveniently flashes the keybinding.

For remapped commands, the message is not as useful:
  You can run the command `command' with <remap> <original-command>

It would probably be better to offer the binding of original-command
instead.

regards,
Nikolaj Schumacher







^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#2873: Keybinding info for remapped commands could be more useful
  2009-04-03  8:11 bug#2873: Keybinding info for remapped commands could be more useful Nikolaj Schumacher
@ 2009-04-03 14:12 ` Drew Adams
  2009-04-03 21:31   ` Stefan Monnier
  0 siblings, 1 reply; 6+ messages in thread
From: Drew Adams @ 2009-04-03 14:12 UTC (permalink / raw)
  To: 'Nikolaj Schumacher', 2873, bug-gnu-emacs

> When using a command, Emacs conveniently flashes the keybinding.
> For remapped commands, the message is not as useful:
>   You can run the command `command' with <remap> <original-command>
> 
> It would probably be better to offer the binding of original-command
> instead.

Sounds related to bug #788, which mentioned the same problem for key mentions in
menu items.







^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#2873: Keybinding info for remapped commands could be more useful
  2009-04-03 14:12 ` Drew Adams
@ 2009-04-03 21:31   ` Stefan Monnier
  2009-04-03 21:58     ` Drew Adams
  2011-10-05  6:38     ` Glenn Morris
  0 siblings, 2 replies; 6+ messages in thread
From: Stefan Monnier @ 2009-04-03 21:31 UTC (permalink / raw)
  To: Drew Adams; +Cc: 2873, bug-gnu-emacs, 'Nikolaj Schumacher'

>> When using a command, Emacs conveniently flashes the keybinding.
>> For remapped commands, the message is not as useful:
>> You can run the command `command' with <remap> <original-command>
>> 
>> It would probably be better to offer the binding of original-command
>> instead.

> Sounds related to bug #788, which mentioned the same problem for key mentions in
> menu items.

Indeed.  Back then I suggested to move the fix into where-is-internal
and this bug report seems to show that it would indeed be a good idea.


        Stefan










^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#2873: Keybinding info for remapped commands could be more useful
  2009-04-03 21:31   ` Stefan Monnier
@ 2009-04-03 21:58     ` Drew Adams
  2009-04-24 17:04       ` Drew Adams
  2011-10-05  6:38     ` Glenn Morris
  1 sibling, 1 reply; 6+ messages in thread
From: Drew Adams @ 2009-04-03 21:58 UTC (permalink / raw)
  To: 'Stefan Monnier'
  Cc: 2873, bug-gnu-emacs, 'Nikolaj Schumacher'

> >> When using a command, Emacs conveniently flashes the keybinding.
> >> For remapped commands, the message is not as useful:
> >> You can run the command `command' with <remap> <original-command>
> >> 
> >> It would probably be better to offer the binding of 
> >> original-command instead.
> 
> > Sounds related to bug #788, which mentioned the same 
> > problem for key mentions in menu items.
> 
> Indeed.  Back then I suggested to move the fix into where-is-internal
> and this bug report seems to show that it would indeed be a good idea.

Yidong recently made a temporary fix of #788: removing the key mention from such
menu items. If and when the bug gets fixed properly, we need to remember to
revert that temporary fix, so such keys will appear again (but properly) in menu
items. 

Dunno how you note such things so they aren't forgotten later - perhaps a
comment in the code?







^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#2873: Keybinding info for remapped commands could be more useful
  2009-04-03 21:58     ` Drew Adams
@ 2009-04-24 17:04       ` Drew Adams
  0 siblings, 0 replies; 6+ messages in thread
From: Drew Adams @ 2009-04-24 17:04 UTC (permalink / raw)
  To: 2873, 'Stefan Monnier'
  Cc: bug-gnu-emacs, 'Nikolaj Schumacher'

> > >> When using a command, Emacs conveniently flashes the keybinding.
> > >> For remapped commands, the message is not as useful:
> > >> You can run the command `command' with <remap> <original-command>
> > >> 
> > >> It would probably be better to offer the binding of 
> > >> original-command instead.
> > 
> > > Sounds related to bug #788, which mentioned the same 
> > > problem for key mentions in menu items.
> > 
> > Indeed.  Back then I suggested to move the fix into 
> > where-is-internal and this bug report seems to show that
> > it would indeed be a good idea.
> 
> Yidong recently made a temporary fix of #788: removing the 
> key mention from such menu items. If and when the bug gets
> fixed properly, we need to remember to revert that temporary
> fix, so such keys will appear again (but properly) in menu
> items. 

BTW, somehow we already DTRT for `C-h f bar', for a command `bar' that is
remapped from command `foo'. The key bindings mentioned for `bar' are correct -
it doesn't just say that `bar' is remapped from `foo'.








^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#2873: Keybinding info for remapped commands could be more useful
  2009-04-03 21:31   ` Stefan Monnier
  2009-04-03 21:58     ` Drew Adams
@ 2011-10-05  6:38     ` Glenn Morris
  1 sibling, 0 replies; 6+ messages in thread
From: Glenn Morris @ 2011-10-05  6:38 UTC (permalink / raw)
  To: 2873-done

Version: 23.2

Looks like this was fixed in Emacs 23.2.





^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2011-10-05  6:38 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-04-03  8:11 bug#2873: Keybinding info for remapped commands could be more useful Nikolaj Schumacher
2009-04-03 14:12 ` Drew Adams
2009-04-03 21:31   ` Stefan Monnier
2009-04-03 21:58     ` Drew Adams
2009-04-24 17:04       ` Drew Adams
2011-10-05  6:38     ` Glenn Morris

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).