From mboxrd@z Thu Jan  1 00:00:00 1970
Path: main.gmane.org!not-for-mail
From: "Stefan Monnier" <monnier+gnu.emacs.bug/news/@RUM.cs.yale.edu>
Newsgroups: gmane.emacs.bugs
Subject: Re: file-expand-wildcards should use `save-match-data'
Date: 28 Mar 2002 09:47:45 -0500
Sender: bug-gnu-emacs-admin@gnu.org
Message-ID: <5l4rj0eoku.fsf@rum.cs.yale.edu>
References: <200203252227.RAA16968@meoptiplex.lcs.mit.edu> <20020326100210.7E7C.LEKTU@terra.es> <200203280456.g2S4uYu09596@aztec.santafe.edu>
NNTP-Posting-Host: localhost.gmane.org
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Trace: main.gmane.org 1017805371 12551 127.0.0.1 (3 Apr 2002 03:42:51 GMT)
X-Complaints-To: usenet@main.gmane.org
NNTP-Posting-Date: Wed, 3 Apr 2002 03:42:51 +0000 (UTC)
Original-Received: from fencepost.gnu.org ([199.232.76.164])
	by main.gmane.org with esmtp (Exim 3.33 #1 (Debian))
	id 16sbfe-0003GK-00
	for <gnu-bug-gnu-emacs@m.gmane.org>; Wed, 03 Apr 2002 05:42:50 +0200
Original-Received: from localhost ([127.0.0.1] helo=fencepost.gnu.org)
	by fencepost.gnu.org with esmtp (Exim 3.34 #1 (Debian))
	id 16sbZa-00007J-00; Tue, 02 Apr 2002 22:36:34 -0500
Original-Received: from dimail.epfl.ch ([128.178.79.31])
	by fencepost.gnu.org with esmtp (Exim 3.34 #1 (Debian))
	id 16sbXE-0008Bl-00
	for <gnu-emacs-bug@gnu.org>; Tue, 02 Apr 2002 22:34:08 -0500
Original-Received: from dinews.epfl.ch (news@disunds1 [128.178.79.23])
	by dimail.epfl.ch (8.8.X/EPFL-8.1g) with SMTP id FAA28398
	for <gnu-emacs-bug@gnu.org>; Wed, 3 Apr 2002 05:34:07 +0200 (MET DST)
Original-To: gnu-emacs-bug@gnu.org
Original-Newsgroups: gnu.emacs.bug
Original-Lines: 20
User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.2.50
X-Original-NNTP-Posting-Host: rum.cs.yale.edu
X-Original-Trace: 28 Mar 2002 09:47:45 -0500, rum.cs.yale.edu
Original-Path: rum.cs.yale.edu!rum.cs.yale.edu
Original-NNTP-Posting-Host: liasun13.epfl.ch
X-Original-NNTP-Posting-Host: liasun13.epfl.ch
Original-X-Trace: 3 Apr 2002 05:33:48 +0100, liasun13.epfl.ch
Errors-To: bug-gnu-emacs-admin@gnu.org
X-BeenThere: bug-gnu-emacs@gnu.org
X-Mailman-Version: 2.0.8
Precedence: bulk
List-Help: <mailto:bug-gnu-emacs-request@gnu.org?subject=help>
List-Post: <mailto:bug-gnu-emacs@gnu.org>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/bug-gnu-emacs>,
	<mailto:bug-gnu-emacs-request@gnu.org?subject=subscribe>
List-Id: Bug reports for GNU Emacs,
	the Swiss army knife of text editors <bug-gnu-emacs.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/bug-gnu-emacs>,
	<mailto:bug-gnu-emacs-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/bug-gnu-emacs/>
Xref: main.gmane.org gmane.emacs.bugs:372
X-Report-Spam: http://spam.gmane.org/gmane.emacs.bugs:372

>>>>> "Richard" == Richard Stallman <rms@gnu.org> writes:
> file-expand-wildcards is a general-purpose facility,
> and regexp matching is not its job, so I think it should
> use save-match-data.

I'm not sure what the criterion should be, and I don't really care
if file-expand-wildcards saves match-data or not, but it does
seem that file-expand-wildcards is rarely used (more specifically,
it's used twice in emacs/lisp/* plus one comment in complete.el
saying that it could now be used there) and more importantly that
few code if any would do

    match...file-expand-wildcards...use match-data

So I'd be interested to know Michael Ernst's code that broke because
of file-expand-wildcards not saving match-data.


	Stefan