unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Glenn Morris <rgm@gnu.org>
To: John <jpff@codemist.co.uk>
Cc: 34252@debbugs.gnu.org
Subject: bug#34252: 27.0.50; rmail-get-new-mail fails
Date: Tue, 29 Jan 2019 19:34:46 -0500	[thread overview]
Message-ID: <5k1in9e55.fsf@fencepost.gnu.org> (raw)
In-Reply-To: <8106-Tue29Jan2019205719+0000-jpff@codemist.co.uk> (John's message of "Tue, 29 Jan 2019 20:57:19 +0000")

John wrote:

> in case of reading a mail box on a nfs-mounted disk

It's hard to see how that could make a difference to Rmail.

> --- a/lisp/mail/rmail.el
> +++ b/lisp/mail/rmail.el
> @@ -1902,7 +1902,7 @@ rmail-parse-url
>             (host  (substring file (or (match-end 2)
>                                        (+ 3 (match-end 1))))))
>  
> -       (if (rmail-remote-proto-p proto)
> +       (if (and proto (rmail-remote-proto-p proto))

It's not possible for proto to be nil here.

>             (if (not pass)
>                 (when rmail-remote-password-required
>                   (setq got-password (not (rmail-have-password)))
> @@ -1913,7 +1913,7 @@ rmail-parse-url
>               ;; does not really like it, in spite of the movemail spec.
>               (setq file (concat proto "://" user "@" host))))
>  
> -       (if (rmail-movemail-variant-p 'emacs)
> +       (if (and proto (rmail-movemail-variant-p 'emacs))

Or here.

>             (if (string-equal proto "pop")
>                 (list (concat "po:" user ":" host)
>                       proto
> @@ -2072,7 +2072,7 @@ rmail-insert-inbox-text
>                    ;; If we just read the password, most likely it is
>                    ;; wrong.  Otherwise, see if there is a specific
>                    ;; reason to think that the problem is a wrong passwd.
> -                  (if (and (rmail-remote-proto-p proto)
> +                  (if (and proto (rmail-remote-proto-p proto)

Here I think you may be correct.






  reply	other threads:[~2019-01-30  0:34 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-29 20:57 bug#34252: 27.0.50; rmail-get-new-mail fails John
2019-01-30  0:34 ` Glenn Morris [this message]
2019-01-30 18:10   ` john
2019-01-30 18:57     ` Eli Zaretskii
2019-01-30 19:34       ` John ff
2019-01-30 20:29       ` john
2019-01-31  3:32         ` Eli Zaretskii
2019-02-01  9:18           ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5k1in9e55.fsf@fencepost.gnu.org \
    --to=rgm@gnu.org \
    --cc=34252@debbugs.gnu.org \
    --cc=jpff@codemist.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).