From: "Jostein Kjønigsen" <jostein@secure.kjonigsen.net>
To: Yuan Fu <casouri@gmail.com>
Cc: fgallina@gnu.org, 59977@debbugs.gnu.org,
Theodor Thornhill <theo@thornhill.no>
Subject: bug#59977: 29.0.60; python-ts-mode does not fontify function-invocations using font-lock-function-name [PATCH]
Date: Thu, 15 Dec 2022 15:07:04 +0100 [thread overview]
Message-ID: <5fdb336f-f6cd-70c6-9390-ef284c283130@secure.kjonigsen.net> (raw)
In-Reply-To: <DC696D93-F62C-4A1F-BD80-F5E99CE8EC5F@gmail.com>
On 12.12.2022 23:54, Yuan Fu wrote:
> Ah, yes. That’s because the "definition" feature, which is by enabled by
> default, only highlights definition and ignores invocation. OTOH, the
> "function" feature highlights every instance of a function identifier,
> but it isn’t enabled by default.
I've tried latest python-ts-mode from latest emacs-29 branch, with
fontification set to level 4 and I can still reproduce this error.
Looking at the code, I cannot see any "function" feature defined, and to
me it seems a patch like the one I added is required to introduce this
functionality.
> Other tree-sitter major modes doesn’t
> have "definition" and enable "function" by default, I think.
I believe this is standard for js-ts-mode, typescript-ts-mode,
tsx-ts-mode and csharp-ts-mode. Even on level 3, and if it wasn't, as a
user of those languages, I would argue in support of having it there :)
I can't "speak" on behalf of the other major-modes though.
> I’m planning to standardize the features in each major mode according to
> the list I showed you earlier. It’d be great if you can have a look at
> that list and see if you have any opinions, before we decide on the
> final form of it and start to standardize those features in major modes.
> (Of course, each language is different, the standard feature list is
> just a base upon which major modes will extend/modify.)
>
> Yuan
I guess that is another discussion entirely (how to implement a given
set of features).
This bug is about a feature (function-call highlighting) being fully
missing :)
--
Jostein
next prev parent reply other threads:[~2022-12-15 14:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-11 20:27 bug#59977: 29.0.60; python-ts-mode does not fontify function-invocations using font-lock-function-name [PATCH] Jostein Kjønigsen
2022-12-12 22:54 ` Yuan Fu
2022-12-15 14:07 ` Jostein Kjønigsen [this message]
2022-12-16 1:35 ` Yuan Fu
2023-01-02 9:04 ` Jostein Kjønigsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5fdb336f-f6cd-70c6-9390-ef284c283130@secure.kjonigsen.net \
--to=jostein@secure.kjonigsen.net \
--cc=59977@debbugs.gnu.org \
--cc=casouri@gmail.com \
--cc=fgallina@gnu.org \
--cc=theo@thornhill.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).