From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mauro Aranda Newsgroups: gmane.emacs.bugs Subject: bug#35133: 26.1; 1) `:tag' for `restricted-sexp' (not in a choice, set, etc.), 2) Remove `Value Menu' if a no-op Date: Fri, 11 Dec 2020 11:05:48 -0300 Message-ID: <5fd37d23.1c69fb81.261a.9f56@mx.google.com> References: <4bd9e603-0d75-4de4-9bd3-6fa94a96e8a4@default> <87360f2fsp.fsf@gnus.org> <3bae30db-9eb9-4185-b549-1cdfd60efc59@default> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22933"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1.50 (gnu/linux) Cc: 35133@debbugs.gnu.org, Lars Ingebrigtsen To: Drew Adams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Dec 11 15:08:10 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1knj5e-0005te-Ge for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 11 Dec 2020 15:08:10 +0100 Original-Received: from localhost ([::1]:45802 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1knj5d-0003SZ-IH for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 11 Dec 2020 09:08:09 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35394) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1knj5X-0003S1-4T for bug-gnu-emacs@gnu.org; Fri, 11 Dec 2020 09:08:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:57288) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1knj5W-00038n-NC for bug-gnu-emacs@gnu.org; Fri, 11 Dec 2020 09:08:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1knj5W-0003Mo-Ib for bug-gnu-emacs@gnu.org; Fri, 11 Dec 2020 09:08:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Mauro Aranda Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 11 Dec 2020 14:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35133 X-GNU-PR-Package: emacs Original-Received: via spool by 35133-submit@debbugs.gnu.org id=B35133.160769565912912 (code B ref 35133); Fri, 11 Dec 2020 14:08:02 +0000 Original-Received: (at 35133) by debbugs.gnu.org; 11 Dec 2020 14:07:39 +0000 Original-Received: from localhost ([127.0.0.1]:40601 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1knj59-0003MA-6Q for submit@debbugs.gnu.org; Fri, 11 Dec 2020 09:07:39 -0500 Original-Received: from mail-qt1-f180.google.com ([209.85.160.180]:40719) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1knj57-0003Lz-VL for 35133@debbugs.gnu.org; Fri, 11 Dec 2020 09:07:38 -0500 Original-Received: by mail-qt1-f180.google.com with SMTP id n12so776156qti.7 for <35133@debbugs.gnu.org>; Fri, 11 Dec 2020 06:07:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=message-id:from:to:cc:subject:references:date:in-reply-to :user-agent:mime-version; bh=IEFEjLos5lnKt1yz8c5boEBfTdXlrX46GVGnrrODbzA=; b=hoe+6QIRTf0tPRuqc68Yx3VuQ/C+soDIYI557J2ICVcFriuLFUTs1YIxhbRy8G7/wV La0anv+CguvdObkrwYCgjqRDovZm9I3i3EAM9teYcXQFeYXBuIVoRxdUlYq8hdAoRcZc 6d//EhnRf/6rfZ7O2YjhEFsuwfhaHS+/S01Sywhenp/5Z6p4zLPJ3E6bGUOSeGjDCPX9 Bv9U7m1GENNn8bKZQAQQDFpSwI7CQMnkdmoYSBA0zDGg4z3ycMuT9GYpEXTTz3jEWECb eec8Kqkk3fYD0PnQYVji7IjYS7IU2bTLNHI7bg/o5S9IZrUp9yHahc8FhnKtB8xf+54m FV2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:from:to:cc:subject:references:date :in-reply-to:user-agent:mime-version; bh=IEFEjLos5lnKt1yz8c5boEBfTdXlrX46GVGnrrODbzA=; b=cx3I/cMw240jPSmqs0vZYqLhxXKJAZRfpyYvabgJJtzVlU0XhM6g193EjGeVmB/fav feFGxK8BFbXquywzgTscWE4Bwvd+OdDaptHwR9Sd9ljXCoigfUGu6rAjs68ZpSFiwEFE XY4VBGPNhpmKT0hHJyYRGiz1PMsn1plTgT4tIaBypQ7ureu/h92tHEmHSVcd+O5h2ge4 Uoz9M9C3DcGYfx8lLCTDAlBx9+JKxHx3R2IYfUPp/mTPgaj7hxKHDz6EVmgcI9dr7fC3 S5i4A0w6scy5qRdwOhEVhI/U5aCUEQlqwNs8Y5IvW57g1dc3Zma+KcxiQCKi19WcqRF2 mPlg== X-Gm-Message-State: AOAM5327lOV/XVHlzlf5+hk8CSbgoei4gVfVZGz8qP9NaklbGvgC6Wa5 VU6urzFin12HHuTwz+AuCFjfhkrt+YBT3A== X-Google-Smtp-Source: ABdhPJwpEj4QkYmvRIculGZW+g4Qg7sf2lr1n2qKRCUExlUn5e4VLGxC3ysmX7lywx09ol4DENEYwA== X-Received: by 2002:ac8:729a:: with SMTP id v26mr15955156qto.53.1607695651997; Fri, 11 Dec 2020 06:07:31 -0800 (PST) Original-Received: from tbb-desktop ([201.213.132.172]) by smtp.gmail.com with ESMTPSA id h25sm2748412qkh.122.2020.12.11.06.07.30 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 11 Dec 2020 06:07:31 -0800 (PST) X-Google-Original-Message-ID: <87eejw8mkj.fsf@maurooaranda@gmail.com> In-Reply-To: <3bae30db-9eb9-4185-b549-1cdfd60efc59@default> (Drew Adams's message of "Wed, 9 Dec 2020 15:30:43 -0800 (PST)") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:195753 Archived-At: Drew Adams writes: > Thanks for looking into this Mauro. > > I'd suggest handling this in two stages: > > 1. Take care of what is clearly, or pretty clearly, > straightforward. > 2. Think about how to handle other cases. > ____ > > But in general, for defcustom I think I'm in favor of > allowing the realization of a :tag, regardless of > whether using it might be problematic sometimes. I agree with you. It's just that since it's an intentional behavior (or at least looks like that), I wanted to make sure we don't miss any potentially annoying side effects. > But I guess you're asking about default tags? What > happens if there's no default :tag for some widget > (such as `repeat') but when you use the widget you > provide a :tag? Would that be possible? IOW, maybe > a :tag for `repeat' isn't useful by default, but > maybe adding a :tag when you use some `repeat' could > be useful. Indeed, I was worried about the default tags. But then I realized that we already show the "Repeat" tag, when the repeat is part of a choice type, so it looks like my worries are void. Same goes for the choice widget inside any other grouping widget. > (For the problematic cases, maybe the tag text should be > shown without the trailing colon? Maybe it depends on > where the tag is placed and how long the string is.) I think it's better to keep the colon. > Anyway, for now at least, #1 would be great. Thx. AFAICS, we should be able to do #1 without trouble, by removing the :format value-format line, and accounting for the space after the tag when creating the item.