unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Drew Adams <drew.adams@oracle.com>
To: Eli Zaretskii <eliz@gnu.org>, Drew Adams <drew.adams@oracle.com>
Cc: 31807@debbugs.gnu.org
Subject: bug#31807: 27.0; `info-apropos' bad name or bad matching
Date: Thu, 14 Jun 2018 07:42:11 -0700 (PDT)	[thread overview]
Message-ID: <5fc07c84-b8d2-493c-a17b-774ad1c213bf@default> (raw)
In-Reply-To: <<83in6l30ir.fsf@gnu.org>>

> > If you want to keep the current behavior then I'd suggest
> > having two different commands AND, for the one that does
> > literal string matching, change the name to something that
> > does not include "apropos" in the name.
> 
> I'm okay with a new command, but it should have a new name.  How about
> info-apropos-regexp?  The old command must keep its name, for the same
> reason we cannot change its behavior.

It's you who decide, of course.  But I disagree about the
name(s).

"Apropos", in Emacs, always has and always should mean (at
least) regexp-matching.  As a notion it is _opposed_ to
literal string matching, indicating that something more
general or more approximate is going on wrt matching.

A command name like `*-apropos-regexp' is a bad idea, IMO.
It just confuses.  And a command name `*-apropos' that
does only literal matching is an even worse idea, and it
is worse yet if accompanied by another command called
`*-apropos-regexp'.

Again, my suggestion is to "enhance" the behavior of
`info-apropos', to make it really do "apropos" matching.
For anyone who might prefer literal-matching, either it
could take a prefix arg to provide that or a separate,
literal(-only)-matching command could be added.

I seriously doubt that anyone will be upset if `info-apropos'
is enhanced to support more general matching.

Did you present the same, we-can't-enhance-because-legacy
argument when Kim (I think it was) added keyword-matching
to the `apropos*' commands?

Did you say that those commands have always accepted only
a regexp arg and just matched it directly?  Did you suggest
that alternative (new) commands be added that provide
keyword + regexp matching, and that tacked on the suffix
`-keyword' to their names (e.g. `apropos-command-regexp')?
I don't think you did - and rightfully so.  And no one
(including me) complained about that behavior enhancement.

> > > Btw, does this really work as intended without changes to
> > > Info-apropos-matches?  That function calls regexp-quote on its
> > > argument.
> >
> > Dunno.  When I get some time I'll take a closer look.
> 
> Thanks.

You're welcome.  But I haven't done it yet. ;-)





       reply	other threads:[~2018-06-14 14:42 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <<78156de2-86c8-4593-92b5-59edf7a8996e@default>
     [not found] ` <<83o9gd33dj.fsf@gnu.org>
     [not found]   ` <<a4bf1dd4-d411-4a74-b5dd-9b7abaef9250@default>
     [not found]     ` <<83in6l30ir.fsf@gnu.org>
2018-06-14 14:42       ` Drew Adams [this message]
2018-06-14 15:09         ` bug#31807: 27.0; `info-apropos' bad name or bad matching Eli Zaretskii
2018-06-14 20:45       ` Drew Adams
2022-04-21 15:05         ` Lars Ingebrigtsen
2022-04-21 20:04           ` Drew Adams
     [not found] <<<<78156de2-86c8-4593-92b5-59edf7a8996e@default>
     [not found] ` <<<<83o9gd33dj.fsf@gnu.org>
     [not found]   ` <<<<a4bf1dd4-d411-4a74-b5dd-9b7abaef9250@default>
     [not found]     ` <<<<83in6l30ir.fsf@gnu.org>
     [not found]       ` <<<5fc07c84-b8d2-493c-a17b-774ad1c213bf@default>
     [not found]         ` <<<83fu1p2ym7.fsf@gnu.org>
     [not found]           ` <<73c2c21d-9fba-4ab5-a0b0-8b36e9a23bcf@default>
     [not found]             ` <<83efh92wr2.fsf@gnu.org>
2018-06-14 15:58               ` Drew Adams
     [not found] <<<78156de2-86c8-4593-92b5-59edf7a8996e@default>
     [not found] ` <<<83o9gd33dj.fsf@gnu.org>
     [not found]   ` <<<a4bf1dd4-d411-4a74-b5dd-9b7abaef9250@default>
     [not found]     ` <<<83in6l30ir.fsf@gnu.org>
     [not found]       ` <<5fc07c84-b8d2-493c-a17b-774ad1c213bf@default>
     [not found]         ` <<83fu1p2ym7.fsf@gnu.org>
2018-06-14 15:33           ` Drew Adams
2018-06-14 15:50             ` Eli Zaretskii
2018-06-12 23:01 Drew Adams
2018-06-12 23:21 ` Drew Adams
2018-06-12 23:39   ` Drew Adams
2018-06-12 23:59     ` Drew Adams
2018-06-14 13:29       ` Eli Zaretskii
2018-06-13  0:04     ` Noam Postavsky
2018-06-13  0:16       ` Drew Adams
2018-06-13 18:24         ` Drew Adams
     [not found]     ` <<eb245b09-a156-4585-8021-7a3e0e173dbc@default>
     [not found]       ` <<83muvx33ab.fsf@gnu.org>
2018-06-14 14:16         ` Drew Adams
2018-06-17  7:44           ` Eli Zaretskii
     [not found]     ` <<<eb245b09-a156-4585-8021-7a3e0e173dbc@default>
     [not found]       ` <<<83muvx33ab.fsf@gnu.org>
     [not found]         ` <<f7814f7b-d9c0-48d5-83aa-b354b047db10@default>
     [not found]           ` <<83muvtuab9.fsf@gnu.org>
2018-06-17 14:26             ` Drew Adams
2018-06-14 13:27 ` Eli Zaretskii
2018-06-14 14:11   ` Drew Adams
2018-06-14 14:28     ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5fc07c84-b8d2-493c-a17b-774ad1c213bf@default \
    --to=drew.adams@oracle.com \
    --cc=31807@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).