From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Phil Sainty Newsgroups: gmane.emacs.bugs Subject: bug#40967: 27.0.50; vc-diff in indirect buffers Date: Wed, 17 Jun 2020 00:08:40 +1200 Message-ID: <5f6e0c6c-d699-d9ff-34f6-a8967fc84dfb@orcon.net.nz> References: <4a643eda-2b72-857e-4d25-3b9bcbd1e086@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="34868"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 To: Dmitry Gutov , Nathan Moreau , 40967@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jun 16 14:09:16 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jlAOy-0008xs-3k for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 16 Jun 2020 14:09:16 +0200 Original-Received: from localhost ([::1]:56842 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jlAOx-0001e6-2H for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 16 Jun 2020 08:09:15 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50872) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jlAOk-0001di-Dl for bug-gnu-emacs@gnu.org; Tue, 16 Jun 2020 08:09:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36883) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jlAOk-0001Mz-4i for bug-gnu-emacs@gnu.org; Tue, 16 Jun 2020 08:09:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jlAOj-000788-W4 for bug-gnu-emacs@gnu.org; Tue, 16 Jun 2020 08:09:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Phil Sainty Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 16 Jun 2020 12:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40967 X-GNU-PR-Package: emacs Original-Received: via spool by 40967-submit@debbugs.gnu.org id=B40967.159230932827386 (code B ref 40967); Tue, 16 Jun 2020 12:09:01 +0000 Original-Received: (at 40967) by debbugs.gnu.org; 16 Jun 2020 12:08:48 +0000 Original-Received: from localhost ([127.0.0.1]:48429 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlAOW-00077e-7J for submit@debbugs.gnu.org; Tue, 16 Jun 2020 08:08:48 -0400 Original-Received: from smtp-1.orcon.net.nz ([60.234.4.34]:42019) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlAOU-00077U-9Q for 40967@debbugs.gnu.org; Tue, 16 Jun 2020 08:08:46 -0400 Original-Received: from [101.53.216.44] (port=5448 helo=[192.168.20.103]) by smtp-1.orcon.net.nz with esmtpa (Exim 4.90_1) (envelope-from ) id 1jlAOP-0002tq-6K; Wed, 17 Jun 2020 00:08:41 +1200 In-Reply-To: <4a643eda-2b72-857e-4d25-3b9bcbd1e086@yandex.ru> Content-Language: en-GB X-GeoIP: NZ X-Spam_score: -2.9 X-Spam_score_int: -28 X-Spam_bar: -- X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:182021 Archived-At: On 30/04/20 6:13 am, Dmitry Gutov wrote: > On 29.04.2020 21:01, Nathan Moreau wrote: >> open any file-under-version-control >> M-x clone-indirect-buffer >> In the new buffer, run vc-diff fails with `vc-deduce-fileset: >> Buffer [...] is not associated with a file` > > I'm not sure we really want to support that workflow. Or else > a lot of commands would have to be changed the same way, > inside and outside of VC. > > But opinions welcome. FWIW, we did the same thing for `diff-buffer-with-file' quite recently: https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=1bcf5d02da96784a04034b4c0aba8fdfa1413c4e Personally I'd be ok with seeing piecemeal changes to commands like these to enable certain common workflows to DTRT with indirect buffers. I think there will likely be a subset of commands which are of higher value than others, and so there might not be such a vast number of things which are very useful to change in practice. (Or maybe it's a slippery slope.) Something like the following might be convenient: (defun buffer-base-buffer-file-name (&optional buffer) "Like `buffer-file-name', but also supporting indirect buffers." (buffer-file-name (or (buffer-base-buffer buffer) buffer (current-buffer)))) -Phil