From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.bugs Subject: bug#33847: 27.0.50; emacsclient does not find server socket Date: Sat, 24 Jul 2021 00:48:25 -0700 Organization: UCLA Computer Science Department Message-ID: <5f457b50-c1bd-4856-33c7-f85edf111bd0@cs.ucla.edu> References: <8a6fc59c-08b3-e274-4fb1-74674c79540a@cs.ucla.edu> <27d2f2eb-8956-4088-f3ec-5ff6c2cf2e8f@cs.ucla.edu> <87eeo27v6k.fsf@gnus.org> <83lfi79klf.fsf@gnu.org> <831rjya5yy.fsf@gnu.org> <8333533f-08ec-acd4-2fbf-f06e78591e98@cs.ucla.edu> <83v9h99awv.fsf@gnu.org> <878s1yjy20.fsf@gnus.org> <83lf5y2t78.fsf@gnu.org> <878s1yi8jc.fsf@gnus.org> <83h7gm2r4j.fsf@gnu.org> <87wnphe06g.fsf@gnus.org> <87r1fpdzuy.fsf@gnus.org> <838s1w1b7x.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16519"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 Cc: teika@gmx.com, 33847@debbugs.gnu.org, larsi@gnus.org, ulm@gentoo.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jul 24 09:49:12 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m7CPH-000478-8s for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 24 Jul 2021 09:49:11 +0200 Original-Received: from localhost ([::1]:55350 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m7CPF-0001H7-9K for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 24 Jul 2021 03:49:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54112) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m7CP8-0001Gv-SP for bug-gnu-emacs@gnu.org; Sat, 24 Jul 2021 03:49:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33556) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m7CP8-0006WK-L1 for bug-gnu-emacs@gnu.org; Sat, 24 Jul 2021 03:49:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1m7CP8-0002zS-GO for bug-gnu-emacs@gnu.org; Sat, 24 Jul 2021 03:49:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Paul Eggert Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 24 Jul 2021 07:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33847 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 33847-submit@debbugs.gnu.org id=B33847.162711291811459 (code B ref 33847); Sat, 24 Jul 2021 07:49:02 +0000 Original-Received: (at 33847) by debbugs.gnu.org; 24 Jul 2021 07:48:38 +0000 Original-Received: from localhost ([127.0.0.1]:45102 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m7COj-0002yl-LS for submit@debbugs.gnu.org; Sat, 24 Jul 2021 03:48:37 -0400 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:59228) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m7COe-0002yU-Tp for 33847@debbugs.gnu.org; Sat, 24 Jul 2021 03:48:36 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 62F8A1600DB; Sat, 24 Jul 2021 00:48:27 -0700 (PDT) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id xYxxoSksbEl5; Sat, 24 Jul 2021 00:48:26 -0700 (PDT) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 37CAB1600EF; Sat, 24 Jul 2021 00:48:26 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 87_S09gqUGYW; Sat, 24 Jul 2021 00:48:26 -0700 (PDT) Original-Received: from [192.168.1.9] (cpe-172-91-119-151.socal.res.rr.com [172.91.119.151]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id EAF5B1600DB; Sat, 24 Jul 2021 00:48:25 -0700 (PDT) In-Reply-To: <838s1w1b7x.fsf@gnu.org> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:210622 Archived-At: On 7/23/21 11:23 PM, Eli Zaretskii wrote: > why in conjunction with this particular issue? It's typically better to sync to a single coherent version of Gnulib,=20 than to take bits and pieces from different versions of Gnulib. That way=20 one needn't worry about version mismatch. >> Although I fixed the glitches Eli noted, the other Gnulib changes may >> need further changes to Emacs's Microsoft-related code. >=20 > Which of the Gnulib changes might need that, please? I said that more as boilerplate than as careful analysis. But in looking=20 at the patch more carefully, there may be issues in nt/gnulib-cfg.mk=20 where you have to set the following appropriately for MS-Windows: OMIT_GNULIB_MODULE_realloc-gnu OMIT_GNULIB_MODULE_realloc-posix The realloc-posix module supplies a 'realloc' that conforms to POSIX=20 (i.e., it sets errno when it fails, and it refuses to allocate anything=20 larger than PTRDIFF_MAX in size). The realloc-gnu module in addition makes sure that 'realloc' is=20 compatible with GNU realloc (i.e., realloc (NULL, 0) returns nonnull=20 when it succeeds). The new file lib/realloc.c arranges for a replacement realloc on=20 platforms where realloc-posix and/or realloc-gnu discover that the=20 system realloc doesn't match glibc realloc in behavior. The msdos directory may need to do something similar. Also, it may need=20 to change "GNULIB_" to "GL_GNULIB_" for identifiers like GNULIB_GETLOADAV= G. There may be other issues, but these are the ones that jump out at me. Hmm, come to think of it, does Emacs already arrange to avoid the=20 problematic realloc behavior areas? If so, we can avoid using=20 realloc-gnu and realloc-posix, which would simplify the patch a bit.