unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Drew Adams <drew.adams@oracle.com>
To: Eli Zaretskii <eliz@gnu.org>, Tino Calancha <tino.calancha@gmail.com>
Cc: 25665@debbugs.gnu.org, mail@xuchunyang.me
Subject: bug#25665: 26.0.50; [PATCH] Indicate prefix arg in minibuffer prompt for shell-command
Date: Thu, 9 Feb 2017 13:00:51 -0800 (PST)	[thread overview]
Message-ID: <5e6c5385-19a0-4705-9e62-8c0974047fa0@default> (raw)
In-Reply-To: <<83r3373y3f.fsf@gnu.org>>

> > I am not sure about this.
> > The meaning of the prefix argument must be explained in the docstring.
> > That and the manual are the source of documentation, not the prompt.
> >
> > Having a short prompt is also good because there are more space
> > in the line for the command; a short prompt is also better while tipying
> > a long command: sometimes you want to change something at the beginning:
> > < ; `beginning-of-buffer'
> > Now you need to `C-f' several times to jump out of the prompt.  The more
> > verbose prompt, the more `C-f' you need.
> >
> > Just my opinion.  Let's see what other people think.
> 
> I think it goes against Emacs conventions.  We have quite a few
> commands that insert output into the current buffer when invoked with
> an argument.

(Sorry, I misunderstood the suggestion.  I didn't look at the
patch, and didn't get that this was about changing a _prompt_.)

I don't think the suggestion "goes against Emacs conventions".

Certainly it is the case that we do not do this for most
commands that do something different when invoked with a
prefix arg.

But there is a difference between a command that prompts
and one, such as `eval-last-sexp', that does not.  Most
"commands that insert output" when you use a prefix arg
do not prompt, I think. 

And I know of no convention that says that a command should
not use a different prompt when a prefix arg is used.

It's a judgment call.  For this one I have no opinion.

I don't think, however, that the length of the prompt is
very important here.  That's a fairly weak criterion for
deciding whether to change the prompt.

Doing something like what was suggested could be helpful
mainly in a situation where (1) the behavior is very
different if a prefix arg is used and (2) it's not easy
to undo a mistaken use of the command.

If that's not the case here then I don't see a need for it.





       reply	other threads:[~2017-02-09 21:00 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <<m2wpczwgay.fsf@xuchunyang.me>
     [not found] ` <<8760kjz4nv.fsf@calancha-pc>
     [not found]   ` <<83r3373y3f.fsf@gnu.org>
2017-02-09 21:00     ` Drew Adams [this message]
2017-02-09 15:10 bug#25665: 26.0.50; [PATCH] Indicate prefix arg in minibuffer prompt for shell-command Chunyang Xu
2017-02-09 16:53 ` Tino Calancha
2017-02-09 18:08   ` Drew Adams
2017-02-09 20:31   ` Eli Zaretskii
2017-02-10  4:23     ` Chunyang Xu
2017-02-09 22:54   ` npostavs
2017-02-10  3:05     ` Tino Calancha
2017-02-10  4:16       ` npostavs
2017-02-10  7:13         ` Tino Calancha
2017-02-10 16:19           ` Noam Postavsky
2019-06-24 23:04   ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5e6c5385-19a0-4705-9e62-8c0974047fa0@default \
    --to=drew.adams@oracle.com \
    --cc=25665@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=mail@xuchunyang.me \
    --cc=tino.calancha@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).