* bug#66377: srecode-map-save-file :type doesn't allow nil @ 2023-10-06 20:08 Mauro Aranda 2023-10-06 20:11 ` Mauro Aranda 0 siblings, 1 reply; 3+ messages in thread From: Mauro Aranda @ 2023-10-06 20:08 UTC (permalink / raw) To: 66377 The docstring of srecode-map-save-file says its value can be nil, but its :type is just file. ^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#66377: srecode-map-save-file :type doesn't allow nil 2023-10-06 20:08 bug#66377: srecode-map-save-file :type doesn't allow nil Mauro Aranda @ 2023-10-06 20:11 ` Mauro Aranda 2023-10-07 6:52 ` Eli Zaretskii 0 siblings, 1 reply; 3+ messages in thread From: Mauro Aranda @ 2023-10-06 20:11 UTC (permalink / raw) To: 66377 [-- Attachment #1: Type: text/plain, Size: 39 bytes --] tags 66377 patch quit Patch attached. [-- Attachment #2: 0001-Fix-a-defcustom-type.patch --] [-- Type: text/x-patch, Size: 920 bytes --] From 009542663d482a22427f621140bf365c861bfb81 Mon Sep 17 00:00:00 2001 From: Mauro Aranda <maurooaranda@gmail.com> Date: Fri, 6 Oct 2023 17:02:37 -0300 Subject: [PATCH] Fix a defcustom :type * lisp/cedet/srecode/map.el (srecode-map-save-file): Expand :type to allow nil. (Bug#66377) --- lisp/cedet/srecode/map.el | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lisp/cedet/srecode/map.el b/lisp/cedet/srecode/map.el index 125459d6eeb..004bb7adddb 100644 --- a/lisp/cedet/srecode/map.el +++ b/lisp/cedet/srecode/map.el @@ -49,7 +49,8 @@ srecode-map-save-file "The save location for SRecode's map file. If the save file is nil, then the MAP is not saved between sessions." :group 'srecode - :type 'file) + :type '(choice (const :tag "Don't save" nil) + file)) (defclass srecode-map (eieio-persistent) ((fileheaderline :initform ";; SRECODE TEMPLATE MAP") -- 2.34.1 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* bug#66377: srecode-map-save-file :type doesn't allow nil 2023-10-06 20:11 ` Mauro Aranda @ 2023-10-07 6:52 ` Eli Zaretskii 0 siblings, 0 replies; 3+ messages in thread From: Eli Zaretskii @ 2023-10-07 6:52 UTC (permalink / raw) To: Mauro Aranda; +Cc: 66377-done > Date: Fri, 6 Oct 2023 17:11:07 -0300 > From: Mauro Aranda <maurooaranda@gmail.com> > > tags 66377 patch > quit > > > Patch attached. Thanks, installed on the emacs-29 branch, and closing the bug. ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-10-07 6:52 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2023-10-06 20:08 bug#66377: srecode-map-save-file :type doesn't allow nil Mauro Aranda 2023-10-06 20:11 ` Mauro Aranda 2023-10-07 6:52 ` Eli Zaretskii
Code repositories for project(s) associated with this public inbox https://git.savannah.gnu.org/cgit/emacs.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).