unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: martin rudalics <rudalics@gmx.at>
To: Michael Heerdegen <michael_heerdegen@web.de>
Cc: 46908@debbugs.gnu.org, Yuan Fu <casouri@gmail.com>
Subject: bug#46908: 28.0.50; Dozens of spurious markers in buffer-undo-list
Date: Mon, 8 Mar 2021 09:26:42 +0100	[thread overview]
Message-ID: <5e12eae1-94fd-d2c7-923d-f4dbabf3da52@gmx.at> (raw)
In-Reply-To: <87mtve2t2q.fsf@web.de>

 >> I cannot confirm that, no.  I can reproduce the issue in a newly built
 >> Emacs 27 as well as in the 27 that comes with Debian.  "It" again being
 >> `count-markers-in-buffer-undo-list'.
 >
 > The issue disappears (marker count stays constantly less than 3) if I
 > comment out these two expressions in `push-mark':
 >
 >    (add-to-history 'mark-ring (copy-marker (mark-marker)) mark-ring-max t)
 >
 >    (add-to-history
 >      'global-mark-ring (copy-marker (mark-marker)) global-mark-ring-max t)
 >
 > I think we really have a problem here: when those newly created markers
 > are thrown out of the rings, they are not invalidated, and are also
 > still referenced by buffer-undo-list, so they will live forever, AFAIU.

So you mean that we really have two problems here, both caused by
`push-mark'?  IIUC a marker is "thrown out of the rings" when its buffer
gets deleted or a marker is pushed on a "full" ring.  I suppose that
"invalidating" markers in these cases should be safe.  But how comes
that `add-to-history' affects `buffer-undo-list'?

martin





  reply	other threads:[~2021-03-08  8:26 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-03 22:45 bug#46908: 28.0.50; Dozens of spurious markers in buffer-undo-list Michael Heerdegen
2021-03-04  8:35 ` martin rudalics
2021-03-04 16:40   ` Michael Heerdegen
2021-03-04 17:20     ` martin rudalics
2021-03-04 18:35       ` Michael Heerdegen
2021-03-05  9:11         ` martin rudalics
2021-03-05  9:50           ` martin rudalics
2021-03-06  0:51             ` Michael Heerdegen
2021-03-06  7:48               ` Eli Zaretskii
2021-03-07  2:45                 ` Michael Heerdegen
2021-03-06  8:40               ` martin rudalics
2021-03-07  2:40                 ` Michael Heerdegen
2021-03-08  4:00               ` Michael Heerdegen
2021-03-08  8:26                 ` martin rudalics [this message]
2021-03-09  2:04                   ` Michael Heerdegen
2021-03-09  2:20                     ` Michael Heerdegen
2022-06-20  0:04                       ` Lars Ingebrigtsen
2022-06-20 13:56                         ` Michael Heerdegen
2021-03-09  8:10                     ` martin rudalics
2021-03-10  2:17                       ` Michael Heerdegen
2021-03-10  5:49                     ` Richard Stallman
2021-03-09  6:19                 ` Richard Stallman
2021-03-10  2:22                   ` Michael Heerdegen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5e12eae1-94fd-d2c7-923d-f4dbabf3da52@gmx.at \
    --to=rudalics@gmx.at \
    --cc=46908@debbugs.gnu.org \
    --cc=casouri@gmail.com \
    --cc=michael_heerdegen@web.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).