From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#21025: tabulated-list.el: It should preserve header line set by derived modes. (Encl. a suggested PATCH) Date: Tue, 25 Jun 2019 09:35:57 -0700 (PDT) Message-ID: <5d81d55b-8f22-435c-aaf5-8c93db7beec5@default> References: <559EBE29.8000302@gmail.com> <87k2lvvk1z.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="44849"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 21025@debbugs.gnu.org To: Lars Ingebrigtsen , Vaidheeswaran C Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jun 25 18:39:07 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hfoTL-000BXE-5B for geb-bug-gnu-emacs@m.gmane.org; Tue, 25 Jun 2019 18:39:07 +0200 Original-Received: from localhost ([::1]:33982 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hfoTK-0003br-7s for geb-bug-gnu-emacs@m.gmane.org; Tue, 25 Jun 2019 12:39:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49351) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hfoRM-00028q-3l for bug-gnu-emacs@gnu.org; Tue, 25 Jun 2019 12:37:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hfoRK-0000Yr-Oo for bug-gnu-emacs@gnu.org; Tue, 25 Jun 2019 12:37:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48083) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hfoRK-0000Yb-Hj for bug-gnu-emacs@gnu.org; Tue, 25 Jun 2019 12:37:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hfoRK-0006RQ-D4 for bug-gnu-emacs@gnu.org; Tue, 25 Jun 2019 12:37:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 25 Jun 2019 16:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21025 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 21025-submit@debbugs.gnu.org id=B21025.156148057524696 (code B ref 21025); Tue, 25 Jun 2019 16:37:02 +0000 Original-Received: (at 21025) by debbugs.gnu.org; 25 Jun 2019 16:36:15 +0000 Original-Received: from localhost ([127.0.0.1]:33394 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hfoQW-0006QD-Do for submit@debbugs.gnu.org; Tue, 25 Jun 2019 12:36:12 -0400 Original-Received: from userp2120.oracle.com ([156.151.31.85]:55354) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hfoQQ-0006Pb-JW for 21025@debbugs.gnu.org; Tue, 25 Jun 2019 12:36:09 -0400 Original-Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x5PGJOhM072957; Tue, 25 Jun 2019 16:36:00 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2018-07-02; bh=NzOKmnrHObF9kwNc68wTC+7elidNCJCOyUqc5+6arFA=; b=15qRj3qbACfSP8LIjotvmnLDI2UH6/qG0EfFjCWTBKNOPOnJGcUmnSdZ35pLfYockq7q 8xz8BxiSNOLDNnqpwZ6Nvj6pu9CqBCQKGFtbuzmNlAFtyV4hmbCHJ8dGlPXJ3RO4S163 floMPbUv2DZOxqfd9+gC+Pgz5NLva+qUmPA9ubDcGiIor4LRWpNmnoWEP0sfl9rtVD7S ddXirnMDEiIQFeJABlcMEB79FIesLCdeiHyLV58DiiHTgymCE8ffARWHd+VxyH4r/TLv fjF0vsYqu/c/lwVN8ubz5vXqDx2KblWcGdbrPZHqfd5SAWXHP192+nFZ0FqrEuR7uFz9 gw== Original-Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by userp2120.oracle.com with ESMTP id 2t9cyqdg2k-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 25 Jun 2019 16:36:00 +0000 Original-Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x5PGZUxV022170; Tue, 25 Jun 2019 16:35:59 GMT Original-Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by aserp3030.oracle.com with ESMTP id 2t9acc74nv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 25 Jun 2019 16:35:59 +0000 Original-Received: from abhmp0016.oracle.com (abhmp0016.oracle.com [141.146.116.22]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id x5PGZwnq004445; Tue, 25 Jun 2019 16:35:58 GMT In-Reply-To: X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4861.0 (x86)] X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9299 signatures=668687 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1906250124 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9299 signatures=668687 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1906250124 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:161397 Archived-At: > >> - (overlay-put tabulated-list--header-overlay 'face 'underline)))= ) > >> + (overlay-put tabulated-list--header-overlay > >> + 'face '(:overline t :underline t :weight bold))))) > > > > This might be more controversial, though. I think it looks nice, but > > some people don't like so many lines. Perhaps it should be a defface, > > so that people can change this themselves? The default could be what > > you're describing, though. >=20 > I've now done this change and otherwise applied your patch. This is a bad way to do things - makes it difficult for users do customize the appearance. Emacs is "the extensible, customizable, self-documenting, real-time display editor". The right way to take care of what is essentially a user's preference for column-header appearance is not to change the hard-coded appearance but to define a face for this in `tabulated-list.el'. Then ALL users can get the appearance they want just by customizing that face. The face can have whatever default appearance you want: underline, underline and overline - whatever. But let users customize a face; do not hard-code one.