From: Drew Adams <drew.adams@oracle.com>
To: Lars Ingebrigtsen <larsi@gnus.org>,
Vaidheeswaran C <vaidheeswaran.chinnaraju@gmail.com>
Cc: 21025@debbugs.gnu.org
Subject: bug#21025: tabulated-list.el: It should preserve header line set by derived modes. (Encl. a suggested PATCH)
Date: Tue, 25 Jun 2019 09:35:57 -0700 (PDT) [thread overview]
Message-ID: <5d81d55b-8f22-435c-aaf5-8c93db7beec5@default> (raw)
In-Reply-To: <m3sgrx4pea.fsf@gnus.org>
> >> - (overlay-put tabulated-list--header-overlay 'face 'underline))))
> >> + (overlay-put tabulated-list--header-overlay
> >> + 'face '(:overline t :underline t :weight bold)))))
> >
> > This might be more controversial, though. I think it looks nice, but
> > some people don't like so many lines. Perhaps it should be a defface,
> > so that people can change this themselves? The default could be what
> > you're describing, though.
>
> I've now done this change and otherwise applied your patch.
This is a bad way to do things - makes it difficult
for users do customize the appearance. Emacs is "the
extensible, customizable, self-documenting, real-time
display editor".
The right way to take care of what is essentially a
user's preference for column-header appearance is not
to change the hard-coded appearance but to define a
face for this in `tabulated-list.el'. Then ALL users
can get the appearance they want just by customizing
that face.
The face can have whatever default appearance you
want: underline, underline and overline - whatever.
But let users customize a face; do not hard-code one.
next prev parent reply other threads:[~2019-06-25 16:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-09 18:32 bug#21025: tabulated-list.el: It should preserve header line set by derived modes. (Encl. a suggested PATCH) Vaidheeswaran C
2015-07-12 23:16 ` Artur Malabarba
2015-07-13 2:55 ` Vaidheeswaran C
2015-07-13 18:56 ` Artur Malabarba
2016-02-23 9:43 ` Lars Ingebrigtsen
2019-06-25 16:10 ` Lars Ingebrigtsen
2019-06-25 16:35 ` Drew Adams [this message]
2019-06-25 16:39 ` Lars Ingebrigtsen
2019-06-25 17:12 ` Drew Adams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5d81d55b-8f22-435c-aaf5-8c93db7beec5@default \
--to=drew.adams@oracle.com \
--cc=21025@debbugs.gnu.org \
--cc=larsi@gnus.org \
--cc=vaidheeswaran.chinnaraju@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).