From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.bugs Subject: bug#36597: 27.0.50; rehash hash tables eagerly in pdumper Date: Wed, 12 Aug 2020 12:11:09 -0700 Organization: UCLA Computer Science Department Message-ID: <5d686746-a4aa-5864-d3b8-c58621d24279@cs.ucla.edu> References: <83r26mv53z.fsf@gnu.org> <87ft8vbow1.fsf@gnus.org> <87v9hq4ppp.fsf@gnus.org> <83k0y544lf.fsf@gnu.org> <8bf60d70-6b0d-0e07-fef9-9baad9d7749c@cs.ucla.edu> <837du5p17p.fsf@gnu.org> <63d00359-f7cc-5564-ecf0-d374dea979ff@cs.ucla.edu> <83zh71ni7r.fsf@gnu.org> <80399aee-a2ef-5d24-a19e-5ea615190cf9@cs.ucla.edu> <83pn7wneed.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4829"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 Cc: larsi@gnus.org, 36597@debbugs.gnu.org, pipcet@gmail.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Aug 12 21:12:12 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k5wAV-00018i-Qo for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 12 Aug 2020 21:12:11 +0200 Original-Received: from localhost ([::1]:55120 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k5wAU-0000yt-TW for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 12 Aug 2020 15:12:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56690) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k5wAM-0000xJ-IA for bug-gnu-emacs@gnu.org; Wed, 12 Aug 2020 15:12:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:34068) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k5wAM-0007X9-8K for bug-gnu-emacs@gnu.org; Wed, 12 Aug 2020 15:12:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1k5wAM-0008SZ-29 for bug-gnu-emacs@gnu.org; Wed, 12 Aug 2020 15:12:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Paul Eggert Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 12 Aug 2020 19:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36597 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 36597-submit@debbugs.gnu.org id=B36597.159725948032470 (code B ref 36597); Wed, 12 Aug 2020 19:12:02 +0000 Original-Received: (at 36597) by debbugs.gnu.org; 12 Aug 2020 19:11:20 +0000 Original-Received: from localhost ([127.0.0.1]:45614 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k5w9g-0008Re-0n for submit@debbugs.gnu.org; Wed, 12 Aug 2020 15:11:20 -0400 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:57060) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k5w9c-0008RQ-Dp for 36597@debbugs.gnu.org; Wed, 12 Aug 2020 15:11:18 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 029091600DA; Wed, 12 Aug 2020 12:11:11 -0700 (PDT) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id lrzeFcjhmJVX; Wed, 12 Aug 2020 12:11:10 -0700 (PDT) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 09DB21600F9; Wed, 12 Aug 2020 12:11:10 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id DbBKt0_JucHQ; Wed, 12 Aug 2020 12:11:09 -0700 (PDT) Original-Received: from [192.168.1.9] (cpe-75-82-69-226.socal.res.rr.com [75.82.69.226]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id D042A1600DA; Wed, 12 Aug 2020 12:11:09 -0700 (PDT) Autocrypt: addr=eggert@cs.ucla.edu; prefer-encrypt=mutual; keydata= LS0tLS1CRUdJTiBQR1AgUFVCTElDIEtFWSBCTE9DSy0tLS0tCgptUUlOQkV5QWNtUUJFQURB QXlIMnhvVHU3cHBHNUQzYThGTVpFb243NGRDdmM0K3ExWEEySjJ0QnkycHdhVHFmCmhweHhk R0E5Smo1MFVKM1BENGJTVUVnTjh0TFowc2FuNDdsNVhUQUZMaTI0NTZjaVNsNW04c0thSGxH ZHQ5WG0KQUF0bVhxZVpWSVlYL1VGUzk2ZkR6ZjR4aEVtbS95N0xiWUVQUWRVZHh1NDd4QTVL aFRZcDVibHRGM1dZRHoxWQpnZDdneDA3QXV3cDdpdzdlTnZub0RUQWxLQWw4S1lEWnpiRE5D UUdFYnBZM2VmWkl2UGRlSStGV1FONFcra2doCnkrUDZhdTZQcklJaFlyYWV1YTdYRGRiMkxT MWVuM1NzbUUzUWpxZlJxSS9BMnVlOEpNd3N2WGUvV0szOEV6czYKeDc0aVRhcUkzQUZINmls QWhEcXBNbmQvbXNTRVNORnQ3NkRpTzFaS1FNcjlhbVZQa25qZlBtSklTcWRoZ0IxRApsRWR3 MzRzUk9mNlY4bVp3MHhmcVQ2UEtFNDZMY0ZlZnpzMGtiZzRHT1JmOHZqRzJTZjF0azVlVThN Qml5Ti9iClowM2JLTmpOWU1wT0REUVF3dVA4NGtZTGtYMndCeHhNQWhCeHdiRFZadWR6eERa SjFDMlZYdWpDT0pWeHEya2wKakJNOUVUWXVVR3FkNzVBVzJMWHJMdzYrTXVJc0hGQVlBZ1Jy NytLY3dEZ0JBZndoU In-Reply-To: <83pn7wneed.fsf@gnu.org> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:184867 Archived-At: On 8/12/20 7:10 AM, Eli Zaretskii wrote: > If that module is in our repository only because of MS-Windows, then > it indeed isn't needed. OK, I removed it. > I don't understand why it uses 'long int' 32-bit platforms, it looks > gratuitous, especially since MinGW itself uses just 'int'. (Another > question is why Gnulib thinks it needs to redefine intptr_t, but if > the redefinition was correct, this would not be especially important.) As I recall the idea was to not worry about the plethora of buggy intptr_t implementations at the time, and just substitute Gnulib's own. Nowadays perhaps that decision should be revisited. I looked into the MinGW situation and the problem seems to be that MinGW defined a macro _INTPTR_T_DEFINED that it no longer defines, and Gnulib was keying off that no-longer-present macro. I installed a patch for that in Gnulib here: https://lists.gnu.org/r/bug-gnulib/2020-08/msg00088.html and migrated the patch into Emacs. Hope it fixes things. As an aside, we're spending too much time on pdumper.c code that has no effect because dump_trace never outputs anything. How about if I remove dump_trace and its callers? Although dump_trace may have been useful when the portable dumper got developed, it's just a developer time sink now.