unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Drew Adams <drew.adams@oracle.com>
To: Eli Zaretskii <eliz@gnu.org>, Drew Adams <drew.adams@oracle.com>,
	Michael Kifer <kifer@cs.stonybrook.edu>
Cc: 16744@debbugs.gnu.org
Subject: bug#16744: 24.3.50; REGRESSION: C-h v does not show doc for `ediff-highlight-all-diffs'
Date: Thu, 13 Feb 2014 13:01:16 -0800 (PST)	[thread overview]
Message-ID: <5d29cc74-f4db-4961-b111-32b5d8e6477b@default> (raw)
In-Reply-To: <<83txc2dadt.fsf@gnu.org>>

> That's because of the ediff-defvar-local macro:
> 
>   (defcustom ediff-highlight-all-diffs t
>     "If nil, only the selected differences are highlighted.
>   Otherwise, all difference regions are highlighted, but the
> selected region is
>   shown in brighter colors."
>     :type 'boolean
>     :group 'ediff-highlighting)
>   (ediff-defvar-local ediff-highlight-all-diffs t "")
> 
> It is invoked (here and elsewhere) with an empty string as the doc,
> so that's what you get.

I see.  Seems like such a macro, if really needed, should at least
reuse the main doc string, in _addition_ to adding any local-binding
doc string.  Or perhaps allow for either adding or replacing.
But it should not require duplicating the literal string as an
argument, just to provide doc for the local var.





       reply	other threads:[~2014-02-13 21:01 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <<4d0cbf1a-914e-493c-bb2f-186229902418@default>
     [not found] ` <<83txc2dadt.fsf@gnu.org>
2014-02-13 21:01   ` Drew Adams [this message]
2014-02-13 19:31 bug#16744: 24.3.50; REGRESSION: C-h v does not show doc for `ediff-highlight-all-diffs' Drew Adams
2014-02-13 20:29 ` Eli Zaretskii
     [not found] ` <1913911dabee4a1e979c4914631ac676@HUBCAS2.cs.stonybrook.edu>
2014-02-14  7:53   ` Michael Kifer
2014-02-14  9:22     ` Eli Zaretskii
2014-02-14 10:20       ` Michael Kifer
2014-02-14 10:43   ` Michael Kifer
2014-02-14 11:14     ` Eli Zaretskii
2014-02-14 19:14       ` Michael Kifer
2014-02-14 20:58         ` Eli Zaretskii
2014-02-14 21:08           ` Glenn Morris
2014-02-14 21:52           ` Michael Kifer
2014-02-14 22:22             ` Glenn Morris
2014-02-14 22:35               ` Michael Kifer
2014-02-14 23:24               ` Michael Kifer
2014-02-16  3:34               ` Glenn Morris
2014-02-15 10:02             ` Andreas Schwab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5d29cc74-f4db-4961-b111-32b5d8e6477b@default \
    --to=drew.adams@oracle.com \
    --cc=16744@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=kifer@cs.stonybrook.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).