1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
| | ;;; eval-tests.el --- unit tests for src/eval.c -*- lexical-binding: t; -*-
;; Copyright (C) 2016-2023 Free Software Foundation, Inc.
;; Author: Philipp Stephani <phst@google.com>
;; This file is part of GNU Emacs.
;; GNU Emacs is free software: you can redistribute it and/or modify
;; it under the terms of the GNU General Public License as published by
;; the Free Software Foundation, either version 3 of the License, or
;; (at your option) any later version.
;; GNU Emacs is distributed in the hope that it will be useful,
;; but WITHOUT ANY WARRANTY; without even the implied warranty of
;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
;; GNU General Public License for more details.
;; You should have received a copy of the GNU General Public License
;; along with GNU Emacs. If not, see <https://www.gnu.org/licenses/>.
;;; Commentary:
;; Unit tests for src/eval.c.
;;; Code:
(require 'ert)
(eval-when-compile (require 'cl-lib))
(require 'subr-x)
(ert-deftest eval-tests--bug24673 ()
"Check that Bug#24673 has been fixed."
;; This should not crash.
(should-error (funcall '(closure)) :type 'invalid-function))
(defvar byte-compile-debug)
(ert-deftest eval-tests--bugs-24912-and-24913 ()
"Check that Emacs doesn't accept weird argument lists.
Bug#24912 and Bug#24913."
(dolist (lb '(t false))
(ert-info ((prin1-to-string lb) :prefix "lexical-binding: ")
(let ((lexical-binding lb))
(dolist (args '((&rest &optional)
(&rest a &optional) (&rest &optional a)
(&optional &optional) (&optional &optional a)
(&optional a &optional b)
(&rest &rest) (&rest &rest a)
(&rest a &rest b)
(&rest) (&optional &rest)
))
(ert-info ((prin1-to-string args) :prefix "args: ")
(should-error
(eval `(funcall (lambda ,args)) lb) :type 'invalid-function)
(should-error (byte-compile-check-lambda-list args))
(let ((byte-compile-debug t))
(should-error (eval `(byte-compile (lambda ,args)) lb)))))))))
(ert-deftest eval-tests-accept-empty-optional ()
"Check that Emacs accepts empty &optional arglists.
Bug#24912."
(dolist (lb '(t false))
(ert-info ((prin1-to-string lb) :prefix "lexical-binding: ")
(let ((lexical-binding lb))
(dolist (args '((&optional) (&optional &rest a)))
(ert-info ((prin1-to-string args) :prefix "args: ")
(let ((fun `(lambda ,args 'ok)))
(ert-info ("eval")
(should (eq (funcall (eval fun lb)) 'ok)))
(ert-info ("byte comp check")
(byte-compile-check-lambda-list args))
(ert-info ("bytecomp")
(let ((byte-compile-debug t))
(should (eq (funcall (byte-compile fun)) 'ok)))))))))))
(dolist (form '(let let*))
(dolist (arg '(1 "a" [a]))
(eval
`(ert-deftest ,(intern (format "eval-tests--%s--%s" form (type-of arg))) ()
,(format "Check that the first argument of `%s' cannot be a %s"
form (type-of arg))
(should-error (,form ,arg) :type 'wrong-type-argument))
t)))
(ert-deftest eval-tests--if-dot-string ()
"Check that Emacs rejects (if . \"string\")."
(should-error (eval '(if . "abc") nil) :type 'wrong-type-argument)
(should-error (eval '(if . "abc") t) :type 'wrong-type-argument)
(let ((if-tail (list '(setcdr if-tail "abc") t)))
(should-error (eval (cons 'if if-tail) nil) :type 'void-variable)
(should-error (eval (cons 'if if-tail) t) :type 'void-variable))
(let ((if-tail (list '(progn (setcdr if-tail "abc") nil) t)))
(should-error (eval (cons 'if if-tail) nil) :type 'void-variable)
(should-error (eval (cons 'if if-tail) t) :type 'void-variable)))
(ert-deftest eval-tests--let-with-circular-defs ()
"Check that Emacs reports an error for (let VARS ...) when VARS is circular."
(let ((vars (list 'v)))
(setcdr vars vars)
(dolist (let-sym '(let let*))
(should-error (eval (list let-sym vars) nil)))))
(ert-deftest eval-tests--mutating-cond ()
"Check that Emacs doesn't crash on a cond clause that mutates during eval."
(let ((clauses (list '((progn (setcdr clauses "ouch") nil)))))
(should-error (eval (cons 'cond clauses) nil))
(should-error (eval (cons 'cond clauses) t))))
(ert-deftest defvar/bug31072 ()
"Check that Bug#31072 is fixed."
(should-error (eval '(defvar 1) t) :type 'wrong-type-argument))
(ert-deftest defvaralias-overwrite-warning ()
"Test for Bug#5950."
(defvar eval-tests--foo)
(setq eval-tests--foo 2)
(defvar eval-tests--foo-alias)
(setq eval-tests--foo-alias 1)
(cl-letf (((symbol-function 'display-warning)
(lambda (type &rest _)
(throw 'got-warning type))))
;; Warn if we lose a value through aliasing.
(should (equal
'(defvaralias losing-value eval-tests--foo-alias)
(catch 'got-warning
(defvaralias 'eval-tests--foo-alias 'eval-tests--foo))))
;; Don't warn if we don't.
(makunbound 'eval-tests--foo-alias)
(should (eq 'no-warning
(catch 'got-warning
(defvaralias 'eval-tests--foo-alias 'eval-tests--foo)
'no-warning)))))
(ert-deftest eval-tests-byte-code-being-evaluated-is-protected-from-gc ()
"Regression test for Bug#33014.
Check that byte-compiled objects being executed by exec-byte-code
are found on the stack and therefore not garbage collected."
(should (string= (eval-tests-33014-func)
"before after: ok foo: (e) bar: (a b c d e) baz: a bop: c")))
(defvar eval-tests-33014-var "ok")
(defun eval-tests-33014-func ()
"A function which has a non-trivial constants vector when byte-compiled."
(let ((result "before "))
(eval-tests-33014-redefine)
(garbage-collect)
(setq result (concat result (format "after: %s" eval-tests-33014-var)))
(let ((vals '(0 1 2 3))
(things '(a b c d e)))
(dolist (val vals)
(setq result
(concat result " "
(cond
((= val 0) (format "foo: %s" (last things)))
((= val 1) (format "bar: %s" things))
((= val 2) (format "baz: %s" (car things)))
(t (format "bop: %s" (nth 2 things))))))))
result))
(defun eval-tests-33014-redefine ()
"Remove the Lisp reference to the byte-compiled object."
(setf (symbol-function #'eval-tests-33014-func) nil))
(ert-deftest eval-tests-19790-backquote-comma-dot-substitution ()
"Regression test for Bug#19790.
Don't handle destructive splicing in backquote expressions (like
in Common Lisp). Instead, make sure substitution in backquote
expressions works for identifiers starting with period."
(should (equal (let ((.x 'identity)) (eval `(,.x 'ok) nil)) 'ok))
(should (equal (let ((.x 'identity)) (eval `(,.x 'ok) t)) 'ok)))
(ert-deftest eval-tests/backtrace-in-batch-mode ()
(let ((emacs (expand-file-name invocation-name invocation-directory)))
(skip-unless (file-executable-p emacs))
(with-temp-buffer
(let ((status (call-process emacs nil t nil
"--quick" "--batch"
(concat "--eval="
(prin1-to-string
'(progn
(defun foo () (error "Boo"))
(foo)))))))
(should (natnump status))
(should-not (eql status 0)))
(goto-char (point-min))
(ert-info ((concat "Process output:\n" (buffer-string)))
(search-forward " foo()")
(search-forward " normal-top-level()")))))
(ert-deftest eval-tests/backtrace-in-batch-mode/inhibit ()
(let ((emacs (expand-file-name invocation-name invocation-directory)))
(skip-unless (file-executable-p emacs))
(with-temp-buffer
(let ((status (call-process
emacs nil t nil
"--quick" "--batch"
(concat "--eval="
(prin1-to-string
'(progn
(defun foo () (error "Boo"))
(let ((backtrace-on-error-noninteractive nil))
(foo))))))))
(should (natnump status))
(should-not (eql status 0)))
(should (equal (string-trim (buffer-string)) "Boo")))))
(ert-deftest eval-tests/backtrace-in-batch-mode/demoted-errors ()
(let ((emacs (expand-file-name invocation-name invocation-directory)))
(skip-unless (file-executable-p emacs))
(with-temp-buffer
(should (eql 0 (call-process emacs nil t nil
"--quick" "--batch"
(concat "--eval="
(prin1-to-string
'(with-demoted-errors "Error: %S"
(error "Boo")))))))
(goto-char (point-min))
(should (equal (string-trim (buffer-string))
"Error: (error \"Boo\")")))))
(ert-deftest eval-tests/funcall-with-delayed-message ()
;; Check that `funcall-with-delayed-message' displays its message before
;; its function terminates if the timeout is short enough.
;; This also serves as regression test for bug#55628 where a short
;; timeout was rounded up to the next whole second.
(dolist (params '((0.8 0.4)
(0.1 0.8)))
(let ((timeout (nth 0 params))
(work-time (nth 1 params)))
(ert-info ((prin1-to-string params) :prefix "params: ")
(with-current-buffer "*Messages*"
(let ((inhibit-read-only t))
(erase-buffer))
(let ((stop (+ (float-time) work-time)))
(funcall-with-delayed-message
timeout "timed out"
(lambda ()
(while (< (float-time) stop))
(message "finished"))))
(let ((expected-messages
(if (< timeout work-time)
"timed out\nfinished"
"finished")))
(should (equal (string-trim (buffer-string))
expected-messages))))))))
(defvar-local eval-test--local-var 'global)
(ert-deftest eval-test--bug62419 ()
(with-temp-buffer
(setq eval-test--local-var 'first-local)
(let ((eval-test--local-var t))
(kill-local-variable 'eval-test--local-var)
(setq eval-test--local-var 'second-local)
(should (eq eval-test--local-var 'second-local)))
;; FIXME: It's not completely clear if exiting the above `let'
;; should restore the buffer-local binding to `first-local'
;; (i.e. reset the value of the second buffer-local binding to the
;; first's initial value) or should do nothing (on the principle that
;; the first buffer-local binding doesn't exists any more so there's
;; nothing to restore). I think both semantics make sense.
;;(should (eq eval-test--local-var 'first-local))
)
(should (eq eval-test--local-var 'global)))
(ert-deftest eval-tests-defvaralias ()
(defvar eval-tests--my-var 'coo)
(defvaralias 'eval-tests--my-var1 'eval-tests--my-var)
(defvar eval-tests--my-var1)
(should (equal eval-tests--my-var 'coo))
(should (equal eval-tests--my-var1 'coo))
(defvaralias 'eval-tests--my-a 'eval-tests--my-b)
(defvaralias 'eval-tests--my-b 'eval-tests--my-c)
(should-error (defvaralias 'eval-tests--my-c 'eval-tests--my-c)
:type 'cyclic-variable-indirection)
(defvaralias 'eval-tests--my-d 'eval-tests--my-a)
(should-error (defvaralias 'eval-tests--my-c 'eval-tests--my-d)
:type 'cyclic-variable-indirection))
(defvar eval-tests/global-var 'global-value)
(defvar-local eval-tests/buffer-local-var 'default-value)
(ert-deftest eval-tests/default-value ()
;; `let' overrides the default value for global variables.
(should (default-boundp 'eval-tests/global-var))
(should (eq 'global-value (default-value 'eval-tests/global-var)))
(should (eq 'global-value eval-tests/global-var))
(let ((eval-tests/global-var 'let-value))
(should (eq 'let-value (default-value 'eval-tests/global-var)))
(should (eq 'let-value eval-tests/global-var)))
;; `let' overrides the default value everywhere, but leaves
;; buffer-local values unchanged in current buffer and in the
;; buffers where there is no explicitly set buffer-local value.
(should (default-boundp 'eval-tests/buffer-local-var))
(should (eq 'default-value (default-value 'eval-tests/buffer-local-var)))
(should (eq 'default-value eval-tests/buffer-local-var))
(with-temp-buffer
(let ((eval-tests/buffer-local-var 'let-value))
(should (eq 'let-value (default-value 'eval-tests/buffer-local-var)))
(should (eq 'let-value eval-tests/buffer-local-var))))
;; When current buffer has explicit buffer-local binding, `let' does
;; not alter the default binding.
(with-temp-buffer
(setq-local eval-tests/buffer-local-var 'local-value)
(let ((eval-tests/buffer-local-var 'let-value))
;; Let in a buffer with local binding does not change the
;; default value for variable.
(should (eq 'default-value (default-value 'eval-tests/buffer-local-var)))
(should (eq 'let-value eval-tests/buffer-local-var))
(with-temp-buffer
;; We are in a new buffer - `eval-tests/buffer-local-var' has its global default value.
(should (eq 'default-value (default-value 'eval-tests/buffer-local-var)))
(should (eq 'default-value eval-tests/buffer-local-var))))))
;;; eval-tests.el ends here
|