From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.bugs Subject: bug#60083: 29.0.60; eshell-elecslash when in the root directory of a remote host Date: Sun, 18 Dec 2022 12:04:47 -0800 Message-ID: <5cddf6c8-ac52-0bd7-c523-82ce1e75c99f@gmail.com> References: <3f509b4aaaa957d43a429b2ee843c88312486e86.camel@laposte.net> <83o7s1f1at.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36143"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 60083@debbugs.gnu.org To: Eli Zaretskii , montag451 Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Dec 18 21:05:25 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p6zuW-0009E1-PH for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 18 Dec 2022 21:05:24 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p6zuG-00042m-B2; Sun, 18 Dec 2022 15:05:08 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p6zuA-00042B-K5 for bug-gnu-emacs@gnu.org; Sun, 18 Dec 2022 15:05:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p6zuA-0006sz-5x for bug-gnu-emacs@gnu.org; Sun, 18 Dec 2022 15:05:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p6zu9-0004Bi-LY for bug-gnu-emacs@gnu.org; Sun, 18 Dec 2022 15:05:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 18 Dec 2022 20:05:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60083 X-GNU-PR-Package: emacs Original-Received: via spool by 60083-submit@debbugs.gnu.org id=B60083.167139390016089 (code B ref 60083); Sun, 18 Dec 2022 20:05:01 +0000 Original-Received: (at 60083) by debbugs.gnu.org; 18 Dec 2022 20:05:00 +0000 Original-Received: from localhost ([127.0.0.1]:35660 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p6zu7-0004BR-Qf for submit@debbugs.gnu.org; Sun, 18 Dec 2022 15:05:00 -0500 Original-Received: from mail-pl1-f181.google.com ([209.85.214.181]:33772) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p6zu5-0004BD-4t for 60083@debbugs.gnu.org; Sun, 18 Dec 2022 15:04:57 -0500 Original-Received: by mail-pl1-f181.google.com with SMTP id 17so7218456pll.0 for <60083@debbugs.gnu.org>; Sun, 18 Dec 2022 12:04:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=KYtEiPKnfcQB5RtNHXizCLgelow2loHf1IVptSDgPPk=; b=CSg5fKHIr1tIaLYN4MRvy5Rc0tLsTuP+2q38vDI28mHFEJb++XdDL/vn5t8ENUFKYB GFMhCzSMcukWSVsv4KC9Hk4T1VEOP+Vg+c7eLzNbRUaHhRuAk3msbgvtAbK4bfx/1NTD uxB/E40mYN6fWuIPrjd+Gb8qVqq0wrvZRP10icpCysPcih5e2IPp1tbMzMoZsVEcrhfG UEL0GnQLdNv+czUlR+Iivtgjgk4xlIhuBmm/y2+F5UU4NQNQTuO5A55iYkeDhriZQ6LE gjnn4qbC615tzdCByE/gckx0C/BhPuydeqSgtRsA1s/fgWeScMua96c3jZLKaq1qSL0D Oh4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=KYtEiPKnfcQB5RtNHXizCLgelow2loHf1IVptSDgPPk=; b=bx7cGe/5AyuHg3fIinx0c0cDk3uk/tvv8msfp06enIk1+/gNE6n+3EUuFdGq5clVNX 7MzqZANyW6EJe1EREDDZ9sOxXZPzIimNWjJRXota6qiibFdOqYPcXD/Aq9LbReQ1L09i zXeBzlwzbReAGHWGSHg+bISwboKXLRL1teIILgaOxLn1DInT80nlSc94YO9lFT/4OnKU 2bxW9BxAn1/KbxKDpvzAFv/P/ADv9SNCJWiDM7cprWTva17Kf763HVERQnXycHEdfZKO T3BLY0XDQDHcpSJaK5g2DzkOR74DldDsOPIghxsCl9vK5j/a/DIBK9J3ig5iMctpDomP eVuA== X-Gm-Message-State: ANoB5pmpNj+vFJRgd+ffYOJtkooYi/vi/hurd9ejHUzFuw5O9KHhnDkB crly6U+oy7IPA7ShGyrY2mg= X-Google-Smtp-Source: AA0mqf6J65+UxXbDaDVMOu5uAmT4lkULj/HUC3rXo38e7DyvNfsfbddOdgI7knRykM1YrrLY6bpQSw== X-Received: by 2002:a17:90a:fc85:b0:21a:b64:3488 with SMTP id ci5-20020a17090afc8500b0021a0b643488mr40316862pjb.44.1671393891257; Sun, 18 Dec 2022 12:04:51 -0800 (PST) Original-Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id rm10-20020a17090b3eca00b0020b21019086sm14005419pjb.3.2022.12.18.12.04.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 18 Dec 2022 12:04:50 -0800 (PST) Content-Language: en-US In-Reply-To: <83o7s1f1at.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:251376 Archived-At: On 12/18/2022 2:34 AM, Eli Zaretskii wrote: >> Date: Thu, 15 Dec 2022 00:46:50 +0100 >> From: montag451 via "Bug reports for GNU Emacs, >> the Swiss army knife of text editors" >> >> While testing the new eshell module 'eshell-elecslash' I found a bug >> when the default-directory is the root of a remote host. To reproduce >> the problem type the following in a eshell buffer (replacing "method" >> and "host" by appropriate values): >> >> $ cd /method:host:/ >> $ cd / <--- here the "/" should be replaced by "/method:host:/" but >> instead nothing happen >> >> I've attached a patch to this email which fixes this issue. > > Jim, are you looking into this issue? Thanks. I missed the original message. The patch looks good to me, although it compiles with the following warning: In eshell-electric-forward-slash: ../../lisp/eshell/em-elecslash.el:98:18: Warning: Unused lexical variable `localname' Looking through the code, I think we can just remove that variable. Since this is a small change, and fixes a corner case in a new feature, I think it would make sense to go on the release branch, though I'll defer to you on this, Eli. The fact that the new code (with the removal of 'localname') is a bit simpler helps too.