unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Dmitry Gutov <dgutov@yandex.ru>
To: "Eli Zaretskii" <eliz@gnu.org>, "積丹尼 Dan Jacobson" <jidanni@jidanni.org>
Cc: 30462@debbugs.gnu.org
Subject: bug#30462: flyspell-auto-correct-word 'corrects' more than the current word
Date: Tue, 20 Feb 2018 02:24:32 +0200	[thread overview]
Message-ID: <5cbfcff1-1f97-bf78-cb19-a9241a517092@yandex.ru> (raw)
In-Reply-To: <83sh9zbnsu.fsf@gnu.org>

On 2/17/18 6:09 PM, Eli Zaretskii wrote:

> I think I see the reason for this: it's a stale cache from a previous
> invocation of flyspell-auto-correct-word that is not flushed when you
> type more text or move point.  So flyspell-auto-correct-word tries to
> correct the same word het time you invoke it, no matter how far away
> are you.

So it seems like it was an implementation accident after all (i.e. a 
bug), rather than a old behavior worth preserving.

> Please try the patch below (you will need to byte-compile flyspell.el
> after applying the patch).  If it gives good results, please run with
> it for a while and see if there are any problems left.  If this change
> has no adverse effects, I will push it.

It does fix the scenarios I could come up with. Looks like a good change 
to me, thanks!





  parent reply	other threads:[~2018-02-20  0:24 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-15  6:24 bug#30462: flyspell-auto-correct-word 'corrects' more than the current word 積丹尼 Dan Jacobson
2018-02-15 12:00 ` Eli Zaretskii
2018-02-15 12:56   ` 積丹尼 Dan Jacobson
2018-02-15 16:56     ` Eli Zaretskii
2018-02-16  0:22       ` 積丹尼 Dan Jacobson
2018-02-16 10:15       ` Dmitry Gutov
2018-02-16 10:55         ` Eli Zaretskii
2018-02-16 11:03           ` 積丹尼 Dan Jacobson
2018-02-16 11:36           ` Dmitry Gutov
2018-02-16 13:47             ` Eli Zaretskii
2018-02-16 14:18               ` Eli Zaretskii
2018-02-16 14:33                 ` Eli Zaretskii
2018-02-17  0:58                   ` 積丹尼 Dan Jacobson
2018-02-17  7:47                     ` Eli Zaretskii
2018-02-17 11:43                       ` 積丹尼 Dan Jacobson
2018-02-17 14:51                       ` 積丹尼 Dan Jacobson
2018-02-17 15:13                       ` 積丹尼 Dan Jacobson
2018-02-17 16:09                         ` Eli Zaretskii
2018-02-17 23:37                           ` 積丹尼 Dan Jacobson
2018-02-20  0:24                           ` Dmitry Gutov [this message]
2018-02-20  4:08                             ` Eli Zaretskii
2018-03-03 10:49                               ` Eli Zaretskii
2018-02-20  0:28                 ` Dmitry Gutov
2018-02-20  4:24                   ` Eli Zaretskii
2018-02-20 11:38                     ` Dmitry Gutov
2018-02-20 17:57                       ` 積丹尼 Dan Jacobson
2018-02-20  0:51               ` Dmitry Gutov
2018-02-18  0:14   ` Richard Stallman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5cbfcff1-1f97-bf78-cb19-a9241a517092@yandex.ru \
    --to=dgutov@yandex.ru \
    --cc=30462@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=jidanni@jidanni.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).