From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jostein =?UTF-8?Q?Kj=C3=B8nigsen?= Newsgroups: gmane.emacs.bugs Subject: bug#59660: 29.0.50; typescript-ts-mode consistently fontifies method-names incorrectly Date: Tue, 29 Nov 2022 14:58:59 +0100 Message-ID: <5c6866bb-c353-58ee-39e4-9d861965e943@secure.kjonigsen.net> References: <83k03em05w.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11954"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Cc: 59660@debbugs.gnu.org, jostein@kjonigsen.net, theo@thornhill.no To: Eli Zaretskii , Yuan Fu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Nov 29 15:00:37 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p01A2-0002ro-Rv for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 29 Nov 2022 15:00:36 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p019f-0001By-8S; Tue, 29 Nov 2022 09:00:11 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p019Y-0001At-Jw for bug-gnu-emacs@gnu.org; Tue, 29 Nov 2022 09:00:06 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p019X-0001sA-UL for bug-gnu-emacs@gnu.org; Tue, 29 Nov 2022 09:00:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p019W-0002nq-QA for bug-gnu-emacs@gnu.org; Tue, 29 Nov 2022 09:00:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Jostein =?UTF-8?Q?Kj=C3=B8nigsen?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 29 Nov 2022 14:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59660 X-GNU-PR-Package: emacs Original-Received: via spool by 59660-submit@debbugs.gnu.org id=B59660.166973035610735 (code B ref 59660); Tue, 29 Nov 2022 14:00:02 +0000 Original-Received: (at 59660) by debbugs.gnu.org; 29 Nov 2022 13:59:16 +0000 Original-Received: from localhost ([127.0.0.1]:54518 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p018m-0002n5-5O for submit@debbugs.gnu.org; Tue, 29 Nov 2022 08:59:16 -0500 Original-Received: from wout3-smtp.messagingengine.com ([64.147.123.19]:55765) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p018i-0002mw-1p for 59660@debbugs.gnu.org; Tue, 29 Nov 2022 08:59:13 -0500 Original-Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 6EF15320024A; Tue, 29 Nov 2022 08:59:02 -0500 (EST) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Tue, 29 Nov 2022 08:59:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= secure.kjonigsen.net; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm3; t=1669730341; x=1669816741; bh=CLfy5PHLZv z55LHWJaipuDDSZUpVya+zkxFVRi/GKBU=; b=dogvogwZAdvFh1xxQYON9+Dqa/ moPuYKH4NobVFqDWGJ4FONHx6YiF1qiNEcmFCzCDiyyLNng6VqtcW1opaHP84YAf 3gPES9FylcsTYhf6eAY0YHVX+kWbQYLd0UBrio0UT6S2zl+ktafEBMgFyl1JZKcg XML+P7+govJvwJ26bqNEPiVSY4f5ffiNYGjKYfH/LwDDiQ21bffQw64SwT0BWU2y vHvqMgCjhl8MIVzSW5vcutqNA2HTCb8uQLMDkMAoYVNp/5ZIz2tbkBYm1ayfRsQj Y3j1LufzaOVAk+8ljVf33YnYS2aI4RJyF6FmXTSD9/0mXFbSpy/+NpzNrAXg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1669730341; x= 1669816741; bh=CLfy5PHLZvz55LHWJaipuDDSZUpVya+zkxFVRi/GKBU=; b=W pmwRVMgAiIVNMVM/CUufS8uSGlEXDAY7LqSCOL7Ja3+BuZUB2uTvjb+VyXteQJ0v /7BCNnPRWPgNqmRI8oK9ClprnJjDXE7dYIJtI3mfMJK7uxP0GtjN2HH5sgiLTQc1 TQ9SJ3FVWN28zmrSjdbFv1Ko6EpwMjQNRahWKXWjgbDBjXSh2KsTtoe5JxkqfD2d 7nNHLH6Bl0eqZ+dGbiDlCYILOW1HQJYjMMEXtTCJxYfi0yABkbIFFyELBhgvRXO/ s3TEPAA0kLEmGYFR5zN8iKgqgSN83GS8zQClXe8RpteRXIg8IiL+KlJA6jv6vJI6 +9ccGEli6agTAkMzi9AHA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrtddtgddvlecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefkffggfgfuvfevfhfhjggtgfesthekredttdefjeenucfhrhhomheplfhoshht vghinhcumfhjpphnihhgshgvnhcuoehjohhsthgvihhnsehsvggtuhhrvgdrkhhjohhnih hgshgvnhdrnhgvtheqnecuggftrfgrthhtvghrnheptddujefhvdekudefudffuddvuddu ieetheehkeelhedvgedtieevvdefieejtdffnecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepjhhoshhtvghinhesshgvtghurhgvrdhkjhhonhhi ghhsvghnrdhnvght X-ME-Proxy: Feedback-ID: ib2f84088:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 29 Nov 2022 08:59:00 -0500 (EST) Content-Language: en-US In-Reply-To: <83k03em05w.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:249397 Archived-At: Cc: 59660@debbugs.gnu.org, theo@thornhill.no >> From: Yuan Fu >> Date: Mon, 28 Nov 2022 15:06:30 -0800 >> >> Maybe you can remove the :override flag for the property_identifier rule, so it doesn’t shadow the function rule? Would that work better? I plan to test that as quickly as I time permits. If we can make both behaviours work, that would obviously be the best. > This could be a personal preference, perhaps? It isn't clear to me that > only one of the two is definitely correct. So maybe we need a user option > for which one overrides which? I honestly think this is reasonably clear. "Properties" with getters and setters are at this point in time almost entirely unused in EcmaScript/TypeScript space. They are optional and have complicated syntax, and don't play well with JSON serialization (and thus can't be used in REST APIs). You however cannot write a program without defining or invoking methods/functions. So not having method-fontification working correctly will literally impact **all** TypeScript-users. -- Jostein