From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.bugs Subject: bug#60845: 30.0.50; [PATCH] Add tests for Eshell interactive completion (and fix a bug in it) Date: Tue, 10 Oct 2023 13:07:50 -0700 Message-ID: <5c5c40d0-34f4-34ff-6cdd-9a2852ee97b4@gmail.com> References: <2b75d4d4-0533-2182-6da8-413391577bf5@gmail.com> <40d31b3d-d429-5a48-02bc-a3c1e4a1d903@gmail.com> <8f725450-1158-67de-7a0f-d550d867e084@gmail.com> <990abf69-d2f9-7582-c4dd-fd6bdebf04b3@gmail.com> <46c56cb6-deff-bc8f-7d29-9401b7d261b1@gmail.com> <488af1f4-f075-09e8-3b45-1d1a65266c68@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19620"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 60845-done@debbugs.gnu.org, Daniel Mendler , Gregory Heytings , arstoffel@gmail.com, Stefan Monnier To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Oct 10 22:08:57 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qqJ2F-0004oV-CP for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 10 Oct 2023 22:08:55 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qqJ24-0004CZ-IG; Tue, 10 Oct 2023 16:08:44 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qqJ22-0004BU-5Q for bug-gnu-emacs@gnu.org; Tue, 10 Oct 2023 16:08:42 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qqJ21-0007nQ-E4 for bug-gnu-emacs@gnu.org; Tue, 10 Oct 2023 16:08:41 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qqJ2M-0001H3-Kc for bug-gnu-emacs@gnu.org; Tue, 10 Oct 2023 16:09:02 -0400 Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Tue, 10 Oct 2023 20:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 60845 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Mail-Followup-To: 60845@debbugs.gnu.org, jporterbugs@gmail.com, jporterbugs@gmail.com Original-Received: via spool by 60845-done@debbugs.gnu.org id=D60845.16969685014828 (code D ref 60845); Tue, 10 Oct 2023 20:09:02 +0000 Original-Received: (at 60845-done) by debbugs.gnu.org; 10 Oct 2023 20:08:21 +0000 Original-Received: from localhost ([127.0.0.1]:36976 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qqJ1h-0001Fo-JW for submit@debbugs.gnu.org; Tue, 10 Oct 2023 16:08:21 -0400 Original-Received: from mail-pl1-x62a.google.com ([2607:f8b0:4864:20::62a]:47449) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qqJ1f-0001FZ-F0 for 60845-done@debbugs.gnu.org; Tue, 10 Oct 2023 16:08:20 -0400 Original-Received: by mail-pl1-x62a.google.com with SMTP id d9443c01a7336-1c434c33ec0so38204645ad.3 for <60845-done@debbugs.gnu.org>; Tue, 10 Oct 2023 13:07:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696968472; x=1697573272; darn=debbugs.gnu.org; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=gCLJlLr+ZzUJRUdzfYLAujlMXVi27ZZ5uMB/qG+FTWc=; b=j4T1c1vozTebtVv1E96iVFjsBBoQaJzKqJfUMI2cKJcljisHzy8HUNQIvwDUPmMnv8 a8eYDxyCDNDCV7qzwZjILdwsbGYotJMFxVOObJp+mDnQKE5Gasj5Rv1vpFHGy58eUlH5 ZK7S26z9boWlaJdX3FjkgjCDUUQzrD/P8CdAH5DtyYobh/7QL0WD5DISDopwTWGKRjRB T3TbArYlJKKCnadOKAqsjdRTk6zubtwrwZfOrzewSpCQ+UFhCGDCO8wRawBIFTOjnQzh iLF4vH+X4MB75rG4nTSfGXh5aVJbIuAmNb553oq/jf4nQAXv6rRJVKEvI5mn7+V8HLff dRqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696968472; x=1697573272; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=gCLJlLr+ZzUJRUdzfYLAujlMXVi27ZZ5uMB/qG+FTWc=; b=bCuBvZZp3Wl1DusmrfJmp/t65tvUahvmKT3WPKp60iatPrkiYJBPaCa+IR9bE8dsSz xlxitZwEHcLOgjhmyaOagkuOG3M1P8yGXQg9ZjOCVN/A89BoXvsQ+saGGJYQ5uKGyHkD //cF6Q+AYCdOdYJ03T93t2utY4hpT5K+mqE7ZqCEV33GhNk7ZmL+Iwb3ChioeiZhOZBs O/hhNGgOeRKZRacdtXJSbTRFJZd+iwrTTt/M4yiBxrySmZxsn2P24PpVO/XYBlCFfZIW LPbsqx1yNYt0yz8m+PxJndNJPVQgFPd8zwpBoJpBDaBQ4iQbkEl0MLCffqpI28yPtrk5 KNqA== X-Gm-Message-State: AOJu0Ywk6xMv1x+wSCdtB4rmY11/2p9An64vk6O3oWCNNSPczIQK6k2X YKCEIi5ZEDPYzcV0mRVqkvU= X-Google-Smtp-Source: AGHT+IEjcrnMc0oXn0Wl+YN+VrfHPVNGBhq9ypeDwxP5GflefDIZUHCCFaSgV/+8HA9gFY07GHfaig== X-Received: by 2002:a17:902:ea8d:b0:1c0:c640:3f3e with SMTP id x13-20020a170902ea8d00b001c0c6403f3emr17099099plb.42.1696968472161; Tue, 10 Oct 2023 13:07:52 -0700 (PDT) Original-Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id 19-20020a17090a1a1300b00273744e6eccsm11577883pjk.12.2023.10.10.13.07.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 Oct 2023 13:07:51 -0700 (PDT) Content-Language: en-US In-Reply-To: <488af1f4-f075-09e8-3b45-1d1a65266c68@gmail.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:272231 Archived-At: On 9/5/2023 6:37 PM, Jim Porter wrote: > Attached is a patch to revert the Emacs 29 workarounds. I *believe* I've > fixed this on the Eshell side by always providing Pcomplete with the > arguments in their string form. Could everyone try the patch out to make > sure things still work? > > In particular, see the cases in the following bugs: bug#60464, > bug#60021, and bug#59956. Since there have been no further comments in the last month, I've now merged my patch to the master branch as 239db5d5162. If anyone sees any issues resulting from this, feel free to back it out, file a bug, and/or let me know directly.